[WIP] Mod Builder

[NanoSector]

Released 1.1. Although still buggy (and bug patches will be released), it now converts mod packages into projects ready to be edited using the Mod Editor. So insert any mod that you feel needs an edit and it'll be ready to be edited!
I also fixed a couple of bugs.

1.1.1 released immediately after which fixes a bug with update checking.

Happy modding!

[Adrek]

Don't know if they are known bugs, but I'll report them anyway

If package ID contains underline, it's being removed after package is converted to MM format.
If in package-info.xml is readme 'inline' then it's not converted.
In operation edit window new lines are not parsed (all is in one line, however after saving package it looks fine)

And small suggestion - could you replace "Browse for folder" window with this one used by SMF in (for example) attachments select? It would be much easier to find desired folder

[NanoSector]

Don't know if they are known bugs, but I'll report them anyway

If package ID contains underline, it's being removed after package is converted to MM format.

Mod Manager removes everything from the ID except for letters and numbers. I don't know which characters are allowed in the package ID, but I can add _ to the regex.

If in package-info.xml is readme 'inline' then it's not converted.

It should be... Can you send me a sample package or a link to the mod you downloaded?

In operation edit window new lines are not parsed (all is in one line, however after saving package it looks fine)

Hmm that's a bug... I'll look into this. The same happens with readmes and custom code apparently.

And small suggestion - could you replace "Browse for folder" window with this one used by SMF in (for example) attachments select? It would be much easier to find desired folder

I've been trying to do this, but found no way to do this easily. This is a .NET limitation, sadly

Thanks

[Arantor]

Mod Manager removes everything from the ID except for letters and numbers. I don't know which characters are allowed in the package ID, but I can add _ to the regex.

It's actually very generous. SMF itself doesn't really care, the mod site doesn't like spaces but other than that, it just has to fit into 32 characters including the :.

Alphanumeric plus _ should really be it honestly.

[NanoSector]

Mod Manager removes everything from the ID except for letters and numbers. I don't know which characters are allowed in the package ID, but I can add _ to the regex.

It's actually very generous. SMF itself doesn't really care, the mod site doesn't like spaces but other than that, it just has to fit into 32 characters including the :.

Alphanumeric plus _ should really be it honestly.

Thanks, I'll add _ to the regex in the next update.

Since I'm not a regex master, I would just replace this:

Code Select Expand

[^a-zA-Z0-9]

With this:

Code Select Expand

[^a-zA-Z0-9_]

Right?

[Arantor]

Pretty much. Hard to say without seeing the whole thing. Personally I wouldn't validate that it doesn't contain things it shouldn't, I'd validate it that it is valid as a whole.

/^[a-z0-9_]+:[a-z0-9_]+$/i and then validate the entire length as <= 32.

[NanoSector]

Code Select Expand

                string an = System.Text.RegularExpressions.Regex.Replace(authorName.Text, @"[^a-zA-Z0-9_]", "");
                string mn = System.Text.RegularExpressions.Regex.Replace(modName.Text, @"[^a-zA-Z0-9_]", "");
                modID.Text = an + ":" + mn;

It combines the author name and the mod title to the ID.

Should I check if the author name does not exceed 9 characters and that the title does not exceed 22 characters?

[Adrek]

If in package-info.xml is readme 'inline' then it's not converted.

It should be... Can you send me a sample package or a link to the mod you downloaded?

You have PM with URL to test package.

[Arantor]

Should I check if the author name does not exceed 9 characters and that the title does not exceed 22 characters?

9 characters because that's all you need to fit in your own name?

No, you should do what I already suggested. Alphanumeric and _, at least one character in each, total string <= 32 in length.

[NanoSector]

Should I check if the author name does not exceed 9 characters and that the title does not exceed 22 characters?

9 characters because that's all you need to fit in your own name?

Heh, now that you say it...
I didn't even think of that, honestly.

No, you should do what I already suggested. Alphanumeric and _, at least one character in each, total string <= 32 in length.

But what happens when the author name exceeds 32 characters?

Thanks phantomm

[Arantor]

But what happens when the author name exceeds 32 characters?

You misunderstand me.

The *entire string*, user:name has to be 32 or less characters. So validate the whole string is valid then check its entire length.

[NanoSector]

But what happens when the author name exceeds 32 characters?

You misunderstand me.

The *entire string*, user:name has to be 32 or less characters. So validate the whole string is valid then check its entire length.

Yeah, I know, but when the authorname is something along the lines of "thisisaverylongusernamewithalotoftextinit" it will push the : and everything after it off the shelf.

I have the code ready...just that issue. I know it's not something I should be worried about (most names aren't that long) but it may get an issue.

[Arantor]

Yeah, I know, but when the authorname is something along the lines of "thisisaverylongusernamewithalotoftextinit" it will push the : and everything after it off the shelf.

ARGH.

Then it will automatically fail by being too long anyway!

but it may get an issue.

Yes, the issue is that the user is trying to use a string that is too long. The rule is really simple: user + colon + mod name <= 32 characters. The length of the username is irrelevant; mod site doesn't care, package manager doesn't care. It just has to be under 32 characters in total.

[NanoSector]

Code Select Expand

                string an = System.Text.RegularExpressions.Regex.Replace(authorName.Text, @"[^a-zA-Z0-9_]", "");
                string mn = System.Text.RegularExpressions.Regex.Replace(modName.Text, @"[^a-zA-Z0-9_]", "");
                string tmpstr = (an + ":" + mn).Substring(0, 32);
                if (tmpstr.Length > 32)
                    tmpstr = tmpstr.Substring(0, 32);
                modID.Text = tmpstr;

That's what I have now. Works well, though is that what you mean?

[Arantor]

Um... how does no sound?

In PHP, it would be:
$packageid = $authorName . ':' . $modName;
if (preg_match('/[a-z0-9_]+:[a-z0-9_]+/i', $packageid) && strlen($packageid) <= 32)
{
  // do whatever you do with valid ones
}

Don't do this string cropping because you're completely missing the point of it.

[NanoSector]

No sounds good, I love getting one at times

Though when it's automatically generated I'll need to chop off some content, since it's supposed to be automatic. Not sure how I'll tackle the manual editing, since it's not as easy as "Don't allow the change in the textbox".

[Arantor]

Well... when users press the big shiny go button, validate it, if it fails, warn the user and abort the package generation. It's not that hard to do...

[Matthew K.]

That regex would throw out my username then which contains -.

[NanoSector]

Well... when users press the big shiny go button, validate it, if it fails, warn the user and abort the package generation. It's not that hard to do...

There's no go button, it's done in the Editor itself. The ID is not touched when converting a package.

@Labradoodle: If - is valid, I'll add it into the regex. Not sure what more I could add, open for suggestions.

[Arantor]

Stop being literal.

Whatever process that occurs whereupon the id is collated, notify the user and abort the process.