News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

MSN Remover

Started by vbgamer45, January 12, 2013, 10:13:21 PM

Previous topic - Next topic

vbgamer45

Link to Mod

MSN Remover


SMF Version: 2.0.X and 1.1.X
Mod Version: 1.0

Description:
In March Microsoft is removing MSN and merging it into Skype, so with this here is a mod that will remove MSN from your forum files.

This mod does not install Skype and I suggest people look at Additional Instant Messengers by hcfwesker.

Changelog:

v1.0
Initial Release

Thanks
I would like to thank hadesflames and Shawn Gossman for testing and bug fixing this mod.

Why Not Visit:
http://www.smfhacks.com
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Arantor

Where's the like button?

hcfwesker

I was actually fixing to go through the gruelling process of manually removing MSN when the time came, then saw this listed as a new MOD on the mod page.  Very Nice!

Deaks

i did all the work for you lol :D
~~~~
Former SMF Project Manager
Former SMF Customizer

"For as lang as hunner o us is in life, in nae wey
will we thole the Soothron tae owergang us. In truth it isna for glory, or wealth, or
honours that we fecht, but for freedom alane, that nae honest cheil gies up but wi life
itsel."

Deadfire

just a small bug when running it in 2.0.4, seems you have "MemberList.php" instead of "Memberlist.php" otherwise it's awesome :)

Deaks

thanks I will update when I get back :)
~~~~
Former SMF Project Manager
Former SMF Customizer

"For as lang as hunner o us is in life, in nae wey
will we thole the Soothron tae owergang us. In truth it isna for glory, or wealth, or
honours that we fecht, but for freedom alane, that nae honest cheil gies up but wi life
itsel."

Burke ♞ Knight

I found an issue, when uninstalling. You can not just do a remove of code, without a point to have, when uninstalling. I do not know how that got missed, but here's what I'm talking about:

Profile.template.php

<operation>
<search position="replace"><![CDATA[ <td align="center">', $member['msn']['link'], '</td>
]]></search>
<add><![CDATA[]]></add>
</operation>


It tells to remove it, but there's nothing to tell where to re-add it, when uninstalling, which causes it to be added to the top of the file, breaking the page's format, as well as leaving text at the very top.

Now, that also makes it hard for people, as they have NO idea where to manually re-add the code. :P

EDIT:

Apparently, it never actually removes the code, too.

Burke ♞ Knight

<file name="$sourcedir/Memberlist.php">
<operation>
<search position="replace"><![CDATA[),
'msn' => array(
'label' => $txt['msn'],
'width' => '30'
),]]></search>
<add><![CDATA[),]]></add>
</operation>
<operation>
<search position="replace"><![CDATA[ ),
'msn' => array(
'down' => 'LENGTH(mem.msn) > 0 ASC, IFNULL(mem.msn, 1=1) DESC, mem.msn DESC',
'up' => 'LENGTH(mem.msn) > 0 DESC, IFNULL(mem.msn, 1=1) ASC, mem.msn ASC'
),]]></search>
<add><![CDATA[),]]></add>
</operation>
<operation>
<search position="replace"><![CDATA['msn', 'aim',]]></search>
<add><![CDATA['aim',]]></add>
</operation>
</file>


Really?

You know, when uninstalling, how many times ), shows up in that file? 30 times, and you expect SMF and people to know which of those are the correct ones to replace?

vbgamer45

I didn't make the mod originally it was transferred for me will look into it though
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Burke ♞ Knight

Yeah, I was wondering about that. I know you well, and I was shocked to see such issues with one of your mods...

I know you are way better of a coder to have this happen, and was shocked.... LOL

vbgamer45

Yeah I never do such small replacements since I know those cause issues
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

vbgamer45

Update! Made the edits a little more unique for better uninstall
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro


taradxxx


Tyler.Burton

I would just like to verify before I download it, this mod works with 2.0.9 and will only remove the MSN feature from profiles; am I correct?

Deaks

~~~~
Former SMF Project Manager
Former SMF Customizer

"For as lang as hunner o us is in life, in nae wey
will we thole the Soothron tae owergang us. In truth it isna for glory, or wealth, or
honours that we fecht, but for freedom alane, that nae honest cheil gies up but wi life
itsel."

GL700Wing

Just tried to install this mod but it is failing because it cannot find a non-existent file - it's looking for ./Sources/MemberList.php instead of ./Sources/Memberlist.php.
Life doesn't have to be perfect to be wonderful ...

vbgamer45

Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

GL700Wing

#18
Quote from: vbgamer45 on May 26, 2017, 07:58:01 AM
Fixed updated.
Thanks.

Still a minor issue for SMF 2.0.14 in ./Sources/Load.php which now referes to 'https' in place of 'http'

'msn' => $profile['msn'] !='' && (empty($modSettings['guest_hideContacts']) || !$user_info['is_guest']) ? array(
'name' => $profile['msn'],
'href' => 'https://members.msn.com/' . $profile['msn'],
'link' => '<a class="msn new_win" href="https://members.msn.com/' . $profile['msn'] . '" title="' . $txt['msn_title'] . ' - ' . $profile['msn'] . '"><img src="' . $settings['images_url'] . '/msntalk.gif" alt="' . $txt['msn_title'] . ' - ' . $profile['msn'] . '" /></a>',
'link_text' => '<a class="msn new_win" href="https://members.msn.com/' . $profile['msn'] . '" title="' . $txt['msn_title'] . ' - ' . $profile['msn'] . '">' . $profile['msn'] . '</a>'
) : array('name' => '', 'href' => '', 'link' => '', 'link_text' => ''),
'real_posts' => $profile['posts'],
Life doesn't have to be perfect to be wonderful ...

GL700Wing

Also, removing this mod doesn't correctly undo all edits in ./Sources/ManageSettings.php because there are two lines that match the following replacement:
Find:
'icq', 'msn',
Replace with:
'icq',

The result is that the uninstall puts two  'msn',  variables on the first line and none on the second line.

Suggest using the following edits instead:
Find:
// What about standard fields they can tweak?
$standard_fields = array('icq', 'msn',

Replace with:
// What about standard fields they can tweak?
$standard_fields = array('icq',


Find:
{
$standard_fields = array('icq', 'msn',

Replace with:
{
$standard_fields = array('icq',

Life doesn't have to be perfect to be wonderful ...

Advertisement: