• Welcome to Simple Machines Community Forum. Please login or sign up.
October 25, 2021, 04:36:04 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Deleting a theme actually deletes the theme.

Started by kat, June 03, 2013, 03:29:44 PM

Previous topic - Next topic

kat

Ant... some of them don't even know what FTP is... :P

Quote from: Antechinus on June 05, 2013, 01:08:59 AMIt's consistent with the behaviour of the package manager when uninstalling mods. The files stay put in case you want to reinstall later.

Not entirely. In Packages, you get both the option to uninstall and to delete. In themes, you don't.

emanuele

And then you have people complaining because they deleted the packages *before* uninstall the mod and then they cannot uninstall it again and have uploaded an updated version and cannot install the updated version, etc.

Am I wrong?


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Kindred

nope... you are not wrong. :)


the problem with making something idiot proof is that people keep coming up with new ways to be idiots.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

kat


Herman's Mixen

The original design is/was if a user did delete the theme in question the files stayed at the server in case they removed it and wasn't supposed to...

as i believe "Unknown W." had this in mind while he did designed the system :P

Met vriendelijke groet, The Burglar!

 House Mixes | Mixcloud | Any Intelligent fool can make things bigger, more complex, and more violent.
It takes a touch of genius - and a lot of courage - to move in the opposite direction. - Albert Einstein

Former Godfather of our dutch community ;)

kat

OK. If it doesn't delete the files, how about a message, telling us that, as previously described?

Herman's Mixen

That could be a good optional feature

or you could easily open the file /Themes/default/languages/Themes.{language}.php
and change the line of text


$txt['theme_remove_confirm'] = 'Are you sure you want to permanently remove this theme?';


and add some text to inform that the deletion does not removes the files on the server
Met vriendelijke groet, The Burglar!

 House Mixes | Mixcloud | Any Intelligent fool can make things bigger, more complex, and more violent.
It takes a touch of genius - and a lot of courage - to move in the opposite direction. - Albert Einstein

Former Godfather of our dutch community ;)

emanuele

The problem with a warning is that there is no way (at the moment) to distinguish between "new" themes (i.e. never installed yet) and "deleted" themes (i.e. themes installed and removed), they both are the same to SMF.

So you would need a generic warning: "hey you have some themes around, are you sure they should be there?"
I'm not sure that would work perfectly.

Also, SMF is quite flexible when it comes to theme directory (i.e. the directory can be almost anywhere), so to be "sure" a theme is around, we'd need to limit the places SMF can look for themes.


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Antechinus

If an admin can't recall which themes they uninstalled and which themes they haven't installed yet, they have problems other than themes. :D

Burke ♞ Knight

There is also the issue of directory names. :P

kat

So, as I mentioned, a warning wotsit, saying ...

Quote from: K@ on June 04, 2013, 02:04:10 PMthat the files won't be deleted and will have to be deleted manually?

Surely, that's easy enough to instigate, innit?

Illori

how about something like this? although most may never see it


kat

Apart from a full-stop/period between "server" and "that", that would be pretty damned perfect. :)

Although, a warning, when you click to delete a theme, would be even more bettererer, I reckon.

I actually know that a number of members don't, actually, know that you need to hit the to delete a theme, you know...

Illori

then the docs need to be updated to include information about that.

other then a language string update, the rest would need a dev to look into.

kat

Will you do that? Or, shall I?

Yeah, I know the devs would need to look at this. Although I only intended it for the next version, an update for the current version would be good.

Unlikely to happen, though, I'd guess...

Illori

you can check the docs and start a thread in the proper board if you see it necessary.

kat

The docs are there, already, which is groovy.

http://wiki.simplemachines.org/smf/Themes_and_Layout

QuoteThe Themes Settings section of the Administration Center shows a list of all Themes currently installed on the forum. Clicking on any Theme's name will take you to that Theme Settings, exactly like Current Theme settings. If you want to remove a Theme from your forum, then click on the red X. Doing so will only delete that Theme reference from your Forum settings. The actual Theme contents will be left in your Themes directory. To physically remove the theme from there, you need to do so using FTP or your CPanel's File Manager.

Illori

looks good, as long as the x stays red and the user is not color blind.

kat

Maybe we could change that, to point to the image?

So that it says:

QuoteThe Themes Settings section of the Administration Center shows a list of all Themes currently installed on the forum. Clicking on any Theme's name will take you to that Theme Settings, exactly like Current Theme settings. If you want to remove a Theme from your forum, then click on the icon to the right of the theme's name. Doing so will only delete that Theme reference from your Forum settings. The actual Theme contents will be left in your Themes directory. To physically remove the theme from there, you need to do so using FTP or your CPanel's File Manager.

Advertisement: