Adding onClick to main button array

[Sir Osis of Liver]

Tinkering with this, and curious if it's possible to do something similar in the main menu button array in Subs.php.  Tried adding this to the array -

Koodi [Valitse] Laajenna



     'custom' => 'onclick="return confirm(\'Are you sure?\');"',



but it's ignored.

[Arantor]

There is a way you can do it but you're not supposed to do it, really

If you adjust the target to be

Koodi [Valitse] Laajenna

'target' => 'http://example.com" onclick="return confirm(\'Are you sure?\');',

it should work. The surrounding " will be added normally to start the link and end the onclick.

[Sir Osis of Liver]

Tried this -

Koodi [Valitse] Laajenna



'target' => 'http://www.simplemachines.org" onclick="return confirm(\'Are you sure?\');',



Shows the confirm box, but opens new blank window when click 'OK'.

And why does it require a single quote before the url, and double quote after?

[Sir Osis of Liver]

Ok, it was missing a double quote at the end, now it opens the page in a new window, should be _self.

Koodi [Valitse] Laajenna



'target' => $scripturl . '?action=help" onclick="return confirm(\'Are you sure?\');"',



[Arantor]

 Bah, it's not *target*, it's the normal href attribute (target is for something else unrelated)

As for the mismatch of quotes, I did actually explain that. But I guess I can be more thorough.

When it's output, it's output as an <a href="{href goes here}"> link. You already have the surrounding ", what this is doing is exiting the " for the href, and starting a new one.

So: <a href="{href goes here}"> becomes:

<a href="http://example.com/" onclick="return confirm('Are you sure?');"> because of the quote handling.

And no, it wasn't missing a double quote.

[Sir Osis of Liver]

I'll try that.  Meanwhile, this works -

Koodi [Valitse] Laajenna



'help' => array(
'title' => $txt['help'],
'href' => $scripturl . '?action=help',
'target' => '_self" onclick="return confirm(\'Are you sure?\');"',
'show' => true,
'sub_buttons' => array(
),
),



Looks like it shouldn't, but .

[Arantor]

Except it adds an extra " into your code that shouldn't be there. Look at the result source, you should find you have an extra " in there (for the very reason I outlined)

[Sir Osis of Liver]

Works either way, so I took out the '' on the end.

Koodi [Valitse] Laajenna



'target' => '_self" onclick="return confirm(\'Are you sure?\');',



How to you put it in the 'href' field?

[Arantor]

Same way you do anything else...

Koodi [Valitse] Laajenna

'href' => $scripturl . '?action=help" onclick="return confirm(\'Are you sure?\');',

[Sir Osis of Liver]

Ok, much cleaner. Had tried that, but didn't get the quotes right.

Thx.