@mention members

Started by Dragooon, May 02, 2014, 01:07:58 PM

Previous topic - Next topic

Parenting-Furkids

I installed this mod with no issues or warnings that there were any problems.  Long story short... decided to uninstall mod.  No issues with the actual uninstall. 
However, members kept getting fatal errors.  It looks like pieces of the mod were left behind when the mod was uninstalled.
I didn't want to mess with file pieces, code, etc. so I restored my forum to a previous working back-up.  That didn't fix the fatal errors. 
I have been removing the line of code that is mentioned in the fatal error messages.  Is that a good thing to do, or am I only asking for trouble? 

JerzyLS

QuoteIs that a good thing to do, or am I only asking for trouble?

Let's paste here the error log and file.

br360

You should be removing any bit of code left behind from the mod- but you should make sure you remove all of it from any files that were edited because of the mod.

To make sure you are removing all code, go to the page where you would download it, and then look for "Manual Install Instructions for SMF"

Find your version in the drop down list and then press the parse button. Then just reverse everything you see in the instructions (the parse shows how to manually install, and you are doing the opposite)

Make sure to back up first just in case you accidentally remove more code than you should in any of the files

Oceander

This is a very handy mod.  Thank you so much to the developer.

Not to be a whinger, but I would just say that it would be handy to be able to delete old mentions.  The usefulness is largely a one or two shot deal - which is huge, btw, so please don't take as a criticism - and I'm just a little worried my database may quickly fill up and start dragging since I know many of the members in the forum I manage are heavy @mention users.

SychO

members getting fake mentions (inexistant, never actually mentioned)

Does anyone know how I can stop that from happening ?

Thanks.
Checkout My Themes:
-

Potato  •  Ackerman  •  SunRise  •  NightBreeze

Parenting-Furkids

Quote from: br360 on August 26, 2016, 01:45:42 PM
You should be removing any bit of code left behind from the mod- but you should make sure you remove all of it from any files that were edited because of the mod.

To make sure you are removing all code, go to the page where you would download it, and then look for "Manual Install Instructions for SMF"

Find your version in the drop down list and then press the parse button. Then just reverse everything you see in the instructions (the parse shows how to manually install, and you are doing the opposite)

Make sure to back up first just in case you accidentally remove more code than you should in any of the files

Thanks!



coltp45

Hi, recently I installed the theme Exodus for smf 2.0.11 and installed mentions ok.  But when a user mention another no show the mention in the menu.



I need that the mention shows in the new perfil menu  mark with the red square.  Is posible do that?

Kindred

If you install a new theme after installing mods, then you need to manually update that theme with any mod edits
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

coltp45



Quote from: Kindred on September 10, 2016, 07:59:27 PM
If you install a new theme after installing mods, then you need to manually update that theme with any mod edits

First I install the theme and then the mod.  Install ok but I don't now what file need to be change in the new theme to show that you have mentions.



coltp45

Can't edit my post sorry.





lahmfan

Quote from: ExSpirit on May 29, 2014, 09:13:49 AM
When someone does the mention in topic every time someone opens that topis I get strange error in my error log files:

QuoteUndefined index: online
File: /usr/home/public_html/Themes/default/languages/Mentions.english.php (main sub template - eval?)
Line: 275

In my Display.template.php I am using $message['member']['online']['is_online'] to check is user is online or not and that works, but I don't know why this error is shown.
have you gotten a response to this?

d3vcho

The solution might be to disable template evals (Admin > Configuration > Server Settings > General > Disable evaluation of templates) as its doesn't exactly tells you where the errors are.

Regards :)
"Greeting Death as an old friend, they departed this life as equals"

lahmfan

Quote from: d3vcho on October 25, 2016, 02:32:06 PM
The solution might be to disable template evals (Admin > Configuration > Server Settings > General > Disable evaluation of templates) as its doesn't exactly tells you where the errors are.

Regards :)
i love you, thank you!

Kindred

probably because $message is not a valid array in whatever file is calling it.
What works in Display.template.php will probably NOT work in any other file - almost definitely NOT in a language file
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

James Gryphon

After creating a new SMF 2.0.12 forum some time ago, I installed the mod and applied the hack I previously described here to get the Mentions button in the menu bar.

I just noticed not too long ago, though, that the Mentions button doesn't light up when you're at that page; instead, the Profile button does. It seemed like I was able to fix this on a SMF 2.0.11 forum some time ago, but I don't remember what I did, or if anything's changed in .12 that would mess my fix up.

I wondered if it had to do with "Mentions" being an 'area' that's listed under the Profile action, and if creating a new action would help, but I don't have the foggiest where to start doing that, if that is the trouble.

I've burned a few hours at this and haven't gotten anywhere, so I figured that it was worth asking about it here. Thanks in advance for any help y'all can provide.

GL700Wing

Quote from: James Gryphon on October 26, 2016, 05:27:48 PM
After creating a new SMF 2.0.12 forum some time ago, I installed the mod and applied the hack I previously described here to get the Mentions button in the menu bar.

I just noticed not too long ago, though, that the Mentions button doesn't light up when you're at that page; instead, the Profile button does. It seemed like I was able to fix this on a SMF 2.0.11 forum some time ago, but I don't remember what I did, or if anything's changed in .12 that would mess my fix up.

I wondered if it had to do with "Mentions" being an 'area' that's listed under the Profile action, and if creating a new action would help, but I don't have the foggiest where to start doing that, if that is the trouble.

I've burned a few hours at this and haven't gotten anywhere, so I figured that it was worth asking about it here. Thanks in advance for any help y'all can provide.

I had the same problem and it occurs because the Mentions mod installs a line of code too high up in an array in both Sources/Admin.php and Sources/ManageSettings.php.

Search for the word mentions in Sources/Admin.php and move the 'mentions' line to after the 'general' line as follows:
                        'general' => array($txt['mods_cat_modifications_misc']),
                        'mentions' => array($txt['mentions']),


Search for the word mentions in Sources/ManageSettings.php and move the 'mentions' line to after the 'general' line as follows:
        'general' => 'ModifyGeneralModSettings',
        'mentions' => 'ModifyMentionsSettings',
Life doesn't have to be perfect to be wonderful ...

James Gryphon

I'm sorry to be a hassle, friend, but I checked those files and it looks like both of those files are already good. :-\ That being the case, I'm at a loss what could be off. It seems like this whole process is rather finicky.

GL700Wing

Quote from: James Gryphon on October 29, 2016, 05:17:27 AM
I'm sorry to be a hassle, friend, but I checked those files and it looks like both of those files are already good. :-\ That being the case, I'm at a loss what could be off. It seems like this whole process is rather finicky.
I misunderstood your problem initially but I think I may have found the solution!

In Sources/Subs.php search for
    if (isset($context['menu_buttons'][$context['current_action']]))
        $current_action = $context['current_action'];


and replace it with:
    if (!empty($_GET['action']) && !empty($_GET['area']) && $_GET['action'] == 'profile' && $_GET['area'] == 'mentions')
        $current_action = 'mentions';
    elseif (isset($context['menu_buttons'][$context['current_action']]))
        $current_action = $context['current_action'];

Life doesn't have to be perfect to be wonderful ...

James Gryphon

It works beautifully! Thanks so much for the tweak. :)

GL700Wing

Glad to be of assistance although I've just realised the following solution is much better (it puts the custom code after the if/elseif block) as it doesn't involve changing any existing lines of code which may cause issues for subsequent upgrades/mods ...

In Sources/Subs.php search for
    $current_action = 'moderate';

    $context['menu_buttons'][$current_action]['active_button'] = true;


and replace it with:
    $current_action = 'moderate';

    if (!empty($_GET['action']) && !empty($_GET['area']) && $_GET['action'] == 'profile' && $_GET['area'] == 'mentions')
        $current_action = 'mentions';

    $context['menu_buttons'][$current_action]['active_button'] = true;
Life doesn't have to be perfect to be wonderful ...

Advertisement: