Location repeated twice in profile view and missing country

[Ninja ZX-10RR]

Hi everyone I have a problem with my profile view window, as you can see from the attachment it shows the location twice and ignoring the country completely.
I would like the country to be shown and of course one of the 2 location tabs to go away. Also is it possible to change the order of those tabs? Like having the country before the exact location?
If I need to attach any files tell me and I will.
Thanks in advance.

[mashby]

How about attaching Themes/default/Profile.template.php?

You could look in there as well. Looks like you have duplicate lines, eh?

[Ninja ZX-10RR]

Of course when I installed some profile mods I was still very much a noob and I screwed up something 100% xD

I think I found that the problem is around strings 190-200 but i still don't know how to add the country correctly >.<

And as always thank you for your reply mashby

[mashby]

Lines 199 through 202 were the duplicates, depending on where you wanted to see Location, I've removed those in the attached. Is that betterer? Wondering if this guy did something funny on installation?
Next Post Level Mod
Maybe not though.

[Ninja ZX-10RR]

Cool I would have done the same but asking doesn't hurt

First problem completely fixed, now up to the second one... How can I add the country to be shown in the summary view above the location tab?

[mashby]

Is that the result of a Mod or a custom profile field?

[Ninja ZX-10RR]

Yes it's from "Country flags" mod, I was just updating it but nothing changed actually.
And well it's not pretty much active as a mod support topic... So lol if you actually know how to do that please tell me so I can do it and you could add it yourself to that topic as a new feature. Many people asked how to do this and that but the only answer has been "you need to edit this" but without providing any other informations about it...

[mashby]

If you go to the page where you downloaded the mod from, there's a nice Parse option. That shows you all of the edits that would be made upon successful installation. Download your site files and have a look file by file. Also, if the edits weren't made when you installed the mod, notifications on what wasn't edited should have occurred. Do you remember that happening? And where is the Country Flags mod not working?

[Ninja ZX-10RR]

It was all successfull when I installed it, it's just not a default function of the mod AFAIK... But I think that's stupid. Why would I want to add a country field if nobody could see it in the profile view? =_=
IMHO it should be working in the profile summary as that page is the one everybody can see when clicking on an user's profile. It already works in posts so...

[mashby]

Have you, umm, enabled it?!?

[Ninja ZX-10RR]

I might be dumb for being too tired sometimes but now it's 6 p.m. so yes I did it I enabled it on the profile view from admin, miscellaneous, etc...
It works perfectly except for that annoying detail

[mashby]

The code from the mod is in the file you attached (and I subsequently edited). The mod was last updated June 18th so the support topic should be the place to ask.

[Lou69]

It was all successfull when I installed it, it's just not a default function of the mod AFAIK... But I think that's stupid. Why would I want to add a country field if nobody could see it in the profile view? =_=
IMHO it should be working in the profile summary as that page is the one everybody can see when clicking on an user's profile. It already works in posts so...

If you are talking about the Country Flags from SMFHacks then they clearly state that the flag is shown on the members post. You can ask in their support page for assistance in placing the flag on the profile.

http://www.simplemachines.org/community/index.php?topic=106060.0

[Ninja ZX-10RR]

I'll try but I highly doubt I would be given an answer. Similar problems have been answered with "you need to edit X file" without any details and as I'm not a coder I wouldn't be able to do it lol
I'll try anyway but I can't really mark this as solved as it's not. If I can manage to do this I will be posting the necessary file edits to get it working and mark as solved after that.
Thanks for your help I appreciate it very much

EDIT

It was all successfull when I installed it, it's just not a default function of the mod AFAIK... But I think that's stupid. Why would I want to add a country field if nobody could see it in the profile view? =_=
IMHO it should be working in the profile summary as that page is the one everybody can see when clicking on an user's profile. It already works in posts so...

If you are talking about the Country Flags from SMFHacks then they clearly state that the flag is shown on the members post. You can ask in their support page for assistance in placing the flag on the profile.

http://www.simplemachines.org/community/index.php?topic=106060.0

Of course I am talking about that, if you read the whole post you can find many sentences clearly pointing to it.

Yes it's from "Country flags" mod, I was just updating it but nothing changed actually.

Thanks for your reply, anyway.

[mashby]

Aha, yeah, now that I see what the mod is doing, the Modify Profile function is what's visible, but not the results of that in the summary view. Wondering what this would do? I don't have the mod installed so I'm doing an educated edit. If it fails, the attachment above is your failsafe (backup).

[Lou69]

I'll try but I highly doubt I would be given an answer. Similar problems have been answered with "you need to edit X file" without any details and as I'm not a coder I wouldn't be able to do it lol
I'll try anyway but I can't really mark this as solved as it's not. If I can manage to do this I will be posting the necessary file edits to get it working and mark as solved after that.
Thanks for your help I appreciate it very much

EDIT

It was all successfull when I installed it, it's just not a default function of the mod AFAIK... But I think that's stupid. Why would I want to add a country field if nobody could see it in the profile view? =_=
IMHO it should be working in the profile summary as that page is the one everybody can see when clicking on an user's profile. It already works in posts so...

If you are talking about the Country Flags from SMFHacks then they clearly state that the flag is shown on the members post. You can ask in their support page for assistance in placing the flag on the profile.

http://www.simplemachines.org/community/index.php?topic=106060.0

Of course I am talking about that, if you read the whole post you can find many sentences clearly pointing to it.

Yes it's from "Country flags" mod, I was just updating it but nothing changed actually.

Thanks for your reply, anyway.

I did read the entire thead and I did not find 'many sentences' refering to the mod. There are two country mods that are found when searching by 'country flags'. You failed to add a link or the mod authors name. I am not a mind reader. You also failed to understand that the mod only adds the flag to the posters post profile. The design is not 'stupid' as you implied; the design is working as intended by the author.

[Ninja ZX-10RR]

Thank you again...
Hmm... LOL nothing has changed XD only the file size from what I can see... No errors in the error log and all profile views look exactly the same... 

@Lou69 It was clearly stated "Country Flags", nothing else. And if you search it (http://custom.simplemachines.org/mods/index.php?action=search;basic_search=Country+flags) you can find 2 mods, the aforementioned one and also another one called "Country Flags Avatars" (http://custom.simplemachines.org/mods/index.php?mod=644) that has nothing to deal with me for 2 reasons: the first is that I never mentioned it and I clearly said "Country Flags" (http://custom.simplemachines.org/mods/index.php?mod=417) and the second reason is that the latter mod works only in SMF 1 and this is SMF 2.0.x support

[mashby]

And I'm just being nice in helping you here and possibly should have just suggested asking in the support topic for the mod. Is it possible to get a URL where you have just updated that file? Or maybe you haven't? I added this bit:

Code Select Expand

// Show the country they hail from!
if (isset($message['member']['country_flag']) && !empty($modSettings['country_flag_show']) && !empty($message['member']['country_flag']))
{
$flags = CountryFlag();
echo '
<dt>', $txt['country_flag'], ':</dt>
<dd><img src="', $settings['images_url'], '/flags/', $message['member']['country_flag'], '.png" alt="', $message['member']['country_flag'], '" title="', $flags[$message['member']['country_flag']], '" /></dd>';
}


[Bob Perry of Web Presence Consulting]

As it was not originally designed to display on the profile, what the coder has to do is determine the snippet(s) of code the original mod uses to execute it displaying on the post and do the same thing to the profile, sometimes you get lucky & can just copy and paste in the appropriate file/location... but more often its just a little more complicated than that and often requires editing multiple files, its always going to be faster to contact the author in that case, good module authors relish this kind of interaction

[Ninja ZX-10RR]

I'll take a look at this after dinner thank you meantime

[Ninja ZX-10RR]

And I'm just being nice in helping you here and possibly should have just suggested asking in the support topic for the mod. Is it possible to get a URL where you have just updated that file? Or maybe you haven't? I added this bit:

Code Select Expand

// Show the country they hail from!
if (isset($message['member']['country_flag']) && !empty($modSettings['country_flag_show']) && !empty($message['member']['country_flag']))
{
$flags = CountryFlag();
echo '
<dt>', $txt['country_flag'], ':</dt>
<dd><img src="', $settings['images_url'], '/flags/', $message['member']['country_flag'], '.png" alt="', $message['member']['country_flag'], '" title="', $flags[$message['member']['country_flag']], '" /></dd>';
}


Yeah I know you are being very nice to help you in this way even if you weren't supposed to that's another reason why I have been saying thank you all the time (and thank you again!)
By the way what do you mean with the URL? I have updated it in my FTP ofc but I can't provide the URL both for security reasons and also because it would be telling you "Hacking attempt" when you try to open it not from FTP.

As it was not originally designed to display on the profile, what the coder has to do is determine the snippet(s) of code the original mod uses to execute it displaying on the post and do the same thing to the profile, sometimes you get lucky & can just copy and paste in the appropriate file/location... but more often its just a little more complicated than that and often requires editing multiple files, its always going to be faster to contact the author in that case, good module authors relish this kind of interaction

This has already been suggested and I have already done this.

[mashby]

OK. If you are protecting the URL of your site, that's fine. Not sure why you are, but I also don't really need to know why. Just means you'll be the only one seeing the effects of these edits. You should at least see the label or errors in the log if I forgot something.

[Ninja ZX-10RR]

We probably misunderstood in some ways...
I believe that any human being has encrypted files otherwise if anyone discovers the correct path he would be able to edit the files themselves and make a mess...
No errors in the logs actually it just looks exactly the same, that's why my face was like this --> 
If you need it I can PM you the details of my db access but I can't see any reason for it atm xD

[mashby]

I really am not asking for any kind of access to your site other than the publicly available URL to it. Nothing FTP, nothing database, just your forum URL.

[Ninja ZX-10RR]

LOL mate clicking on my website below my custom text would have been easier
http://vige.altervista.org/forum/index.php

[Ninja ZX-10RR]

Any updates on this if you had enough time?

[mashby]

Considering this is down to the CountryFlags mod and whatever I tried to do didn't work, your best bet is in the support topic for the mod.

[Ninja ZX-10RR]

Yeah I hope they will answer... http://www.simplemachines.org/community/index.php?topic=106060.msg3713825#msg3713825 thank you anyway meantime. You have done even more than you were "supposed" to

[Eathuis]

I've had this problem before...strangely enough the cause was that the code duplicated in "Display.template.php"

[Ninja ZX-10RR]

Lol? Not in profile.template.php then?

[Bob Perry of Web Presence Consulting]

Lol? Not in profile.template.php then?

no, the mod does not insert any code for displaying the flag in Profile.template.php

[Ninja ZX-10RR]

Lol for sure it does read the whole topic
You can also see the edits it does from here --> http://custom.simplemachines.org/mods/index.php?action=parse

[Bob Perry of Web Presence Consulting]

And I'm just being nice in helping you here and possibly should have just suggested asking in the support topic for the mod. Is it possible to get a URL where you have just updated that file? Or maybe you haven't? I added this bit:

Code Select Expand

// Show the country they hail from!
if (isset($message['member']['country_flag']) && !empty($modSettings['country_flag_show']))
{
$flags = CountryFlag();
echo '
<dt>', $txt['country_flag'], ':</dt>
<dd><img src="', $settings['images_url'], '/flags/', $message['member']['country_flag'], '.png" alt="', $message['member']['country_flag'], '" title="', $flags[$message['member']['country_flag']], '" /></dd>';
}


Try this (edited the quoted code), I removed a small snippet on the conditional statement, remember, that snippet CAME from the other file, you don't need that last condition here...

[Bob Perry of Web Presence Consulting]

And I'm just being nice in helping you here and possibly should have just suggested asking in the support topic for the mod. Is it possible to get a URL where you have just updated that file? Or maybe you haven't? I added this bit:

Code Select Expand

// Show the country they hail from!
if (isset(!empty($modSettings['country_flag_show']))
{
$flags = CountryFlag();
echo '
<dt>', $txt['country_flag'], ':</dt>
<dd><img src="', $settings['images_url'], '/flags/', $message['member']['country_flag'], '.png" alt="', $message['member']['country_flag'], '" title="', $flags[$message['member']['country_flag']], '" /></dd>';
}


Try this (edited the quoted code), I removed a small snippet on the conditional statement, remember, that snippet CAME from the other file, you don't need that last condition here...

oops, hang on gotta check something else, be back in a few minutes, still not right
....

there, how about that?

[Bob Perry of Web Presence Consulting]

hmm, may give strange results if the user hasn't defined a country yet, stand by gonna have get the mod and look now, sheesh

[Ninja ZX-10RR]

Eh? Uh? Ah ok xD I was like what the...  lol update me then

[Bob Perry of Web Presence Consulting]

Lol for sure it does read the whole topic
You can also see the edits it does from here --> http://custom.simplemachines.org/mods/index.php?action=parse

I beg to differ sir, I've followed this thread quite evenly since you posted the Profile.template.php originally, that first post has no reference to "country" anything, which tells me that the country flags mod does NOT insert any code into it by default, and the link you have there leads nowhere but the parser... hang on a min, bear with me as there is another reference to the $message variable in there that must be corrected before this will work, but it will work trust me

[Burke ♞ Knight]

7.    Execute Modification    ./Themes/default/Profile.template.php    Test successful
      1.    Replace    ./Themes/default/Profile.template.php    Test successful

Code (Find) Select Expand

// Always fun - select boxes!
elseif ($field['type'] == 'select')
{
echo '
<select name="', $key, '" id="', $key, '">';

if (isset($field['options']))
{
// Is this some code to generate the options?
if (!is_array($field['options']))
$field['options'] = eval($field['options']);
// Assuming we now have some!
if (is_array($field['options']))
foreach ($field['options'] as $value => $name)
echo '
<option value="', $value, '" ', $value == $field['value'] ? 'selected="selected"' : '', '>', $name, '</option>';
}

echo '
</select>';
}

Code (Replace With) Select Expand

         // Always fun - select boxes!
         elseif ($field['type'] == 'select')
         {
            if ($key == 'country_flag')
            {
               echo '
                        <script type="text/javascript" language="JavaScript">
                           function show_country_flags()
                           {
                              document.images.flags.src = document.forms.creator.country_flag.options[document.forms.creator.country_flag.selectedIndex].value != \'\' ? \'' . $settings['images_url'] . '/flags/\' + document.forms.creator.country_flag.options[document.forms.creator.country_flag.selectedIndex].value + \'.png\' : \'' . $settings['images_url'] . '/flags/blank.gif\';
                           }
                        </script>
                        <select name="', $key, '" id="', $key, '" onchange="show_country_flags()">';
                       
                     foreach ($field['options'] as $value => $name)
                        echo '
                           <option value="', $value, '" ', isset($context['member']['country_flag']) &&  $context['member']['country_flag'] == $value ? 'selected="selected"' : '', '>', $name, '</option>';
                     
                     echo '
                        </select>
                        <img id="flags" src="', $settings['images_url'], '/', isset($context['member']['country_flag']) && !empty($context['member']['country_flag']) ? 'flags/' . $context['member']['country_flag'] . '.png': 'blank.gif', '" width="25" height="15" alt="" align="top" />';   
            }
            else
            {
               echo '
                     <select name="', $key, '" id="', $key, '">';

            if (isset($field['options']))
            {
               // Is this some code to generate the options?
               if (!is_array($field['options']))
                  $field['options'] = eval($field['options']);
               // Assuming we now have some!
               if (is_array($field['options']))
                  foreach ($field['options'] as $value => $name)
                     echo '
                        <option value="', $value, '" ', $value == $field['value'] ? 'selected="selected"' : '', '>', $name, '</option>';
            }

            echo '
                     </select>';
         }
         }


So, YES, it DOES have edits to Profile.template.php by default.

[Bob Perry of Web Presence Consulting]

And I'm just being nice in helping you here and possibly should have just suggested asking in the support topic for the mod. Is it possible to get a URL where you have just updated that file? Or maybe you haven't? I added this bit:

Code Select Expand

// Show the country they hail from!
if (isset(!empty($modSettings['country_flag_show']))
{
$flags = CountryFlag();
echo '
<dt>', $txt['country_flag'], ':</dt>
<dd><img src="', $settings['images_url'], '/flags/', $context['member']['country_flag'], '.png" alt="', $context['member']['country_flag'], '" title="', $flags[$context['member']['country_flag']], '" /></dd>';
}


see if this doesn't do the trick...

[Bob Perry of Web Presence Consulting]

7.    Execute Modification    ./Themes/default/Profile.template.php    Test successful
      1.    Replace    ./Themes/default/Profile.template.php    Test successful

So, YES, it DOES have edits to Profile.template.php by default.

Thanks for setting me straight on that point but it matters not in this case, that code doesn't reside in the one he posted originally, so maybe if he downloaded latest copy, uninstall, reinstall it will resolve his issue? Does the original mod default to display on profile summary?

[Burke ♞ Knight]

I have it set on mine, but for some odd reason, it is not showing in profile, too.
I'll have to look into it later, as I may be using a theme it did not install into.


EDIT:

Okay, the edits to the profile template, seem to be for when modifying the forum profile.
That means, it is only visible in profile, when selecting it in the odify forum profile page, and not in the summary page.

Hence the: // Always fun - select boxes!

[Ninja ZX-10RR]

Lol thanks for pointing him to the edits xD
And well the problem is actually still here, I know it does show up elsewhere but not in the summary >.<

[Bob Perry of Web Presence Consulting]

Have you tried the snippet i gave you yet? as long as you have your current copy of the template in a safe place it won't hurt a thing to change the snippet of code Mashby did for you to my edited version and reupload, if it doesn't work just put the other one back, simple...

But if it doesn't work, before you change it back let me look at it on your site first, syntax errors slip even for experienced guesses lol

[Ninja ZX-10RR]

Atm I don't have time to try it. Later during the day but I could be absent. In case I don't reply just wait one more day
And ofc thank you

[mashby]

It sure does affect Profile, but only in the sense that the users define their country there. It doesn't display it on the Summary. Great example of why support topics here should really be about default SMF functionality. I apologize for trying to help.

[Bob Perry of Web Presence Consulting]

It sure does affect Profile, but only in the sense that the users define their country there. It doesn't display it on the Summary. Great example of why support topics here should really be about default SMF functionality. I apologize for trying to help.

Agreed, but the hack should be fairly simple, I'm wondering if the admin here could merge this thread into the mod support thread? never tried a whole thread before myself?

[Ninja ZX-10RR]

It sure does affect Profile, but only in the sense that the users define their country there. It doesn't display it on the Summary. Great example of why support topics here should really be about default SMF functionality. I apologize for trying to help.

Actually I appreciated your help so you don't need to apologize at all for being even more kind than you were somehow "supposed" to be

Agreed, but the hack should be fairly simple, I'm wondering if the admin here could merge this thread into the mod support thread? never tried a whole thread before myself?

It *should* but yet the mod author didn't reply

[Bob Perry of Web Presence Consulting]

It sure does affect Profile, but only in the sense that the users define their country there. It doesn't display it on the Summary. Great example of why support topics here should really be about default SMF functionality. I apologize for trying to help.

Actually I appreciated your help so you don't need to apologize at all for being even more kind than you were somehow "supposed" to be

Agreed, but the hack should be fairly simple, I'm wondering if the admin here could merge this thread into the mod support thread? never tried a whole thread before myself?

It *should* but yet the mod author didn't reply

You do realize that he has a plethora of modules and is a very busy man with supporting them, hence he's stretched pretty thin timewise?... as we all are.

With simple things such as this, its always best to move into the appropriate thread, give the moderators time to catch up too...

[Ninja ZX-10RR]

It's not necessarily the case to split the topic as it's totally On Topic and I think mashby would have done that if it was necessary just wait a bit about this (check my sig)

[Illori]

most of the time we dont merge threads with the support thread for mods. it is best to post the question to the support thread again.

[Ninja ZX-10RR]

most of the time we dont merge threads with the support thread for mods. it is best to post the question to the support thread again.

You didn't check the topic before replying, otherwise you would have seen this --> http://www.simplemachines.org/community/index.php?topic=106060.msg3713825#msg3713825
That was on 28/6 and I don't think it's likely to receive an answer there... And Perry sorry for being so late but a whole mess happened today in my private life, I have been to Police for a lot of hours so I will apologize again and try your code tomorrow.

[Illori]

Agreed, but the hack should be fairly simple, I'm wondering if the admin here could merge this thread into the mod support thread? never tried a whole thread before myself?

actually i was replying to bob, who asked us to merge this with the support thread.

[Ninja ZX-10RR]

it is best to post the question to the support thread again.

I was talking about this lol

[Bob Perry of Web Presence Consulting]

Agreed, but the hack should be fairly simple, I'm wondering if the admin here could merge this thread into the mod support thread? never tried a whole thread before myself?

actually i was replying to bob, who asked us to merge this with the support thread.

cool with me, can that even be done with a multi-thread?

[Bob Perry of Web Presence Consulting]

Hey when you go tomorrow and try this, I would get the latest version of mod and re-install first, because that first Profile.template.php you uploaded has no reference to country mod anywhere in it and its suppose to have some...

[Ninja ZX-10RR]

Oh LOL ok, now I'm just trying to relax a bit, too many cops all day and I'm not a cops-fan actually and neither my gf that was with me xD so damn messy I am like shaking right now I might go totally crazy, once more but ok I'll try tomorrow or.. Well later as it's 0:49 a.m. 02/07 local time so later, not tomorrow anymore I'll remove the last line from my siggy.

[Illori]

even if you dont get a reply in the support thread that is no excuse to double post and post in the support board for a reply.

[Ninja ZX-10RR]

This is not a double post I started the topic faraway earlier than posting in that mod support topic as I already knew (looking at the previous replies being made there) that almost for sure I wouldn't have received an answer there. And also the first topic was about a bug I used to have, not only that Country flags stuff.
EDIT: can we get back on topic anyway? I don't want to be told I am going off-topic... I just need one day to test what Bob suggested that's it

[Ninja ZX-10RR]

Sorry for the late reply.
Tried but didn't work I got this:

Parse error: syntax error, unexpected '!' in /membri/vige/forum/Themes/default/Profile.template.php on line 195

And please don't quote again that code it took me like 5 minutes to figure out which one I was supposed to pick xD