Advertisement:

Author Topic: Better Profile Menu (SMF 2.0.x Only)  (Read 36006 times)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,608
    • StoryBB/StoryBB on GitHub
Re: Better Profile Menu
« Reply #20 on: August 02, 2014, 08:11:03 PM »
Manual (un)installation is never fun. Neither, FWIW, is building a large mod because of all the repackaging.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline ahrasis

  • SMF Hero
  • ******
  • Posts: 4,916
  • Gender: Male
  • Busy mode is on.
    • ahmad.rasyid.ismail on Facebook
    • ahrasis on GitHub
    • ahrasis on LinkedIn
    • @ahrasis on Twitter
    • ElkArte Malaysia
Re: Better Profile Menu
« Reply #21 on: August 03, 2014, 03:50:31 AM »
To uninstall, follow the installation sequence but do it backward. That way you won't get errors.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Better Profile Menu
« Reply #22 on: August 03, 2014, 09:01:42 AM »
Just looked at WYSIWYG Quick Reply v2 and I don't see how my mod has any relation to the errors you reported.....

So I started over with a completely clean install and installed ONLY that mod on the test forum.  I found those errors as well.  So it's not my mod doing them....  You probably wanna report them in the correct thread....  O:)  Hope this helps.... 

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Better Profile Menu
« Reply #23 on: August 03, 2014, 09:17:40 AM »
Now I'm confused. You put only the wysiwyg mod and your mod on a test forum and got the errors. I don't see how that eliminates your mod as the one causing the errors. It just seems like a conflict between the two ... I have the wysiwyg mod with 41 other mods on my board and there are no problems. Putting yours on causes the errors.

I'm not trying to cast blame on who's right or who's wrong, I'm just trying to understand what you are saying. I use Firefox with a number of addons so I fully understand that there are going to be times when mods just won't work together and to me, this seems to be one of those times.

Sooo ... as the wysiwyg get was last updated 3 years ago, it seems to me that any newer mod that doesn't work with it should be designed to OR it should be noted what happens if a person has the other mod installed.

I can live with the errors if I want to, it's not a big deal. :)
Online Manual

Please do not PM me for support.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,608
    • StoryBB/StoryBB on GitHub
Re: Better Profile Menu
« Reply #24 on: August 03, 2014, 09:19:55 AM »
Sure it does. If (SMF + mod + this mod) generates errors and (SMF + mod - this mod) also generates the errors, this mod is likely not the cause.

Mind you, the profile code is a labyrinthine mess.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Better Profile Menu
« Reply #25 on: August 03, 2014, 09:26:49 AM »
this mod is likely not the cause

Most of the time, you're right. But if a mod is written so that it doesn't work seamlessly with another established mod, which is at fault?
Online Manual

Please do not PM me for support.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,608
    • StoryBB/StoryBB on GitHub
Re: Better Profile Menu
« Reply #26 on: August 03, 2014, 09:31:49 AM »
It's never a simple answer. Sometimes it's one, sometimes it's another. Most mods are written in a vacuum and thus don't care about anything outside their realm.

In this case it's absolutely the other mod's bug. Since if you look at its parsing instructions, it declares multiple options:

Code: [Select]
0 => $txt['wysiwyg_quick_reply0'],
1 => $txt['wysiwyg_quick_reply1'],
2 => $txt['wysiwyg_quick_reply2'],
3 => $txt['wysiwyg_quick_reply3'],
4 => $txt['wysiwyg_quick_reply4'],
5 => $txt['wysiwyg_quick_reply5'],
6 => $txt['wysiwyg_quick_reply6'],
7 => $txt['wysiwyg_quick_reply7'],

But you'll notice some of those missing from the modifications language file:
Code: [Select]
$txt['wysiwyg_quick_reply'] = 'Choose Quick Reply Type';
$txt['wysiwyg_quick_reply0'] = 'WYSIWYG (with bbc buttons and smilies)';
$txt['wysiwyg_quick_reply2'] = 'WYSIWYG (with smilies only)';
$txt['wysiwyg_quick_reply3'] = 'WYSIWYG Only';
$txt['wysiwyg_quick_reply4'] = 'Non-WYSIWYG (with bbc buttons and smilies)';
$txt['wysiwyg_quick_reply6'] = 'Non-WYSIWYG (with smilies only)';
$txt['wysiwyg_quick_reply7'] = 'Non-WYSIWYG (standard)';

1 and 5 missing, same as the errors...?
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Better Profile Menu
« Reply #27 on: August 03, 2014, 09:37:56 AM »
Ah! Now I understand why in this case. Seems fixable ... or maybe not lol ...

@ dougiefresh - as I said, I wasn't trying to lay blame or disparage your coding or anything like that. Was just trying to understand the situation which Arantor explained so that I could.

For anyone else who runs into this problem, it can be gotten around as per:

http://www.simplemachines.org/community/index.php?topic=251436.msg3567423#msg3567423
« Last Edit: August 03, 2014, 10:00:36 AM by Steve »
Online Manual

Please do not PM me for support.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Better Profile Menu
« Reply #28 on: August 03, 2014, 10:28:16 AM »
Actually, my test case was only SMF + WYSIWYG Quick Reply v2 mod, which resulted in errors.  Better Profile Menu had not been installed on the test forum....

Mind you, the profile code is a labyrinthine mess.
Actually, this mod doesn't touch the profile code, only the Subs.php section that deals with the Profile top menu....
« Last Edit: August 03, 2014, 10:38:25 AM by dougiefresh »

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,608
    • StoryBB/StoryBB on GitHub
Re: Better Profile Menu
« Reply #29 on: August 03, 2014, 10:58:48 AM »
Ah, I see. The profile code is still a labyrinthine mess though ;D There be dragons.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,150
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: Better Profile Menu
« Reply #30 on: August 06, 2014, 12:32:26 AM »
Awesome, always swearing at that menu for not having the look and layout option selectable without browsing another page. Huge thanks!
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

kat

  • Guest
Re: Better Profile Menu
« Reply #31 on: August 12, 2014, 06:47:21 AM »
As an aside, should you happen to have BK's TopMenu mod installed, this seems to work, with that, which is kinda groovy. :)

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Better Profile Menu
« Reply #32 on: August 12, 2014, 05:21:31 PM »
Awesome, always swearing at that menu for not having the look and layout option selectable without browsing another page. Huge thanks!
I know, right?  You're welcome!

As an aside, should you happen to have BK's TopMenu mod installed, this seems to work, with that, which is kinda groovy. :)
Awesome, even better!  Although it would be very cool to have something like 2.1's bar with the profile and stuff on it, TopMenu seems to have it pretty much covered....  (Maybe someone should suggest it to the author  ;D )

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,608
    • StoryBB/StoryBB on GitHub
Re: Better Profile Menu
« Reply #33 on: August 12, 2014, 05:35:41 PM »
Doing what 2.1 does is evil voodoo. Could not recommend >:D
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Better Profile Menu
« Reply #34 on: August 12, 2014, 07:50:31 PM »
Doing what 2.1 does is evil voodoo. Could not recommend >:D
Well, it's just a thought....  I know: major pain to do so....

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,608
    • StoryBB/StoryBB on GitHub
Re: Better Profile Menu
« Reply #35 on: August 12, 2014, 07:58:45 PM »
Yup, there's an AJAX call and a template and some utter wrangling inside the profile permissions area, not least because I changed certain things in the heart of 2.1 about the profile.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline thelastlokean

  • Newbie
  • *
  • Posts: 8
Re: Better Profile Menu
« Reply #36 on: October 15, 2014, 12:49:27 PM »
Is this compatible with the Ultimate Profile mod?  It would be nice if it added in a link to the UP settings directly into the menu.

I'm nervous to test installing this because I don't want to end up manually uninstalling anything...

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,150
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: Better Profile Menu
« Reply #37 on: October 15, 2014, 02:10:17 PM »
At least TRY to do it before complaining?
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Better Profile Menu
« Reply #38 on: October 15, 2014, 02:16:53 PM »
Is this compatible with the Ultimate Profile mod?  It would be nice if it added in a link to the UP settings directly into the menu.
With version 1.3 of the Better Profile Menu, it will be....

I'm nervous to test installing this because I don't want to end up manually uninstalling anything...
No worries.  This mod is completely hook-based, meaning no alterations are made to the source files...

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Better Profile Menu
« Reply #39 on: October 15, 2014, 02:18:06 PM »
Uploaded v1.3 - October 15th, 2014
o Added support for Ultimate Profile mod