Advertisement:

Author Topic: 2.1 Tokens  (Read 3308 times)

Offline qICEp

  • Semi-Newbie
  • *
  • Posts: 36
2.1 Tokens
« on: November 24, 2014, 03:25:09 PM »
Just found time to play with 2.1 after a long time and i noticed that tokens fields in templates.
I know about these since the 2.1 hit github and i was thinking its a experiment to see if the system is working and that it will be converted to some kind of form helper that would handle tokens. But i see i was wrong...

May i ask why someone bothered to add all that tokens hidden input to each form when it was way better to handle with some kind of form helper (generator)?
Whole form validation process could be more secure against human error and still being easier to implement (not to mention making life easier for people that will make mods). Was these overlooked or i dont get some point?

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,626
    • StoryBB/StoryBB on GitHub
Re: 2.1 Tokens
« Reply #1 on: November 24, 2014, 03:26:55 PM »
Because rewriting everything to use form helpers is actually much, much more work than adding tokens actually was.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline live627

  • Developer
  • SMF Hero
  • *
  • Posts: 5,422
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: 2.1 Tokens
« Reply #2 on: November 24, 2014, 09:23:32 PM »
2.1 won't get any new unified form helpers.
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Suki

  • Kaizoku Jotei
  • Developer
  • SMF Super Hero
  • *
  • Posts: 15,360
  • I don't really come from outer space
    • MissAllSunday on GitHub
    • SMF mods
Re: 2.1 Tokens
« Reply #3 on: November 24, 2014, 09:41:51 PM »
There is some code buried somewhere on SVN and I actually thought about adding it, I have some code I can adapt for it however, its too late to modify every form to use it and it will be kinda weird to provide a form builder without actually using it.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Look at them. They're just asking for it. Maybe the human race deserves to be wiped out.

Offline qICEp

  • Semi-Newbie
  • *
  • Posts: 36
Re: 2.1 Tokens
« Reply #4 on: November 25, 2014, 03:57:35 PM »
Well if someone went to every form to add that input field i dont think it would make much difference if he actually converted forms instead... Simply said i can not understand that 2.1 had such active development, great idea, and it was given allot of time but some things like these were never planed (i expected that someone just forgot to commit changes)

I understand that 2.1 has hit its first beta and that now there is nothing to do about these. (Thats what you get for being lazy to ask when its time  :'( )

Anyway thanks for answers guys.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,626
    • StoryBB/StoryBB on GitHub
Re: 2.1 Tokens
« Reply #5 on: November 25, 2014, 04:00:47 PM »
Adding tokens is like a 2 line job for each form - adding a form handler means a complete rewrite of every form.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Dragooon

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 6,738
  • Gender: Male
  • I'm bIn
    • ShitizGarg on Facebook
    • Dragooon on GitHub
    • dragooon on LinkedIn
    • SMF-Media
Re: 2.1 Tokens
« Reply #6 on: November 25, 2014, 04:02:52 PM »
Well if someone went to every form to add that input field i dont think it would make much difference if he actually converted forms instead... Simply said i can not understand that 2.1 had such active development, great idea, and it was given allot of time but some things like these were never planed (i expected that someone just forgot to commit changes)
Using a form builder would require converting all the form templates into using the form builder class, that's a lot of work.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 57,355
  • Gender: Male
    • Kindred-999 on GitHub
Re: 2.1 Tokens
« Reply #7 on: November 25, 2014, 05:30:24 PM »
And it was never part of the 2.1 plan either, because of the amount of work.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.