News:

SMF 2.1.2 has been released! Take it for a spin! Read more.

Main Menu

Message Bookmarks

Started by Bugo, March 11, 2022, 09:06:32 PM

Previous topic - Next topic

Aleksi "Lex" Kilpinen

Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Matthias

Thanks for the link.

But there is also only "de". I wanted to look at the SMF software, what is specified there at german_informal. Unfortunately I can not see that.

Quality first

FrizzleFried

I can not explain why... but all of a sudden I notice that my bookmark icons are gone on my test site.  The codes are there (fas fa-bookmark and far fa-bookmark) but nothing.   The block is there in the posts but it's very small and empty.

I am not sure which mod I may have installed on the test site to kill this...

I only noticed when updating from .8 to .9 to test.  The issue was present in .8 so it's not a .9 thing... it has got to be a conflict with another mod I am guessing?

Aleksi "Lex" Kilpinen

Quote from: Matthias on April 24, 2022, 09:07:40 AMBut there is also only "de". I wanted to look at the SMF software, what is specified there at german_informal. Unfortunately I can not see that.
Oh, right. I'm not sure how that's setup and not familiar enough with Crowdin to know where to look for.
I do see code for German in the url is de and for German_informal its deinf, but I'm not sure if this is the answer.
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

FrizzleFried

Emoji's are working fine.  If I was to find any critique at this point it would exceptionally minor and it would be that my OCD is kicking in when I see the titles of each column (#    Date    Title    Board    Actions) ... specifically the Title and Board column names.  They should be flush left vs centered IMHO.  ;)

Like I said... very minor.


You cannot view this attachment.

Bugo

This mod does not add the FontAwesome library, so, if you are not using a theme or another mod with FA library, you won't see FA icons.

FrizzleFried

Hmmm... what is strange is that it was working... now it's not (the FA options).  I have no idea what I did to cause that.  I must have had a mod installed in testing that had the library installed.

If there was a feature I'd love to see added in a future version it would be to be able to select a local png file to use.  The emoji's are lacking a decent bookmark icon.  I figure I'll go with a PIN to add and an X to remove.

Thank you Bugo... you're one of my favorite mod developers... your mods are always very well done.

Matthias

Quote from: Bugo on April 24, 2022, 08:03:19 AMI tried, but these codes already exist.

You cannot view this attachment.

@m4z, can you help with this?

Have had anouther look to this. I think, there is no standard for that.

I think, the best way to fit this is:
Locale code: de-DE-informal
Quality first

@rjen

Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl
Testing SMF 2.1 with next version TinyPortal at test.fjr-club.nl

Matthias

@rjen
Thanks for that. I hope, it is enouth info for @Bugo to take it.
Quality first

Bugo

I have already added German Informal, wait for translators :)

Matthias

german and german_informal translations are completed
Quality first

Bugo

v0.9.1
  • Updated translations
  • Added German and German Informal (thanks to JessyKa and Matthias)

woolly bugger

hmmm.... I saw there is an update to the mod, however when I went to my Package Manager I don't have an option to uninstall previous version 7.2 ...

What's the best way to deal with this?


Bugo

Manually delete all records containing "Message Bookmarks" from the smf_log_packages table.
Also, remove the Class-MessageBookmarks.php file from the Sources folder.
Go to Forum Maintenance -> Integration Hooks and remove the hook relating to Message Bookmarks.


Steve

No offense Bugo but that seems like an unwieldy way to upgrade. Will future versions be able to uninstall normally?

Or am I not understanding the post just above yours?
Please do not PM me for support.

m4z

Quote from: Bugo on April 24, 2022, 08:03:19 AMI tried, but these codes already exist.

You cannot view this attachment.

@m4z, can you help with this?

Sorry for the late reply... As Lexi said, SMF uses "deinf" but anything with the "de" prefix seems reasonable.
"Faith is what you have in things that don't exist."
--Homer Simpson

Es gibt hier im Forum ein deutsches Support-Board!
<werbung>Meine Freundin hat ihr erstes Buch veröffentlicht!</werbung>

shawnb61

I am upgrading 2.0 bookmarks from the old mod into this mod within 2.1.  The following sql seems to work, so I'm sharing it in case others find it helpful.  Since the old mod bookmarked topics, where this mod bookmarks messages, I use the first message within each topic:
INSERT INTO smf_message_bookmarks (msg_id, topic_id, bookmark_title, user_id, created_at)
    SELECT t.id_first_msg, b.id_topic, m.subject, b.id_member, m.poster_time
    FROM smf_bookmarks b
      INNER JOIN smf_topics t
      ON b.id_topic = t.id_topic
      INNER JOIN smf_messages m
      ON m.id_msg = t.id_first_msg
    ORDER BY t.id_first_msg
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Costa

Portuguese_pt Translation
Hugo "Costa" Fernandes - PT SMF
Todas as MP's a pedir ajuda são sujeitas a radioactividade, microondas, queimadas e atiradas borda fora.

"At least someone appreciates the fact that I am doing and not thinking..."
"Laziness is counter-revolutionary."

JessyKa

Hello,
I had the mod installed and it worked fine for several months.
Yesterday there was an error with the forum layout, an expert from here had a look at it and there were several files corrupted, maybe there had been maintenance works going on at the server. No such info of the provider though.
After repairing anything works but reinstalling this mod.
The pre-check for installation is without any warning, in installing it says:
QuoteYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ',,,,,,)
SELECT ,,,,,,
FROM smf2_message_bookmarks_old' at line 1
Datei: /var/www/vhosts/web68.chalmers.kundenserver42.de/httpdocs/smf/Packages/temp/database.php
Zeile: 83


Any idea what to do?

Advertisement: