lastLoggedIn - incorrect?

[thegymforum]

When viewing a user's profile i.e
http://smf21.com/index.php?action=profile;u=2

The "Last Logged In" was missing in 2.1.  I looked at the code:

Themes/default/Profile.template.php

Code Select Expand


if ($context['member']['online']['is_online'])
echo '
<dt>', $txt['lastLoggedIn'], ': </dt>
<dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>';


Should the first line be commented out? seems like we'd want to see a person was last logged in whether or not they're currently online.  Or am I misreading the first line's purpose?

Code Select Expand


// if ($context['member']['online']['is_online'])
echo '
<dt>', $txt['lastLoggedIn'], ': </dt>
<dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>';


[br360]

This was brought up on this thread (as well as a fix)- http://www.simplemachines.org/community/index.php?topic=535264.0

No word from the team on that thread, but hopefully they are aware of it.

[thegymforum]

thanks, sorry, I did search, and failed... trying to help.  At least I feel like I pointed out something legit if not already reported... dang it... 

Continues to read and read and experiment with 2.1

thanks br360

[br360]

At least I feel like I pointed out something legit...   

You did.

[margarett]

https://github.com/SimpleMachines/SMF2.1/issues/2812