• Welcome to Simple Machines Community Forum. Please login or sign up.

SEF/URL problem in language files

Started by mt, April 29, 2015, 08:04:26 PM

Previous topic - Next topic

mt

April 29, 2015, 08:04:26 PM Last Edit: April 29, 2015, 08:19:27 PM by mt
Hi

There is a source of problems in the EmailTemplate... language files. Its the macro FORGOTPASSWORDLINK .

If you look through the language file you will see that the macro is at the end of the sentence and followed by a dot.
Like this "{FORGOTPASSWORDLINK}."

Now, when the macro is processed to a link, you get something like "...www.example.com/index.php?action=email.".
If you use "pretty" urls its something like "../email/.".

Notice the dot at the end.

The problem is, that this is send by email and many email programs or web interfaces will see the dot as part of the URL. In fact,
that is right in some way because you usually use a free space or EOL to show the URL ends and a new word starts.

Anyway, to avoid any problems any URL macro processed to a URL/email should have a space between it and the next non whitespace character.


Antes

My wild guess is this is also about Vietnamese language ?

mt

April 30, 2015, 06:59:28 AM #2 Last Edit: April 30, 2015, 07:13:26 AM by mt
Uhm... no?

Is across all language files. Do a "{FORGOTPASSWORDLINK}." file search.

the dot *IS* aligned to the password link.

Its perhaps not good to see in the cryptic normal links but run it with portamx SEF activated or pretty urls and check then
the email output. There its good to see and it will have a heavier impact because the rewrite functions server sided or smf inside
will bug out with a bigger chance.

It is a real bug because the dot will always pollute the link but it just do not have an effect always because smf will eat it in many cases
and/or the link visualation client sided will guess right that the dot is not part of the link and will exclude it.

That is why it was overseen so long.

Ninja ZX-10RR

Thanks, I manually fixed it in my own language files. Tedious stuff :( Also the language packs are so much different between themselves, some languages don't even have that macro in them, so I figure they are some old versions or something.
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.

♥ Jess ♥

STOP EDITING MY PROFILE

Advertisement: