Move Topic Issue- 2.1 Beta2

[br360]

I just upgraded a site to 2.1 Beta2, and am seeing something weird when moving topics. If I move a topic from board A to board b, and uncheck "Post a redirection topic.", it works fine.

However, there is an issue if I move a topic from one board to another and leave a redirect topic notice. If I go back to the moved topic notice and delete it, it actually deletes the topic that was moved to a new board instead. Then when I go back and try to reopen the redirect topic notice, I get the "The topic or board you are looking for appears to be either missing or off limits to you" error.

[Illori]

same issue you already reported

Hmmm, ok. I have no idea why then when I delete the [merge] topic, it actually deletes the topic that everything was merged into instead.

i dont think that part was actually fixed when the bug was fixed.

[br360]

Yes it was very similar, and I almost posted a link of that topic here as well. That last issue was with merge topics though, so I wasn't sure if they were related.

[Illori]

might help the devs to report these issues on github so they are sure to see them and they are tracked.

there are some issues with moving topics i believe that may still be open on github.

[live627]

Can you track this so it won't get lost?

[br360]

might help the devs to report these issues on github so they are sure to see them and they are tracked.

there are some issues with moving topics i believe that may still be open on github.

I'd be happy to, but other than going to github to download packages, haven't really used it before. Is there a section there where I can post this issue?

[margarett]

https://github.com/SimpleMachines/SMF2.1/issues

Or I'll just move this to Bug Reports.

[br360]

Thanks for the link Bruno. I just went ahead and created an account and posted the issue there.

[margarett]

See? Easy right?

edit: I can't reproduce that... I was able to leave a redirection topic and delete it with either the checkboxes or going inside the topic (if I don't choose to redirect, of course...) and delete it with the bottom "REMOVE TOPIC" button...

[br360]

A little scary, but fought my way through it.

Yes, easy enough, thanks. For any future issues I may find; is it still good to start a thread here as well, or would the team prefer just posting an issue posted on github?

[margarett]

Well, optimally everything is tracked at GH. But to be honest, I like the discussion here better (I'm not a big fan of their interface, just that)

[br360]

edit: I can't reproduce that... I was able to leave a redirection topic and delete it with either the checkboxes or going inside the topic (if I don't choose to redirect, of course...) and delete it with the bottom "REMOVE TOPIC" button...

Just saw your edit:

I just tried it again to be sure, and the same thing is happening. To be more descriptive; when I go back to the redirect topic "Moved: (topic name)" and open it, instead of it showing what shows on 2.0 (this topic has been moved to (board) and (new topic link) it actually shows the new topic instead and the new board it has been moved to.

[margarett]

Ah that. Yes, it is doing what it's supposed to

When you are moving the topic you have the choice to leave a redirection topic or not and if that topic is a direct redirection or not.

So if you leave default values, your MOVED topic is actually a redirection to the actual topic.

[br360]

That does make sense, but the redirect topics are still visible from the old board, and there is no way to remove them if I forget to uncheck the redirection- without deleting the moved topic in the new board as well.




Even after running the "Remove MOVED: redirection topics" task, the redirect topics are still there.

[live627]

the redirect topics are still visible from the old board, and there is no way to remove them if I forget to uncheck the redirection- without deleting the moved topic in the new board as well.

Quick moderation should work for that.

Even after running the "Remove MOVED: redirection topics" task, the redirect topics are still there.

the maintenance task?

[br360]

The maintenance task did not work, however enabling quick moderation did in fact work and the moved topic notice was removed- thanks for that.

It's a solution, but just seems a little more inconvenient than the 2.0.x versions- where you can just be able to delete a removed notice topic like other topics.

[live627]

Even after running the "Remove MOVED: redirection topics" task, the redirect topics are still there.

the maintenance task?

To clarify, not the scheduled task?

[br360]

Yes, it was scheduled task- Admin >>Maintenance>>Scheduled Tasks>>Remove MOVED: redirection topics

[br360]

The maintenance task did not work, however enabling quick moderation did in fact work and the moved topic notice was removed- thanks for that.

It's a solution, but just seems a little more inconvenient than the 2.0.x versions- where you can just be able to delete a removed notice topic like other topics.

Quoting this because I am unable to edit it- Just to confirm about quick moderation- It will remove the forwarded/moved topic as well as the moved topic notice as well. Obviously if a moderator moves a topic, and accidentally forgets to uncheck the redirection notice; we don't want to actually delete the moved topic itself when we try to remove the notice topic.

[margarett]

I wasn't able to reproduce that, I'll try again today.

Just to be sure: are you using the B2 release package or the code from GH?

[Kindred]

do note... in 2.1 - the moved topic stubs are automatically cleaned up after X days, where X is the setting that you have defined in the smf admin

You are absolutely correct
in 2.1 the moved post becomes a stub which immediately redirects the click into the thread - wherever it was moved to. This is FAD (functions as designed) an is completely intentional.
and that means that you are also correct that you can not delete the stub form inside it -- because the stub is nothing more than a bounce.

You can manually delete using quickmoderation checkboxes...
you can wait for the stub to expire and get automatically removed after a time...


So...   it is looking like there is no actual bug here....   just confusion over how the redesigned feature works.

[br360]

Just to be sure: are you using the B2 release package or the code from GH?

Yes, it was the B2 release package from here- http://download.simplemachines.org/

You can manually delete using quickmoderation checkboxes...
you can wait for the stub to expire and get automatically removed after a time...


So...   it is looking like there is no actual bug here....   just confusion over how the redesigned feature works.

It is different than how 2.0 is set up obviously, and not a bad improvement actually. The issue though is that even when using the quick moderating checkboxes to delete the redirect notice, it also deletes the topic that was moved.

Also, from what I can see, running the scheduled task I mentioned earlier, does not delete the redirect notice either; so the only options I see are to either uncheck the redirect notice when moving a topic or if one forgets to do that, just wait out the days chosen in the redirect option for the moved notice to delete.

[Kindred]

the scheduled task would only remove the notices whose time period has expired, AFAIK

[Illori]

the scheduled task would only remove the notices whose time period has expired, AFAIK

yep exactly, if the time has not expired or a time was not set it will not remove the topic.

i tried to manually delete the move redirect topic using the quick moderation options and i had no issues, the topic it redirects to still exists.


are you trying to "view" the redirect topic and then deleting it? if so make sure you are not on the topic that was moved. you cannot actually view the redirection topic to delete it from within the topic.

[br360]

are you trying to "view" the redirect topic and then deleting it? if so make sure you are not on the topic that was moved. you cannot actually view the redirection topic to delete it from within the topic.

I am deleting the "moved:topic name" notice from the old board- not the topic that has been moved to the new board I want it to. It's when I delete the notice topic from the old board that the new topic gets deleted.

[Illori]

when i try to do that, the topic on the second board does not get deleted.

you are using the quick moderation options on the message index to remove the MOVED: topic?

[br360]

Ok, so I just tried it again and it worked. I created a new topic in board one. Moved it to board two, then went back to board one, deleted the moved notice topic there with quick moderation and it deleted that topic only- leaving the newly moved topic in board two in tact.

Not sure what I did different or how it worked properly this time, but I promise that I am not that crazy- and I had tried to delete moved topics before with quick moderation- and it did delete both topics. 

Weird.

[margarett]

Nah. You're weird that's all

* margarett goes to sleep and be right back