Author Topic: [GH#3027] [img] with alt/height/width combines alt and height parameters (Read 10541 times)

Joshua Dickerson · « **on:** September 04, 2015, 03:50:16 PM »

[img alt=Test height=100 width=100]http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png[/img]

Code: [Select]

<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="Test height=100" width="100" class="bbc_img resized" style="cursor: pointer;">

What would be expected is:

Code: [Select]

<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="Test" height="100" width="100" class="bbc_img resized" style="cursor: pointer;">

Shambles · « **Reply #1 on:** September 04, 2015, 04:20:53 PM »

I was under the impression that 'alt' text had to be enclosed within quotes to start with...?

Code: [Select]

[img alt="Test"...]

Joshua Dickerson · « **Reply #2 on:** September 04, 2015, 04:26:28 PM »

Nope, but thanks for reminding me. That's another part of the bug.

Code: (input) [Select]

[img alt="Test" height=100 width=100]http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png[/img]

Code: (output) [Select]

<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="&quot;Test&quot; height=100" width="100" class="bbc_img resized" style="cursor: pointer;">

Code: (expected) [Select]

<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="Test" height="100" width="100" class="bbc_img resized" style="cursor: pointer;">

Ninja ZX-10RR · « **Reply #3 on:** September 05, 2015, 02:28:42 AM »

* Ninja ZX-10RR follows

Oldiesmann · « **Reply #4 on:** September 05, 2015, 02:09:26 PM »

Tracked on GitHub as issue 3027: https://github.com/SimpleMachines/SMF2.1/issues/3027

Ninja ZX-10RR · « **Reply #5 on:** September 05, 2015, 02:46:20 PM »

Can this be included into 2.0.11 as well please?

Kindred · « **Reply #6 on:** September 05, 2015, 03:56:55 PM »

maybe.... however, it's such an unused feature that it has taken years for anyone to report it...

Joshua Dickerson · « **Reply #7 on:** September 05, 2015, 05:50:35 PM »

Yeah and I didn't find a fix yet so it would take time for them to fix it. If/when I find the fix, it will be easier to include it in the next release.

Illori · « **Reply #8 on:** September 05, 2015, 06:28:18 PM »

seem strange to anyone?

Code: [Select]

array(
				'tag' => 'img',
				'type' => 'unparsed_content',
				'parameters' => array(
					'alt' => array('optional' => true),
					'title' => array('optional' => true),
					'width' => array('optional' => true, 'value' => ' width="$1"', 'match' => '(\d+)'),
					'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
				),
				'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',

and in the resulting page source you see it in a different order?

Code: [Select]

<img class="bbc_img resized" width="100" title="" alt="Test height=100" src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" style="cursor: pointer;">

what is changing the order? alt should be before title then width and height with the class last.

Joshua Dickerson · « **Reply #9 on:** September 20, 2015, 10:40:58 PM »

Uh, not sure how you're getting that output but I don't see it.

Ninja ZX-10RR · « **Reply #10 on:** September 21, 2015, 12:27:25 AM »

Me neither...

Antes · « **Reply #11 on:** September 21, 2015, 04:49:37 AM »

Another bug of chrome-based browsers?

Illori · « **Reply #12 on:** September 21, 2015, 05:09:01 AM »

that was in firefox, so not a chrome bug.

also antes that is for bbc not for an avatar. so different things using different code.

Ninja ZX-10RR · « **Reply #13 on:** September 21, 2015, 05:54:08 AM »

I was using Chrome in that screenshot, too

Antes · « **Reply #14 on:** September 21, 2015, 11:48:15 AM »

Quote from: Illori on September 21, 2015, 05:09:01 AM

that was in firefox, so not a chrome bug.

also antes that is for bbc not for an avatar. so different things using different code.

the screenshot Ninja posted your avatar with chrome,
the screenshot I posted your avatar with firefox.

Illori · « **Reply #15 on:** September 21, 2015, 11:50:52 AM »

the issue i am reporting is with an image posted in a TOPIC, it has NOTHING at all to do with any other image that shows up anywhere else.

this bug is reported on the img bbc tag.

margarett · « **Reply #16 on:** September 21, 2015, 12:24:37 PM »

Over the discussion about the BBC parsing which might cause a huge memory consumption, I seem to remember someone (Spuds?) finding out that the current implementation doesn't return all possible permutations of the arguments. Maybe this is related?

Ninja ZX-10RR · « **Reply #17 on:** September 21, 2015, 05:33:52 PM »

Could be, it's just way too old and would need to be somehow made "up-to-date" entirely, lol.

Antes · « **Reply #18 on:** January 06, 2017, 06:39:15 AM »

Issue closed/resolved. If you are having such issues please open new topic while using latest build.

Joshua Dickerson · « **Reply #19 on:** January 07, 2017, 02:44:43 PM »

What version is it updated in?

Illori · « **Reply #20 on:** January 07, 2017, 03:05:35 PM »

the only version that is on github, SMF 2.1

Joshua Dickerson · « **Reply #21 on:** January 07, 2017, 03:08:13 PM »

Do you have any tests to make sure it is still working?

Illori · « **Reply #22 on:** January 07, 2017, 03:20:44 PM »

that is why it was posted here that it is fixed so that people are aware and can test and report back on github if there are any issues.

Joshua Dickerson · « **Reply #23 on:** January 22, 2017, 04:05:15 PM »

I mean unit tests.

News:

Author Topic: [GH#3027] [img] with alt/height/width combines alt and height parameters (Read 10541 times)