• Welcome to Simple Machines Community Forum. Please login or sign up.
October 18, 2021, 07:10:49 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Pagination

Started by MESWEB, January 05, 2016, 03:44:06 AM

Previous topic - Next topic

MESWEB

Pagination bug
<span onmouseover="this.style.cursor='pointer';" onclick="expandPages(this, '/index.php?action=profile;u=1;area=showposts;start=%1$d', 45, 150, 15);" style="font-weight: bold; cursor: pointer;"> ... </span>
This url is not valid:
/index.php?action=profile;u=1;area=showposts;start=%1$d

Illori

would you like to give us some more information? what version is this issue in? either in SMF 2.0 or SMF 2.1 i cant duplicate any issue that seems related to this. so where are you seeing this issue?

margarett

TBH I don't know why there is that %1$d (but that is usually a replacement variable - not that usual in HTML but maybe JS makes some sense out of it).

Pagination does work properly everywhere (and that is present in all pagination links which I checked in 1min) so I'm not sure we'd call that a bug - maybe it should work like that. Dunno, I can't really tell how that works :(

@Illori, you can see it in this forum. Go to any place which has several pages (Show Posts, list of topics, even pages of a post), so many pages which bring out the "..." link in the pagination. If you point your browser developer tools to that "..." link, you'll see it
<span style="font-weight: bold; cursor: pointer;" onclick="expandPages(this, 'http://www.simplemachines.org/community/index.php?board=5.%1$d', 75, 10100, 25);" onmouseover="this.style.cursor='pointer';"> ... </span>
Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

Kindred

that's part of the onclick/expandPages javascript and is completely valid within javascript AFAIK.

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

MESWEB

You are wrong. Maybe this is valid for humans but not for crawlers. Bots indexing that links and try open it. try open this url by Yourself. I think we can use html5 with css to make better pagination function.

Illori

SMF 2.0 will not take advantage of html5.

MESWEB

But we can simple fix this by create new html for this bug.

margarett

Quote from: MESWEB on January 05, 2016, 05:04:55 PM
Maybe this is valid for humans but not for crawlers. Bots indexing that links and try open it
They shouldn't. That's an "onclick" event, which is always handled by JavaScript. Bots shouldn't try to follow that ;)

Again, not saying that it is right or wrong because I don't know what that is supposed to do. I'm just saying that there should be absolutely no problem with that.
Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

MESWEB

Google Bot have different view. In Google Webmaster Tool I have some errors about this links. So don't tell me
Quoteno problem with that

margarett

A bit of googling around and it seems you're right. It doesn't make any sense but apparently Google is doing it.

Google also returned this
http://www.simplemachines.org/community/index.php?topic=519057.msg3837404#msg3837404
Which should fix your issue ;)
Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

MESWEB

Yes i know that but how long it takes to recognize real url by Google? One week? One month? Who knows?

margarett

Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

Advertisement: