Advertisement:

Author Topic: Automatic Attachment Rotation (and Resize)  (Read 54987 times)

Offline Denny O

  • Charter Member
  • Newbie
  • *
  • Posts: 9
  • Gender: Male
  • The gene pool could use a little chlorine.
Re: Automatic Attachment Rotation (and Resize)
« Reply #220 on: June 25, 2019, 01:15:15 AM »
dougiefresh,

I did not want to bug you so I did await your response.
Many Thanks my hard working friend! I will see how it turns out here.

Thank You!
Denny O
Hook'in Walleyes while Watch'in my Hawkeyes!

Offline TourFL

  • Semi-Newbie
  • *
  • Posts: 66
Re: Automatic Attachment Rotation (and Resize)
« Reply #221 on: July 02, 2019, 05:30:53 AM »
Thanks for the update  :)
Unfortunately, the problem is still here (same messages, at the same file/line)

Installation of version 5.8 went smoothly, just had a small conflict on the post.php file with the Inline Attachement module, but it was easily solved manualy.

I attach you my display.php file  ;)
If you like Fiat 500 and derived models, the SMF forum I'm helping with: www.500-126.com

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Automatic Attachment Rotation (and Resize)
« Reply #222 on: July 26, 2019, 10:39:34 AM »
The mod needs to be updated so it will work on php 7.2 without error. it works well on 7.1 but not 7.2. I have it installed on 2.1 RC 2.

error:

Error
Type of error: Undefined_vars
Error message: 8: Undefined index: imiyf_txt
File: /home/djradios/public_html/Sources/Load.php
Line: 2392
URL of page causing the error: https://djradiosoundstation.com/index.php?/music-network/811-izgatnizo/friends
Backtrace information
#0: smf_error_handler()
Called from /home/djradios/public_html/Sources/Load.php on line 2392
#1: loadTheme()
Called from /home/djradios/public_html/index.php on line 191
#2: smf_main()
Called from /home/djradios/public_html/index.php on line 151
« Last Edit: July 26, 2019, 10:52:01 AM by TigerAnt »
I help those who cannot get help elsewhere with free help!

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 72,951
Re: Automatic Attachment Rotation (and Resize)
« Reply #223 on: July 26, 2019, 11:05:25 AM »
That’s a different error message, relating to a different mod.

The 7.2 issue is the need to replace uses of create_function.

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Automatic Attachment Rotation (and Resize)
« Reply #224 on: July 26, 2019, 12:34:03 PM »
Type of error: General
Error message: 8192: Function create_function() is deprecated
File: /home/djradios/public_html/Sources/ManageAttachments.php
Line: 664
URL of page causing the error: https://djradiosoundstation.com/index.php?action=admin;area=manageattachments;sa=browse
Backtrace information
#0: smf_error_handler()
Called from /home/djradios/public_html/Sources/ManageAttachments.php on line 664
#1: BrowseFiles()
Called from /home/djradios/public_html/Sources/Subs.php on line 5095
#2: call_helper()
Called from /home/djradios/public_html/Sources/ManageAttachments.php on line 86
#3: ManageAttachments()
Called from /home/djradios/public_html/Sources/Admin.php on line 512
#4: AdminMain()
Called from /home/djradios/public_html/index.php on line 151
I help those who cannot get help elsewhere with free help!

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Automatic Attachment Rotation (and Resize)
« Reply #225 on: July 26, 2019, 02:59:10 PM »
That’s a different error message, relating to a different mod.

The 7.2 issue is the need to replace uses of create_function.
Sorry I posted the wrong error, here is the right one above.
« Last Edit: July 26, 2019, 04:03:16 PM by TigerAnt »
I help those who cannot get help elsewhere with free help!

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Automatic Attachment Rotation (and Resize)
« Reply #226 on: July 26, 2019, 04:26:02 PM »
(Update) I had added a mod to 2.1 RC 2, (Automatic Attachment Rotation (and Resize) I removed the mod by deleting it and I noticed that an error still existed. The error goes away when you change the PHP back from 7.2 to 7.1. While in 7.2 every time you clicked on any of these (Browse files: > Attachments | Resize Existing Images | Avatars | Thumbnails) it would create a new error.
I help those who cannot get help elsewhere with free help!

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 72,951
Re: Automatic Attachment Rotation (and Resize)
« Reply #227 on: July 26, 2019, 04:29:43 PM »
Deleting mods doesn't remove them, it just removes your ability to uninstall them first.

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Automatic Attachment Rotation (and Resize)
« Reply #228 on: July 26, 2019, 04:43:38 PM »
Now that comment went way over my head lol. If I install the mod, are you telling me by uninstalling it, does not delete it from my site?
I help those who cannot get help elsewhere with free help!

Offline Aleksi "Lex" Kilpinen

  • A Peculiar Finn
  • Lead Support Specialist
  • SMF Super Hero
  • *
  • Posts: 18,930
  • Gender: Male
  • Don't worry, I'm n00b friendly
    • Aleksi.Kilpinen on Facebook
    • LexArma on GitHub
    • aleksi-kilpinen on LinkedIn
    • There's No Place Like 127.0.0.1
Re: Automatic Attachment Rotation (and Resize)
« Reply #229 on: July 26, 2019, 04:52:42 PM »
Delete and uninstall are two different functions. Delete removes the package, uninstall removes the functionality.
A Finnish Support Specialist
 Happily running multiple SMF 2.0 installations.
  Fooling around with an i7 990X @ 3,47Ghz / 12Gb / Win 10 x64 / 3840x2160


How you can help SMF

"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum.
 Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Automatic Attachment Rotation (and Resize)
« Reply #230 on: July 26, 2019, 04:56:14 PM »
Delete and uninstall are two different functions. Delete removes the package, uninstall removes the functionality.
Thank you, I wasn't aware of that!
I help those who cannot get help elsewhere with free help!

Offline landyvlad

  • Sr. Member
  • ****
  • Posts: 922
  • Gender: Male
    • Michael Reed on Facebook
    • GSX1400 Owners ORG
Re: Automatic Attachment Rotation (and Resize)
« Reply #231 on: July 29, 2019, 02:47:07 AM »
Thanks Dougie !
Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

To paraphrase Kindred: "There are no technical solutions to social problems."

No hack nor blackhats, just persistent asshats.

Offline amygil

  • Newbie
  • *
  • Posts: 1
Re: Automatic Attachment Rotation (and Resize)
« Reply #232 on: August 27, 2019, 03:33:40 PM »
Thanks for creating this great mod. I have 3 Dougiefresh Mods installed on my forum and they are all very much appreciated.

That said, I just installed the latest SMF release candidate (SMF 2.1 RC2) along with the latest Automatic Attachment Rotation mod (v5.8) and I'm getting a few errors that I thought you might want to know about.

1. I get two errors when anyone visits my Forum's help page:

Code: [Select]
Type of error: General
 Hook call: function "AutoRotation_LoadHelp" in file /path/to/myforum could not be called.
 https://forumdomain.com/index.php?action=help
and
Code: [Select]
Type of error: General
 The callable AutoRotation_LoadHelp could not be called.
 https://forumdomain.com/index.php?action=help

2. I get an error when anyone visits a page that has an image on it (I think this has been mentioned before but not since the latest release is out)

Code: [Select]
Type of error: Undefined
 8: Undefined variable: proper_rotation
 https://forumdomain.com/index.php?action=dlattach;topic=194.0;attach=165;image;ts=1514734086
 /path/to/myforum/Sources/ShowAttachments.php (Line 151)

Line 151 of ShowAttachments.php looks like this
Code: [Select]
if (!$proper_rotation && (isset($_REQUEST['type']) && $_REQUEST['type'] != 'avatar'))
3. My iPhone images are not getting rotated automatically at all. I suspect this is due to changes they made to their file format around iOS 11. The images are now stored as HEIC images and converted to jpeg on upload. I tried uploading both an Avatar and an Attachment and both came out sideways.

Please let me know how I can help you resolve these issues. Thanks!

Offline Denny O

  • Charter Member
  • Newbie
  • *
  • Posts: 9
  • Gender: Male
  • The gene pool could use a little chlorine.
Re: Automatic Attachment Rotation (and Resize)
« Reply #233 on: August 28, 2019, 04:24:53 PM »
I had it loaded on our site earlier this week. I cannot load a jpeg image at all, it kicks me back to a blank page.

One of our other members loaded some rather old pics and seemed fine then he did a new one and it was sideways too, I'm trying to find out the details.
Hook'in Walleyes while Watch'in my Hawkeyes!

Online @rjen

  • Full Member
  • ***
  • Posts: 613
  • Gender: Male
    • FJR-club Nederland
Re: Automatic Attachment Rotation (and Resize)
« Reply #234 on: September 06, 2019, 04:11:47 PM »
I tried to install the latest version to yesterday's Github version for SMF 2.1, but it has a few install errors now...

Running SMF 2.0 with Tinyportal 2.0.0 at www.fjr-club.nl
Testing SMF 2.1 with Tinyportal 2.0.0 at test2.fjr-club.nl

Offline Rob Lightbody

  • Charter Member
  • Jr. Member
  • *
  • Posts: 172
  • Gender: Male
  • Rob Lightbody, QE2 Story Forum administrator
    • The QE2 Story
Re: Automatic Attachment Rotation (and Resize)
« Reply #235 on: December 01, 2019, 07:53:33 AM »
Hi there,

I am seeing a consistent problem, if anyone tries to rotate an image manually, using an iOS device, the attachment disappears.  It works fine on a MacOS device, or on Android, or Windows.

No error is logged when this happens.

Anyone else seen this?

Thanks,

- Rob

Offline GL700Wing

  • Full Member
  • ***
  • Posts: 526
  • Gender: Female
Re: Automatic Attachment Rotation (and Resize)
« Reply #236 on: December 01, 2019, 06:15:40 PM »
Hi there,

I am seeing a consistent problem, if anyone tries to rotate an image manually, using an iOS device, the attachment disappears.  It works fine on a MacOS device, or on Android, or Windows.

No error is logged when this happens.

Anyone else seen this?

Thanks,

- Rob
I've had that happen too but only on iOS devices and I haven't been able to work out a fix because I can't reproduce the problem on a desktop device ...

Basically, when the manual rotation drop-down is selected on an iOS device the checkbox for the image is cleared (ie, the image is marked for deletion). 

The only workaround I've found is to click the checkbox for the image after I've chosen the rotation (and to double-check it) before I save the post.

Thankfully the auto-rotation feature of this mod works most, if not all, of the time for photos that still have their metadata and I've typically only encountered the issue you reported when correcting the rotation of images in posts that were created before the mod was installed and/or for images that have had their metadata removed.

Finally, I suspect it's specifically an iOS issue because I've used five different browsers on my iPad and the same thing happens with every one.
Life doesn't have to be perfect to be wonderful ...

Offline GL700Wing

  • Full Member
  • ***
  • Posts: 526
  • Gender: Female
Re: Automatic Attachment Rotation (and Resize)
« Reply #237 on: December 03, 2019, 06:49:01 AM »
Uploaded v5.9 - December 3, 2019
o Per The QE2 Story Forum - fixed issue specific to iOS (eg, iphones, iPads, etc) of attachments being marked for deletion (ie, checkbox cleared) when rotation dropdown selected while modifying post.


@The QE2 Story Forum - Although the issue you reported (and which I have also encountered) only seems to affect iOS users it was in fact caused by a bug in the mod.
Life doesn't have to be perfect to be wonderful ...

Offline woolly bugger

  • Jr. Member
  • **
  • Posts: 183
    • Blue Ridge Fly Fisherman's Forum
Re: Automatic Attachment Rotation (and Resize)
« Reply #238 on: December 03, 2019, 02:38:46 PM »
Just tried to install 5.9 on my 2.1RC2 dl from github two weeks ago... 11/22

https://github.com/SimpleMachines/SMF2.1/compare/96865d4...release-2.1

getting errors, see attached


Offline GL700Wing

  • Full Member
  • ***
  • Posts: 526
  • Gender: Female
Re: Automatic Attachment Rotation (and Resize)
« Reply #239 on: December 03, 2019, 05:17:16 PM »
Just tried to install 5.9 on my 2.1RC2 dl from github two weeks ago... 11/22

https://github.com/SimpleMachines/SMF2.1/compare/96865d4...release-2.1

getting errors, see attached
The only change I made was to Post.template.php - I'll have to leave it to Dougiefresh to investigate/resolve the issues you are experiencing. 

Also, have you tried installing this mod by itself on a clean 2.1RC2?  If you have and it installs without any errors then the issue you is that one or more of the others mods you've already installed had modified parts of the same code this mod is trying to update.  If this is the case you will need to install this mod manually - see https://wiki.simplemachines.org/smf/Error_in_mod_installation
Life doesn't have to be perfect to be wonderful ...