Advertisement:

Author Topic: Automatic Attachment Rotation  (Read 24996 times)

Online Rock Lee

  • Sophist Member
  • *****
  • Posts: 1,312
  • Gender: Male
  • Digitalizando un nuevo mundo :D
    • BomberCode.Oficial on Facebook
    • RockLee-BC on GitHub
    • @Bomber_Code on Twitter
    • Bomber Code ~ La nueva era del conocimiento
Re: Automatic Attachment Rotation
« Reply #120 on: February 12, 2018, 07:47:21 PM »
I just realized the current but you can see at that moment it did not translate, that's why I leave it to Spanish now! 8)


Regards!
¡Regresando como cual Fenix! ~ Bomber Code © 2018
Ayudas - Aportes - Tutoriales - Y mucho mas!!!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,563
  • Mod King
    • XPtsp.com Community
Re: Automatic Attachment Rotation
« Reply #121 on: February 13, 2018, 10:02:05 PM »
Uploaded v3.9 - February 13th, 2018
o Added Spanish Latin translation, courtsey of Rock Lee.
o Added translators section to README.txt.
o Added LICENSE.txt to satisfy licensing concerns.



@Rock Lee:  Thank you for the translation!!  It's been included in this version!
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline GL700Wing

  • Jr. Member
  • **
  • Posts: 291
  • Gender: Female
Re: Automatic Attachment Rotation
« Reply #122 on: February 17, 2018, 06:26:49 AM »
Uploaded v3.9 - February 13th, 2018
Would you please include the fix for A non well formed numeric value encountered in the next release - as requested I have verified that it works with SMF 2.0.15 and PHP 5.6.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,563
  • Mod King
    • XPtsp.com Community
Re: Automatic Attachment Rotation
« Reply #123 on: February 17, 2018, 11:30:43 AM »
Uploaded v3.10 - February 17th, 2018
o Included "Non well-formed number" fix by GL700Wing, as discussed here.



@GL700Wing:  Whoops!  I completely forgot about that fix when I released the last version!  It's been included for this version, though!  Thanks!
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline GL700Wing

  • Jr. Member
  • **
  • Posts: 291
  • Gender: Female
Re: Automatic Attachment Rotation
« Reply #124 on: February 18, 2018, 10:53:42 PM »
I installed this mod and discovered that, as per this post, images didn't rotate as expected - in fact 'Rotate 90o Clockwise' and 'Rotate 270o Clockwise' both had the opposite effect to what I expected.  In addition, I thought some of the 'action' descriptions (eg, 'Rotate 270o Clockwise' ) could be made clearer (eg, 'Rotate 90o Left').

So - I've made the following minor changes on my forum.

I changed the text strings in ./Themes/default/languages/AutoRotation.english.php as follows:
Code: [Select]
$txt['img_orientation'] = 'Rotate/Flip';
$txt['img_orientation1'] = 'No Change';
$txt['img_orientation2'] = 'Horizontal Flip';
$txt['img_orientation3'] = 'Rotate 180°';
$txt['img_orientation4'] = 'Vertical Flip';
$txt['img_orientation5'] = 'Vertical Flip, Rotate 90° Right';
$txt['img_orientation6'] = 'Rotate 90° Right';
$txt['img_orientation7'] = 'Horizontal Flip, Rotate 90° Right';
$txt['img_orientation8'] = 'Rotate 90° Left';
$txt['img_rotate'] = 'Rotate/Flip Images';

And I've changed the drop-down menu selection order in ./Sources/ManageAttachments.php and ./Themes/default/Post.template.php to:
Code: [Select]
<option value="0">' . $txt['img_orientation1'] . '</option><option value="6">' . $txt['img_orientation6'] . '</option><option value="8">' . $txt['img_orientation8'] . '</option><option value="3">' . $txt['img_orientation3'] . '</option><option value="2">' . $txt['img_orientation2'] . '</option><option value="4">' . $txt['img_orientation4'] . '</option><option value="7">' . $txt['img_orientation7'] . '</option><option value="5">' . $txt['img_orientation5'] . '</option>
« Last Edit: February 18, 2018, 11:05:01 PM by GL700Wing »

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,563
  • Mod King
    • XPtsp.com Community
Re: Automatic Attachment Rotation
« Reply #125 on: February 20, 2018, 07:36:30 PM »
@Rock Lee:  Can you translate these strings properly for this new version?  Thanks!
Code: [Select]
$txt['img_orientation'] = 'Rotate/Flip';
$txt['img_orientation1'] = 'No Change';
$txt['img_orientation2'] = 'Horizontal Flip';
$txt['img_orientation3'] = 'Rotate 180&deg;';
$txt['img_orientation4'] = 'Vertical Flip';
$txt['img_orientation5'] = 'Vertical Flip, Rotate 90&deg; Right';
$txt['img_orientation6'] = 'Rotate 90&deg; Right';
$txt['img_orientation7'] = 'Horizontal Flip, Rotate 90&deg; Right';
$txt['img_orientation8'] = 'Rotate 90&deg; Left';
$txt['img_rotate'] = 'Rotate/Flip Images';

@GL700Wing:  I'm implementing the changes you suggested.  Once Rock Lee gives me the translations, I'll publish the new version!
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Online Rock Lee

  • Sophist Member
  • *****
  • Posts: 1,312
  • Gender: Male
  • Digitalizando un nuevo mundo :D
    • BomberCode.Oficial on Facebook
    • RockLee-BC on GitHub
    • @Bomber_Code on Twitter
    • Bomber Code ~ La nueva era del conocimiento
Re: Automatic Attachment Rotation
« Reply #126 on: February 20, 2018, 08:04:11 PM »
No problem, here they are translated 8)

Code: [Select]
$txt['img_orientation'] = 'Girar / Voltear';
$txt['img_orientation1'] = 'Ning&uacute;n cambio';
$txt['img_orientation2'] = 'Flip horizontal';
$txt['img_orientation3'] = 'Girar 180&deg;';
$txt['img_orientation4'] = 'Vertical Flip';
$txt['img_orientation5'] = 'Vertical Flip, Girar 90&deg; Derecha';
$txt['img_orientation6'] = 'Girar 90&deg; Derecha';
$txt['img_orientation7'] = 'Flip horizontal, Girar 90&deg; Derecha';
$txt['img_orientation8'] = 'Girar 90&deg; Izquierda';
$txt['img_rotate'] = 'Girar / Voltear im&aacute;genes';

Whatever you need, call me...


Regards!
¡Regresando como cual Fenix! ~ Bomber Code © 2018
Ayudas - Aportes - Tutoriales - Y mucho mas!!!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,563
  • Mod King
    • XPtsp.com Community
Re: Automatic Attachment Rotation
« Reply #127 on: February 20, 2018, 10:15:39 PM »
Uploaded v3.11 - February 20th, 2018
o Updated Spanish Latin translations, courtsey of Rock Lee.
o Changed rotation/flip strings for better understandability, per GL700Wing's post above.
o Changed order of rotation/flip strings in templates, per GL700Wing's post above.



@Rock Lee and @GL700Wing:  Thank you both for your contributions!  They are appreciated, since lately I can't seem to get my sh#t together well enough....  Plus I'm sick with a damn sinus infection from hell!   UGH!!!
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline GL700Wing

  • Jr. Member
  • **
  • Posts: 291
  • Gender: Female
Re: Automatic Attachment Rotation
« Reply #128 on: February 20, 2018, 10:29:14 PM »
You're welcome - hope you're feeling better soon.

Offline @rjen

  • Jr. Member
  • **
  • Posts: 191
  • Gender: Male
    • FJR-club Nederland
Re: Automatic Attachment Rotation
« Reply #129 on: February 21, 2018, 05:13:32 PM »
I installed this mod and discovered that, as per this post, images didn't rotate as expected - in fact 'Rotate 90o Clockwise' and 'Rotate 270o Clockwise' both had the opposite effect to what I expected.  In addition, I thought some of the 'action' descriptions (eg, 'Rotate 270o Clockwise' ) could be made clearer (eg, 'Rotate 90o Left').

So - I've made the following minor changes on my forum.

I changed the text strings in ./Themes/default/languages/AutoRotation.english.php as follows:
Code: [Select]
$txt['img_orientation'] = 'Rotate/Flip';
$txt['img_orientation1'] = 'No Change';
$txt['img_orientation2'] = 'Horizontal Flip';
$txt['img_orientation3'] = 'Rotate 180&deg;';
$txt['img_orientation4'] = 'Vertical Flip';
$txt['img_orientation5'] = 'Vertical Flip, Rotate 90&deg; Right';
$txt['img_orientation6'] = 'Rotate 90&deg; Right';
$txt['img_orientation7'] = 'Horizontal Flip, Rotate 90&deg; Right';
$txt['img_orientation8'] = 'Rotate 90&deg; Left';
$txt['img_rotate'] = 'Rotate/Flip Images';

And I've changed the drop-down menu selection order in ./Sources/ManageAttachments.php and ./Themes/default/Post.template.php to:
Code: [Select]
<option value="0">' . $txt['img_orientation1'] . '</option><option value="6">' . $txt['img_orientation6'] . '</option><option value="8">' . $txt['img_orientation8'] . '</option><option value="3">' . $txt['img_orientation3'] . '</option><option value="2">' . $txt['img_orientation2'] . '</option><option value="4">' . $txt['img_orientation4'] . '</option><option value="7">' . $txt['img_orientation7'] . '</option><option value="5">' . $txt['img_orientation5'] . '</option>

Nice to see that you picked up my request. I made these changes as well, but got not reply on the question. Thought it was forgotten...
Running SMF 2.0 with Tinyportal 1.4R at www.fjr-club.nl
Testing SMF 2.1 beta 3 with Tinyportal 2.0 at http://test2.fjr-club.nl/

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,563
  • Mod King
    • XPtsp.com Community
Re: Automatic Attachment Rotation
« Reply #130 on: February 21, 2018, 07:52:48 PM »
Sorry about that, @rjen!  I really didn't know how to fix it....
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline @rjen

  • Jr. Member
  • **
  • Posts: 191
  • Gender: Male
    • FJR-club Nederland
Re: Automatic Attachment Rotation
« Reply #131 on: February 22, 2018, 04:14:09 AM »
Tested, and looking good.

In the explanation you may also want to update the option descriptions?

It still reads:

Quote
Manual Rotation Options
o No Change
o Horizontal Flip
o Rotate 180 degrees
o Vertical Flip
o Vertical Flip, Rotate 270 degrees clockwise. (90 degrees counter-clockwise)
o Rotate 270 degrees clockwise. (90 degrees counter-clockwise)
o Horizontal Flip, Rotate 270 degrees clockwise. (90 degrees counter-clockwise)
o Rotate 90 degrees clockwise.

May be changed to:

o No Change
o Rotate 90 degrees Right
o Rotate 90 degrees Left.
o Rotate 180 degrees
o Horizontal Flip
o Vertical Flip
o Horizontal Flip, Rotate 90 degrees Right
o Vertical Flip, Rotate 90 degrees Right

Find attached the language file for Dutch..
Running SMF 2.0 with Tinyportal 1.4R at www.fjr-club.nl
Testing SMF 2.1 beta 3 with Tinyportal 2.0 at http://test2.fjr-club.nl/

Offline GL700Wing

  • Jr. Member
  • **
  • Posts: 291
  • Gender: Female
Re: Automatic Attachment Rotation
« Reply #132 on: February 22, 2018, 04:26:48 AM »
May be changed to:

o No Change
o Rotate 90 degrees Right
o Rotate 90 degrees Left.
o Rotate 180 degrees
o Horizontal Flip
o Vertical Flip
o Horizontal Flip, Rotate 90 degrees Right
o Vertical Flip, Rotate 90 degrees Right

It may even be possible to use the 'degrees' symbol ...
o No Change
o Rotate 90° Right
o Rotate 90° Left
o Rotate 180°
o Horizontal Flip
o Vertical Flip
o Horizontal Flip, Rotate 90° Right
o Vertical Flip, Rotate 90° Right

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,563
  • Mod King
    • XPtsp.com Community
Re: Automatic Attachment Rotation
« Reply #133 on: February 22, 2018, 09:41:51 AM »
Uploaded v3.12 - February 22nd, 2018
o Added Dutch translation, courtsey of @rjen!
o 2nd attempt: Changed order of rotation/flip strings in templates, per GL700Wing's post above.
o Changed documentation to reflect new order of manual rotation options.



@rjen:  Thank you for the translation!  It's been included in this version!  I've also "reeditted" the install XML files so that the option-order changes are present, cause I'm not sure if they got into the last version....

EDIT:  I finally saw what you were talking about: it's in the documentation....  It's been fixed!  Thanks!
« Last Edit: February 22, 2018, 10:26:50 AM by dougiefresh »
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!