Advertisement:

Author Topic: [2.0.11] Guest shown reply button but on click denied (login required)  (Read 5354 times)

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
I had problems working out how board and member permissions were applied together - does not seem simple   ::)

Anyway. under General Member Permissions (stated only applies to Default Profile anyway) they do not have permission to reply.

Our Contact Us board uses board permission profile Guest Posting. On clicking the Guest Posting profile permissions and looking at Guest, they have the permission to post new topics and reply (both need approval).

You can see on the screenshots, a guest is shown the reply button but cannot reply - redirects to the login screen.

I see this as a bug, it shouldn't show the reply button if the guest permissions have been checked.


Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,268
  • Gender: Male
    • Kindred-999 on GitHub
hrmmmmm....
So, this MIGHT be a bug...  but it's not the bug that you note...

The reply button is CORRECTLY shown, given your permissions settings.
(you have the guests allowed to post replies)

the bug would seem to be that the system doesn't actually allow replies without login, even if the guest reply (but only after approval) permission is set.

note: after testing...   if the allow guests to reply (not requiring approval) is set, then the posting works.... it is ONLY the allow guest reply (but require approval) permissions that appears to glitch things
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
Quote
So, this MIGHT be a bug...  but it's not the bug that you note...

The reply button is CORRECTLY shown, given your permissions settings.
(you have the guests allowed to post replies)
the bug would seem to be that the system doesn't actually allow replies without login, even if the guest reply (but only after approval) permission is set.

Please dont try and sweep it under the carpet or pretend it isnt  the bug it is. Its a bug as guests do not need to login to post under those settings.

I do not know why you always try and do this kind of thing. People like me are trying to help out as well - you might consider that. Most of your replies about bugs are to deflect SMF responsibility. It is incredibly annoying. You can look through my posts as I have correctly reported several bugs I think. I remmber you denying it was a bug more than once - proved wrong (2005 subscriptions WRONG capitalized currency BUG).

Offline Suki

  • Kaizoku Jotei
  • Developer
  • SMF Super Hero
  • *
  • Posts: 15,446
  • Oh, wouldn't it be great if I *was* crazy?
    • MissAllSunday on GitHub
    • SMF mods
Can we please leave any personal feelings aside and concentrate only on the report, thanks.


Thank you for your report, will investigate this further.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Look at them. They're just asking for it. Maybe the human race deserves to be wiped out.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,268
  • Gender: Male
    • Kindred-999 on GitHub
wait...   how did I try to seep anything under the rug or deny anything?

I think that you need to re-read what I typed.

the bug would seem to be that the system doesn't actually allow replies without login, even if the guest reply (but only after approval) permission is set.

I noted that there DOES seem to be an improper activity... but it was NOT what you described.

You said:
it shouldn't show the reply button if the guest permissions have been checked

that is incorrect.
Per the permission setting, it ***SHOULD*** show the reply button.

What it should not do is require a login when the guest tries to make a reply.

I also confirmed that it does NOT require a login and correctly posts if the permission is set to "allow reply" (without requiring approval)
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
Stick too your special way or support - your the grand master of denial and winding people up who spend time trying to help and fix things - I will no longer report any problems - better to keep my mouth shut than go through this every time.


I moved to SMF from phpBB but I never experienced support like this over there - its unbelievable. Maybe its time I left SMF?

Offline Suki

  • Kaizoku Jotei
  • Developer
  • SMF Super Hero
  • *
  • Posts: 15,446
  • Oh, wouldn't it be great if I *was* crazy?
    • MissAllSunday on GitHub
    • SMF mods
@igirisjin   It seems you missed my post so here it is again.

Thank you for your report. Will take a closer look at it.  Can we please left any personal grudges aside and solely concentrate on the report? it makes life soo much easier for everyone thanks.

Rest assure your reports won't be neglected/avoided/denied etc but bear in mind that we need to actually confirm any bug report  and please don't feel offended or take it too personal if the results are not what you are expecting it to be.

Thank you again for your report.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Look at them. They're just asking for it. Maybe the human race deserves to be wiped out.

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
Well you know who always strikes first blood in this forum... I guess he at least guarantees to get a reply and keep the post count high.

I spent 2 years saying there was a subscriptions bug - it was finally proved (there are several including mine).

Thanks to (name changed) 'Sir Osis of Liver' for the best support you could expect.

To be honest that is an important part of a forum I need. Also I enjoy helping over at Simple Portal - another great place people here and get tips on how to provide support.
Other than those points I wonder why I stay.

Offline Suki

  • Kaizoku Jotei
  • Developer
  • SMF Super Hero
  • *
  • Posts: 15,446
  • Oh, wouldn't it be great if I *was* crazy?
    • MissAllSunday on GitHub
    • SMF mods
Let us concentrate on the bug report shall we?

Can you share your board permissions for your Contact Us board. This way I can set up a test forum to test and replicate this report. Thanks.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Look at them. They're just asking for it. Maybe the human race deserves to be wiped out.

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
I have since change the board permission profile to Access Open Forum - that works as it is supposed to (post replies with or without moderation) without being redirected to login.


Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
Re: [2.0.11] Guest shown reply button but on click denied (login required)
« Reply #10 on: March 08, 2016, 12:54:07 AM »
That didn't last long...

Editing permission from a board alters the profile - does not work on a per board basis. So in another board now guests can post where they shouldn't be able to.

The (contact us) board is now temporarily set back to guest posting profile with:

Post new topics, but hide until approved    (enabled)
Post replies to topics, but hide until approved    (enabled)
Post replies to topics, without requiring approval (disabled)


You can see for yourself as a guest if you try to reply to a topic there you are redirected to login.

http://outdoorclubjapan.com/index.php?board=41.0



It seems to be happening with older topics.
A new test post allowed a moderated reply.


But it worked on the sticky topic.

« Last Edit: March 08, 2016, 01:12:32 AM by igirisjin »

Offline Dav999

  • Jr. Member
  • **
  • Posts: 199
  • Gender: Male
Re: [2.0.11] Guest shown reply button but on click denied (login required)
« Reply #11 on: March 10, 2016, 02:34:08 PM »
Can reproduce: if guests are allowed to post requiring approval, then they can't reply to topics that were started by guests. (even though it shows the reply button)

There's a permission for registered members to allow them to reply to their own topics and a separate one for them to reply to all topics, and the former permission does not exist for guests. Somehow that results in guests not being able to reply to their "own" topics (same user ID, 0).

Relevant code from Post.php:
Code: [Select]
// By default the reply will be approved...
$context['becomes_approved'] = true;
if ($id_member_poster != $user_info['id'])
{
if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
$context['becomes_approved'] = false;
else
isAllowedTo('post_reply_any');
}
elseif (!allowedTo('post_reply_any'))
{
if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own'))
$context['becomes_approved'] = false;
else
isAllowedTo('post_reply_own');
}
Code: [Select]
// Do the permissions and approval stuff...
$becomesApproved = true;
if ($topic_info['id_member_started'] != $user_info['id'])
{
if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
$becomesApproved = false;
else
isAllowedTo('post_reply_any');
}
elseif (!allowedTo('post_reply_any'))
{
if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own'))
$becomesApproved = false;
else
isAllowedTo('post_reply_own');
}

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,268
  • Gender: Male
    • Kindred-999 on GitHub
Re: [2.0.11] Guest shown reply button but on click denied (login required)
« Reply #12 on: March 10, 2016, 04:34:06 PM »
Yep, that seems to match what I tested as well...  Good catch in the code.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
Re: [2.0.11] Guest shown reply button but on click denied (login required)
« Reply #13 on: March 10, 2016, 11:10:40 PM »

Quote
There's a permission for registered members to allow them to reply to their own topics and a separate one for them to reply to all topics, and the former permission does not exist for guests. Somehow that results in guests not being able to reply to their "own" topics (same user ID, 0).
That matches the cases I had.



And guess what I found in fixed or bogus bugs!

http://www.simplemachines.org/community/index.php?topic=472533.0

Hope it gets sorted this time around.
« Last Edit: March 10, 2016, 11:21:54 PM by igirisjin »

Offline Irisado

  • A Light in the Darkness
  • Doc Coordinator
  • SMF Super Hero
  • *
  • Posts: 10,018
  • Soñando debajo del arco iris
Soñando con una playa donde brilla el sol, un arco iris ilumina el cielo, y el mar espejea iridescentemente

Offline OCJ

  • Full Member
  • ***
  • Posts: 493
  • Gender: Male
Re: [2.0.11] Guest shown reply button but on click denied (login required)
« Reply #15 on: March 11, 2016, 10:50:40 AM »
 :P  4 years discussion and its still 'kind of ' open over there. They should got Mulder and Scully to take a look at it.

Your signature quote says it all ..

Quote
we dont yet have the mind reading mod installed.



Its certainly not a thing any admin or moderator would like to try and explain to guests visiting a forum that there's a 4 year old known bug in the forum software stopping them from replying. The plus point I guess is they can't reply to that eh.LOL
« Last Edit: March 11, 2016, 11:49:10 AM by igirisjin »