Advertisement:

Author Topic: [2.0.12] Cannot post tables in messages anymore due to [h r] in table  (Read 17039 times)

Offline NekoSensei

  • Semi-Newbie
  • *
  • Posts: 50
  • Gender: Male
  • SMF User
    • Le Pays Du Manga et des Cartoons oubliés
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #40 on: November 11, 2016, 05:11:19 PM »
I have to uninstall the patch 2.0.12 because of the same error, I can not edit my old posts on the forum and create new... it's a shame, I'm waiting for the patch of this patch :)

Offline SMiFFER

  • Jr. Member
  • **
  • Posts: 222
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #41 on: November 12, 2016, 11:55:50 PM »
True. And I wonder what takes so long to release a fix for this - this bug has been reported 2 months ago.

If some certain heroes would invest the time they put into cheeky and snarky remarks rather into this fix, it would long be done.
...coming from VB, using SMF since 2012, now hosting it myself
currently 2.0.15

Offline Illori

  • Project Manager
  • SMF Master
  • *
  • Posts: 48,049
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #42 on: November 13, 2016, 06:09:21 AM »
this fix is not as easy as some may think it is. when it is confirmed that it has been fixed and fixed correctly the team will release the next patch. do remember not everyone on the team works on making the patches, we all have our own tasks and abilities.

Offline whoey

  • Semi-Newbie
  • *
  • Posts: 37
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #43 on: November 20, 2016, 07:35:15 AM »
found this thread as pointed out by oddguy here: http://www.simplemachines.org/community/index.php?topic=548926

This also applies to multilevel nested quotes.

Offline SMiFFER

  • Jr. Member
  • **
  • Posts: 222
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #44 on: November 20, 2016, 12:14:44 PM »
I have to uninstall the patch 2.0.12 because of the same error, I can not edit my old posts on the forum and create new... it's a shame, I'm waiting for the patch of this patch :)
Full ACK!
This is the most nerve-cutting thing with this bug: It used to work before and existing posts cannot be changed unless you work through every detail (which was NOT (!) needed prior to 2.0.12)

When is the fix coming? Any date known yet?
...coming from VB, using SMF since 2012, now hosting it myself
currently 2.0.15

Offline d3vcho(void)

  • Localizer
  • SMF Hero
  • *
  • Posts: 2,241
  • Gender: Male
  • Be prepared for hell
    • d3vcho on GitHub
    • @SMF_ES on Twitter
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #45 on: November 20, 2016, 12:51:35 PM »
Hello!

Soon, we all hope, but we don't have any official information yet. According to this post, 2.0.13 is currently being tested.

Regards :)

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 55,098
  • Gender: Male
    • Kindred-999 on GitHub
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #46 on: November 20, 2016, 04:29:32 PM »
and you should know that we NEVER promise dates.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline adroth92

  • Newbie
  • *
  • Posts: 4
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #47 on: November 21, 2016, 01:51:20 PM »
Sorry if this should be posted elsewhere, but is anyone aware of any problems with downgrading to 2.0.11 while waiting for this update?

Offline d3vcho(void)

  • Localizer
  • SMF Hero
  • *
  • Posts: 2,241
  • Gender: Male
  • Be prepared for hell
    • d3vcho on GitHub
    • @SMF_ES on Twitter
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #48 on: November 21, 2016, 01:52:38 PM »
There shouldn't be any problems. Just in case, before downgrading, make a backup of your whole forum.

Regards :)

Offline SMiFFER

  • Jr. Member
  • **
  • Posts: 222
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #49 on: November 24, 2016, 03:03:07 PM »
Hello!

Soon, we all hope, but we don't have any official information yet. According to this post, 2.0.13 is currently being tested.

Regards :)

Nice!
Now let them work...
...coming from VB, using SMF since 2012, now hosting it myself
currently 2.0.15

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #50 on: December 06, 2016, 03:30:05 PM »
This bug does NOT occur inside [nobbc] tags.  So it's definitely somewhere in the BBCode functions.

[table]
[tr]
[td][quote][/quote][/td]
[/tr]
[/table]
[table]
[tr]
[td][b][/b][/td]
[/tr]
[/table]

Testing if it's just the open tag...

[table]
[tr]
[td][b]recreated format with just the open tag[/td]
[/tr]
[/table]

So if you only have an open tag in the second table, the second table survives, but not the first.

Testing with only open tags in both tables...
[table]
[tr]
[td][quote][/td]
[/tr]
[/table]
[table]
[tr]
[td][b][/td]
[/tr]
[/table]

Well, three tables with only open tags makes it yell at me.

Two open tags only also breaks it.

Testing mismatched open/close...


[table]
[tr]
[td][quote][/quote][/td]
[/tr]
[/table]
[table]
[tr]
[td][b][i][/b][/td]
[/tr]
[/table]
It preserves the second table but eats the first again.

Testing double mismatching...
[table]
[tr]
[td][quote][b][/quote][/td]
[/tr]
[/table]
[table]
[tr]
[td][b][i][/b][/td]
[/tr]
[/table]
Doesn't work.
« Last Edit: December 06, 2016, 03:59:42 PM by TheBiggerFish »

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #51 on: December 06, 2016, 04:16:22 PM »
So the problem is this:
With the latest patch you guys added the following code to the Subs-Post.php file:

Code: [Select]
// Remove empty bbc.
$message = preg_replace('~\[([^\]=\s]+)[^\]]*\](?' . '>\s|(?R))*?\[/\1\]\s?~i', '', $message);

My preg knowledge is not enough to know what exactly this does but it is creating problems for us.

If a user uses too many BBC codes or something the whole message gets truncated into nothing and they get an error that the message body is empty, also when clicking Preview, the preview would be empty.

For my forum I just commented out this whole line and it solved our problems.
Any idea what is going on?

Here is a test code to reproduce it:
http: // paste . ubuntu . com/23415521/
(remove spaces)

I tried adding the above code in a CODE bracket on this forum but it gave me the same error:

yes... we know (did you read the whole thread?).
We are working on a fix.
...Is this removing BBCode from the post itself?  Why is it even doing that...?

E: ...carp.  Sorry about doubleposting (please don't hurt me)

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #52 on: December 07, 2016, 12:31:14 AM »
Well the edit button disappeared, that is a thing and it is very annoying.

Found another breaking expression:
[color=lightblue][i][Any text in brackets]   [/i][/color]

It leaves behind the open tags up to italics, and the closing color tag.

Offline neogodless

  • Newbie
  • *
  • Posts: 1
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #53 on: December 08, 2016, 09:14:11 AM »
Table 1
Row 1
Row 2
Table 2
Row 1

Hmm, what version is THIS forum running on? The following code does not work on our forum:

[table][tr][td][right][b]Table 1[/b][/right][/td][/tr][tr][td]Row 1[/td][/tr][tr][td][right][b]Row 2[/b][/right][/td][/tr][/table]
[table][tr][td][right][b]Table 2[/b][/right][/td][/tr][tr][td]Row 1[/td][/tr][/table]


The key seems to be [b] tags on subsequent rows (you can have them in the first row), and having a second table tag. But note that there are no open tags!

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #54 on: December 08, 2016, 12:51:19 PM »
This forum?  It's running 2.0.12.

Yours should say if you scroll down to the bottom of the page, and there are apparently admin tools to check your version if you doubt that.

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #55 on: December 17, 2016, 04:24:41 AM »
Got another one:

[quote]
[quote]
[any text]
[/quote]
[/quote]
[any text]

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #56 on: December 20, 2016, 03:36:27 PM »
*I would edit to clarify but cannot: The brackets around [any text] are actually there in the post.

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,646
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #57 on: December 20, 2016, 03:38:28 PM »
You should attach the problematic BBC combination as txt file here. We already have a patch on testing lane so we can run your combination and return the result.
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]

Offline TheBiggerFish

  • Semi-Newbie
  • *
  • Posts: 16
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #58 on: December 29, 2016, 05:34:13 PM »
Apparently

[quote][/quote]
bugs out too.

It eats up to one trailing linebreak, judging from posting it here.  (Someone else ran across the bug, I'm just crossposting.)

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 55,098
  • Gender: Male
    • Kindred-999 on GitHub
Re: [2.0.12] Cannot post tables in messages anymore due to [h r] in table
« Reply #59 on: December 29, 2016, 07:07:47 PM »
and empty quote is invalid anyway
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.