Broken links inserted with HTTP/HTTPS in uppercase

Started by radu81, December 12, 2016, 08:50:12 AM

Previous topic - Next topic

radu81

Links inserted with HTTP/HTTPS/Http in uppercase are broken on SMF

TEST

this is working fine
https://www.google.it
https://www.google.it


this not
Https://www.google.it
Https://www.google.it


and also this is not working
HTTP://www.google.it
HTTP://www.google.it
sorry for my bad english

Kindred

that's not technically a bug...   that is a bad insert.

uppsercase for http or https is never valid and so should never be used in the first place.
The reason that the http is inserted in front of it is for the same reason.
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

radu81

I found it by checking broken links on my website, I understand that http/https should not be inserted in uppercase, but it not depends on me, but on users of my/our forums ;)
sorry for my bad english

Kindred

yeah. I see your point...

I am opposed, in general, to using code to fix user mistakes... but I am often overruled by the devs - and since they do the work, I'm not going to argue with them about it. :)
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

nend

I think it could use a strtolower, shouldn't be too hard to implement, not in the next patch though.

live627

Someone should try it on the latest dev snapshot since the code was changed.

Kindred

Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."


Kindred

Hmmm.. haven't tried, but I do have a 2.1 beta 3 installation...


And it seems to work correctly
https://test2.turtleshellprod.com/index.php?topic=5
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

live627


Kindred

first post is

HTTP://www.simplemachines.org

HTtp://www.simplemachines.org

Http://www.simplemachines.org

Https://www.simplemachines.org


second post uses URL

[url="HTTP://www.simplemachines.org"]Simple Machines[/url]

[url="HTtp://www.simplemachines.org"]Simple Machines[/url]

[url="Http://www.simplemachines.org"]Simple Machines[/url]

[url="Https://www.simplemachines.org"]Simple Machines[/url]
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

shawnb61

If it really is a problem, as a short term solution, using censored words works.   Eg., to translate HTTPS to https
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Advertisement: