Advertisement:

Author Topic: Play Media Attachments  (Read 18739 times)

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,741
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #120 on: April 29, 2018, 05:10:55 AM »
Uploaded v2.4 - April 28th, 2018
o Added mime detection for QuickTime (.mov) movies.
o Added code fragment to exclude mime type from HTML when playing QT movies.
o Fixed conditional statement so that video embed tag works if needed.



@Everybody:  A request was made via PM to see if I could support mov (QuickTime movie) files.  I managed to get the mod to do so.  WORD OF WARNING:  I do not know if any browser plugins may be required for the video file to work properly...

Offline Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #121 on: April 29, 2018, 11:38:31 PM »
Thank you! I can confirm that it works with .mov files.

An issue I'm having is that the videos(mp4, mov) don't play when I visit the forum through my phone. I'm using an iPhone 8 plus.

Offline Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #122 on: May 02, 2018, 09:06:02 PM »
I've noticed that the videos don't play on mobile because it's linking to the attachment url instead of the actual file. Is there a way to fix this?

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,741
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #123 on: May 03, 2018, 09:55:46 AM »
I'm looking into this....

Offline Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #124 on: May 03, 2018, 09:44:12 PM »
Thank you for all your hard work.

Offline Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #125 on: May 22, 2018, 01:27:10 AM »
Any progress?

Offline Steve

  • Freak
  • Support Specialist
  • SMF Hero
  • *
  • Posts: 4,394
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Play Media Attachments
« Reply #126 on: May 25, 2018, 08:33:19 AM »
I have been trying to rest the last two weeks or so, as I have gotten exhausted trying to keep up with everything....
Online Manual

Please do not PM me for support.

Offline aegersz

  • SMF Hero
  • ******
  • Posts: 1,444
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #127 on: July 21, 2018, 12:38:45 PM »
MINOR bug fix for 8: Undefined index: PMAt_no_audio

find:
Code: [Select]
, $txt['PMAt_no_audio'], '
change:
Code: [Select]
, $txt('PMAt_no_audio'), '
                                                                                       
repeat this for the video code also
The configuration of my Linux VPS (SMF 2.0 with 140+ mods) can be found here and notes on my mods can be found here (warning: those links will take you to a drug related forum)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,279
    • StoryBB/StoryBB on GitHub
Re: Play Media Attachments
« Reply #128 on: July 21, 2018, 12:43:07 PM »
Um... no, that's a REALLY bad idea.

Changing out the [] for () means trying to treat it as a function, and $txt isn't a function and doesn't contain a callable.

Better suggestion: actually define the language string in Modifications.english.php...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline aegersz

  • SMF Hero
  • ******
  • Posts: 1,444
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #129 on: July 21, 2018, 02:14:56 PM »
Ok, thanks - i assumed it was a function inserting a text sting ... so i decided to change it to:

Code: [Select]
', 'PMAt_no_audio' , 'and
Code: [Select]
', 'PMAt_no_video' , '
seems to work; FYI, the HTML <audio> and <video> tags are used like this:

Code: [Select]
<audio controls>
  <source src="horse.ogg" type="audio/ogg">
  Your browser does not support the audio tag.
</audio>

i am not sure what Modifications.english.php does yet ...
The configuration of my Linux VPS (SMF 2.0 with 140+ mods) can be found here and notes on my mods can be found here (warning: those links will take you to a drug related forum)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,279
    • StoryBB/StoryBB on GitHub
Re: Play Media Attachments
« Reply #130 on: July 21, 2018, 02:19:13 PM »
Um. Modifications.english.php is the home of all the language strings given by mods...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline aegersz

  • SMF Hero
  • ******
  • Posts: 1,444
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #131 on: July 21, 2018, 02:22:53 PM »
thank you ...
The configuration of my Linux VPS (SMF 2.0 with 140+ mods) can be found here and notes on my mods can be found here (warning: those links will take you to a drug related forum)

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,741
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #132 on: August 16, 2018, 10:41:09 PM »
MINOR bug fix for 8: Undefined index: PMAt_no_audio

find:
Code: [Select]
, $txt['PMAt_no_audio'], '
change:
Code: [Select]
, $txt('PMAt_no_audio'), '
                                                                                       
repeat this for the video code also
I couldn't find any reference to PMAt_no_audio within any of the mod files.  Are you running the latest version?

Offline aegersz

  • SMF Hero
  • ******
  • Posts: 1,444
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #133 on: August 18, 2018, 07:47:08 PM »
i don't believe so but i was sure that it must've been in your code.

will do some digging when i recover from my huge night out.

thanks ... it's only a harmless little thing anyway.
The configuration of my Linux VPS (SMF 2.0 with 140+ mods) can be found here and notes on my mods can be found here (warning: those links will take you to a drug related forum)

Offline engrz

  • Full Member
  • ***
  • Posts: 545
  • Gender: Male
  • Engineering and IT Discussion Forum
    • www.facebook.com/engrzpakistan on Facebook
    • @engrz on Twitter
    • Engineering Forum
Re: Play Media Attachments
« Reply #134 on: October 15, 2018, 02:57:24 AM »
how to manually install this mod on any other theme than default? also is it compatible on mobile theme?

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,741
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #135 on: October 15, 2018, 12:04:07 PM »
how to manually install this mod on any other theme than default? also is it compatible on mobile theme?
In order to manually install the mod on any other theme than the default theme, you would have to find where the appropriate place to insert the code.  Naturally, if the theme doesn't support attachments, then no, it is not compatible with that theme.  I would think it'd be compatible with mobile themes, but only actual use would reveal that little detail....

Offline engrz

  • Full Member
  • ***
  • Posts: 545
  • Gender: Male
  • Engineering and IT Discussion Forum
    • www.facebook.com/engrzpakistan on Facebook
    • @engrz on Twitter
    • Engineering Forum
Re: Play Media Attachments
« Reply #136 on: Yesterday at 12:19:11 AM »
how to manually install this mod on any other theme than default? also is it compatible on mobile theme?
In order to manually install the mod on any other theme than the default theme, you would have to find where the appropriate place to insert the code.  Naturally, if the theme doesn't support attachments, then no, it is not compatible with that theme.  I would think it'd be compatible with mobile themes, but only actual use would reveal that little detail....

My theme supports attachments (https://www.engrz.org) but not support this mod to show player as attachment. if you can guide me where to place code for this mod to appear, i will be thankful to you.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,741
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #137 on: Yesterday at 08:48:29 PM »
Without knowing the name of the theme you are using (or if it is a complete or paid theme), it would be impossible for me to advise you on how to manually install the mod on your forum.  if it is a paid mod, I will probably need access to your form in order to either make change myself or advise on how to make changes.  if this is just a customized mod, I would need to know which one it is based on before I could advise.