News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

[2.0.13] smf_db_create_table no $column_info

Started by vbgamer45, February 03, 2017, 12:02:40 AM

Previous topic - Next topic

vbgamer45

function smf_db_create_table($table_name, $columns, $indexes = array(), $parameters = array(), $if_exists = 'ignore', $error = 'fatal')

This line changed to

$unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint')) && !empty($column['unsigned']) ? 'unsigned ' : '';

To

$unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint', 'float')) && !empty($column_info['unsigned']) ? 'unsigned ' : '';

Issue there is no $column_info

It was done in some other spots but it makes sense in those spots
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

live627

Can you check if this issue is also in 2.1? I'm not in a coding mood right now... (burnout yet again)

vbgamer45

Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

albertlast

I would like to comment this part in general:

In my eyes you should forget that unsigned exists,
from sql standard pov is garbage.

And i know "mysql can it" and "smf use it" but both is wrong.

the api of smf is designed to work with all supported databases.
In smf 2.1 is it mysql and pg,
and you run in trouble when the min and max value in both database is different.

Advertisement: