SMTP EHLO/HELO command wrong parameter

[digger]

Why EHLO/HELO command send $modSettings['smtp_host'] instead of the forum hostname (see RFC-5321)? I see a comment about this in the code (SMF 2.0.13) but it's still not fixed.


Subs-Post.php

Code Select Expand

if ($modSettings['mail_type'] == 1 && $modSettings['smtp_username'] != '' && $modSettings['smtp_password'] != '')
{
// !!! These should send the CURRENT server's name, not the mail server's!

// EHLO could be understood to mean encrypted hello...
if (server_parse('EHLO ' . $modSettings['smtp_host'], $socket, null) == '250')
{
if (!server_parse('AUTH LOGIN', $socket, '334'))
return false;
// Send the username and password, encoded.
if (!server_parse(base64_encode($modSettings['smtp_username']), $socket, '334'))
return false;
// The password is already encoded ;)
if (!server_parse($modSettings['smtp_password'], $socket, '235'))
return false;
}
elseif (!server_parse('HELO ' . $modSettings['smtp_host'], $socket, '250'))
return false;
}

[digger]

What's up, doc?

[Fisch.666]

Looks like this is fixed now with SMF 2.0.16:

https://custom.simplemachines.org/upgrades/index.php?action=upgrade;file=smf_patch_2.0.16.tar.gz;smf_version=2.0.15#sources_subs-post-php_2

[shawnb61]

Thanks for the confirmation, moving to the fixed bugs board.