Topic: @mention members

[jsx]

@Dragooon

The selection does not appear in this checkbox:

Enable mentions e-mail for current members

Whereas, the selection appears correctly in this checkbox:

Enable mentions e-mail by default

[landyvlad]

For anyone wanting to explain to their forum members how this mod is used feel free to copy
http://gsx1400owners.org/forum/index.php?topic=477.0
to your hearts content.  Cheers

[grzeg8102]

Great mod! Very useful. Since I started being a user of a Discourse forum I dreamt of something similar in my my own SMF forum I'm running.

@Dragoon - I'm only missing the mod to run also on the recents page ("/index.php?action=recent"). Can you please add it? Hopefully it's nothing complex and only requires the function mentions_post_scripts(); to be called in one more place.

BTW. I'd like to share my CSS for it - it tries to mimic Discourse mention style. Attached

[Shambles]

Under PHP 7.1, when unchecking Profile > Profile Info > Mentions > E-mail mention notifications:





The (bool) cast within Mentions.php is no longer returning 0 when false; it's returning null, causing the above error.

Solution:

Sources/Mentions.php

Code: (Find) [Select]

if (!empty($_POST['save']) && $user_info['id'] == $memID)
updateMemberData($memID, array('email_mentions' => (bool) !empty($_POST['email_mentions'])));


Code: (Replace) [Select]

if (!empty($_POST['save']) && $user_info['id'] == $memID)
updateMemberData($memID, array('email_mentions' => empty($_POST['email_mentions']) ? 0 : 1));


[Arantor]

(bool) returns true or false, which would need to be explicitly cast to numbers to make that work - false, by default, implicit casts to empty string, not 0, unless explicit-casting to int.

[Shambles]

Yep - that's what was happening. Must have been different under 5.6 as that seemed to return 0?

With the change above it I now get 0 or 1 (obviously) instead of null or 1.

[Arantor]

Nope, those semantics have never changed. I’m assuming it’s just always been left ticked - unlike false, true will convert to 1 as far as the DB library cares.

[Shambles]

I wonder how many people have tried to untick it? Not me, that's for sure.

I only spotted it when doing my routine checks on the error logs.

... unlike false, true will convert to 1 ...

That implies the original code has always been imperfect, as far as setting a 0 or 1 into the int-only DB space.

[Arantor]

Yup, it very likely has.