SMF 2.0.14 -> 2.0.15 ManageServer.php replacement

[spiros]

SMF 2.0.14 -> 2.0.15 ManageServer.php replacement

In /Sources/ManageServer.php my file was different due to a spammers mod and automatic replacement was not possible, so I replaced:

Code Select Expand

if ($context['sub_action'] == 'query' && !empty($_REQUEST['params']) && (empty($_POST) || ((isset($_POST['spammers_checks']) || isset($_POST['spammers_report'])) && !empty($_POST['delete']))))
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));


with:

Code Select Expand

if ($context['sub_action'] == 'query' && empty($_POST))  || ((isset($_POST['spammers_checks']) || isset($_POST['spammers_report'])) && !empty($_POST['delete']))))
{
if (!empty($_REQUEST['params']))
{
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));
}
elseif ($context['browser']['is_ie'] && !empty($_SESSION['params']))
{
$_POST += $_SESSION['params'];
unset($_SESSION['params']);
}
}

Is this the right thing?

[Shambles]

Have a look here

https://www.simplemachines.org/community/index.php?topic=283309.msg3948505#msg3948505