new errors since 2.0.15 upgrade

[brynn]

Hi Friends,
I had quite a lot of trouble with the 2.0.15 upgrade, most of the problems covered in this long topic:  https://www.simplemachines.org/community/index.php?topic=558611.0  The short version of that long topic -- there were quite significant number of (manual) edits to Sources/PersonalMessage.php (related to uninstalling PM Attachments, many months ago - uninstall had not been complete).  And one edit to Sources/ManageMembers.php (related to Stop Spammer).

After finally finishing everything, I cleared out the Error Log, so it would be easy to see if any new errors came up.  And some did.

Now I see a few errors coming from one member.  I don't really know if this is related to the upgrade.  But I don't recall seeing this particular error message before.  All the errors refer to the same line in the same file.

https://forum.inkscapecommunity.com/index.php?
8: Undefined index: actual_theme_dir
File: /home/brynn/public_html/forum/Sources/Load.php
Line: 2126

https://forum.inkscapecommunity.com/index.php?action=profile
8: Undefined index: actual_theme_dir
File: /home/brynn/public_html/forum/Sources/Load.php
Line: 2126

https://forum.inkscapecommunity.com/index.php?action=profile;area=forumprofile;updated
8: Undefined index: actual_theme_dir
File: /home/brynn/public_html/forum/Sources/Load.php
Line: 2126

https://forum.inkscapecommunity.com/index.php?action=profile;area=forumprofile;u=1428;save
8: Undefined index: actual_theme_dir
File: /home/brynn/public_html/forum/Sources/Load.php
Line: 2126

https://forum.inkscapecommunity.com/index.php?action=profile;area=forumprofile
8: Undefined index: actual_theme_dir
File: /home/brynn/public_html/forum/Sources/Load.php
Line: 2126

https://forum.inkscapecommunity.com/index.php?action=profile;area=account;updated
8: Undefined index: actual_theme_dir
File: /home/brynn/public_html/forum/Sources/Load.php
Line: 2126

I'll attach that file (Sources/Load.php).  Looking at that line, it seems to have something to do with templates.  Or maybe languages.  (Note that I know very little about PHP - just guessing based on English definitions of the words in the code.)

Actually, it looks like this member is using our default theme (not Curve), so they didn't change the theme.  But it looks like they did change something about their profile....  Oh yes!  I added a couple of custom fields using the Advanced Profile Fields feature.  That must be what they were doing.  (They must be thinking about posting a message, or else they probably would not have filled out these 2 fields.)

But lots of members use those custom fields, and they don't give errors.  I wonder why this member did?  I suppose that error could have happened before, and I didn't notice it.....   If it had come through once or twice I could have missed it.  But I would have noticed if it happened 6 times, like here.

Anyway, I just want to make sure this isn't related to all the recent changes with the upgrade.  And whether it's related or not, is it fixable?  Let me know if you need anything else - mod list, for example?

Thank you very much!

[Aleksi "Lex" Kilpinen]

That error is one of the strangest things in SMF - I have seen it many times in different circumstances, but it is usually also very intermittent - it comes and goes, so actually diagnosing it is often difficult.
I have gathered though, that it is something related to the order in which certain language files are loaded.

I can try to dig in to this later on more, right now I'm a bit busy with other things.

I have never seen this error cause any real trouble though, apart from being a nuisance in the logs, so for now -
it's nothing too serious to worry about I'd say.

[brynn]

Aaah, ok.  In that case, I just won't worry about it.  It sounds like it's been around a while, and it sounds like it's already been well investigated, yet without success.  Definitely not related to the changes with the upgrade, which was my main concern.

I appreciate your offer to have a look at it.  But since it doesn't sound very serious, I'm happy to just let it ride for awhile.

Plenty of other projects I need to work on.  My next goal is to set up a test forum, and try to learn how to install the fresh, clean files (https://wiki.simplemachines.org/smf/How_to_upload_a_fresh_set_of_files) in case I ever have to do that someday.

And we'll just call this solved, for now   

Thank you very much!!

[Aleksi "Lex" Kilpinen]

I am actually curious about it myself, so I may come back to this at some point. ( I have seen this same error on my own forum a few times, and strangely enough always from a select few users including myself... )

[brynn]

So if it's giving the error for you, then it must be happening even for users using the default language.  When you first explained, the first thing I thought was that the user must be using a non-English language.  I wonder if I have an analytic stat which identifies the user's language....?  I'll look around.

Actually, that was 6 errors the other day.  Now we're up to 18!

To me, it seems like it must be one of the edits (or maybe more) which we made to PersonalMessage.php.  There were a couple of small edits to other files, but just like 3 characters, in one place just changing a version number.

I'll hold on to the errors for a little while....  Or else....is there a way to export a log or something?  If the Error Log starts to pile up, well, I like to keep it cleaned up, as much as possible.  If I could export a log for you, I'd be glad to.

Edit
Oh yes!  It gives the language in the member profile!  And those errors I posted above come from someone identified as using English!

Why would it matter what order the files are accessed, if they're using the default language?  There must be more to it....

Edit
And it happens to members and guests alike!  And guests can't get to PMs. 

Well, I can see this is well above my head, haha!