SMF Development > Fixed or Bogus Bugs

$smcFunc defined twice as global

(1/2) > >>

doug_ips:
Hello,

The $smcFunc var is being defined twice as global in the Register.php file.


--- Code: ---// Begin the registration process.
function Register($reg_errors = array())
{
global $txt, $boarddir, $context, $settings, $modSettings, $user_info;
global $language, $scripturl, $smcFunc, $sourcedir, $smcFunc, $cur_profile;
--- End code ---

albertlast:
In smf 2.1 this issue didn't exists,
maybe got already fixed.

d3vcho(void):
Yes, it was fixed by Arantor a long time ago for SMF 2.1 but it's still there for 2.0.x. I'll pass it to the developers.

Thank you.

Sh@mbles:
I wouldn't class this as a bug since it doesn't cause incorrect or unexpected results, or for Register.php to behave in unintended ways.

Just sayin'

d3vcho(void):
Nope it's not a bug, it's just repeated code that should be removed. But it's better to keep it here so we don't forget about it.

Navigation

[0] Message Index

[#] Next page

Go to full version