$smcFunc defined twice as global

Started by Doug Heffernan, March 04, 2018, 08:42:25 AM

Previous topic - Next topic

Doug Heffernan

Hello,

The $smcFunc var is being defined twice as global in the Register.php file.

// Begin the registration process.
function Register($reg_errors = array())
{
global $txt, $boarddir, $context, $settings, $modSettings, $user_info;
global $language, $scripturl, $smcFunc, $sourcedir, $smcFunc, $cur_profile;

albertlast

In smf 2.1 this issue didn't exists,
maybe got already fixed.

d3vcho

Yes, it was fixed by Arantor a long time ago for SMF 2.1 but it's still there for 2.0.x. I'll pass it to the developers.

Thank you.
"Greeting Death as an old friend, they departed this life as equals"

Shambles

I wouldn't class this as a bug since it doesn't cause incorrect or unexpected results, or for Register.php to behave in unintended ways.

Just sayin'

d3vcho

Nope it's not a bug, it's just repeated code that should be removed. But it's better to keep it here so we don't forget about it.
"Greeting Death as an old friend, they departed this life as equals"

Doug Heffernan

Indeed, it is not really a bug per se. But I did not know where else to post it. And yes, it appears that in the 2.1. version it has been fixed.

Advertisement: