News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

What's 'standard' in 2.1 from these mods?

Started by landyvlad, June 25, 2018, 10:07:19 PM

Previous topic - Next topic

GigaWatt

Quote from: _max_ on July 05, 2018, 02:34:30 PM
Hi, it was added in 2.1 beta 4?
With the beta 3 only the link is displayed.

Hmmm... didn't know that. Did the YouTube button exist in Beta 3?
"This is really a generic concept about human thinking - when faced with large tasks we're naturally inclined to try to break them down into a bunch of smaller tasks that together make up the whole."

"A 500 error loosely translates to the webserver saying, "WTF?"..."

Antes

Quote from: GigaWatt on July 05, 2018, 05:01:27 PM
Quote from: _max_ on July 05, 2018, 02:34:30 PM
Hi, it was added in 2.1 beta 4?
With the beta 3 only the link is displayed.

Hmmm... didn't know that. Did the YouTube button exist in Beta 3?

YouTube embed added in latest builds, its a plugin of SCEditor.

landyvlad

Thanks for the clarification :)

Quote from: Antes on July 05, 2018, 02:36:20 PM
Maybe I should stop working on SP and give my full focus to TP... Do you guys have cookies ?

Yes, you should :)

"Put as much effort into your question as you'd expect someone to give in an answer"

Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

Be the person your dog thinks you are.

wintstar

Quote from: Antes on July 05, 2018, 05:05:36 PM
Quote from: GigaWatt on July 05, 2018, 05:01:27 PM
Quote from: _max_ on July 05, 2018, 02:34:30 PM
Hi, it was added in 2.1 beta 4?
With the beta 3 only the link is displayed.

Hmmm... didn't know that. Did the YouTube button exist in Beta 3?

YouTube embed added in latest builds, its a plugin of SCEditor.
But it is removed again with Pull Request "Sceditor update #4771". There is a problem with other tags. Maybe someone can find a way to fix this.

QuoteSesquipedalian commented 4 days ago    Since this PR doesn't actually fix #4763, and I've determined that the issue is with SCEditor's AutoYouTube plugin, I'm simply going to disable and remove the AutoYouTube plugin, file a bug report over on the SCEditor repo, and call it a day. If and when Sam Clarke rewrites the AutoYouTube plugin, someone can release a mod to add the AutoYouTube plugin.
Regards Stephan

,,In order for the possible to come into being, the impossible must be attempted again and again."
Hermann Hesse (1877-1962)

My HomepageMy Board - My Atelier

wintstar

 :) YouTube function apparently remains

Quote
https://github.com/SimpleMachines/SMF2.1/pull/4771#issuecomment-404944928
Tested this PR.  Don't see any issues with the Sceditor.  Youtube bbc works fine still.  Auto youtube is taken out as expected.
Regards Stephan

,,In order for the possible to come into being, the impossible must be attempted again and again."
Hermann Hesse (1877-1962)

My HomepageMy Board - My Atelier

Advertisement: