Want to get involved in developing SMF, then why not lend a hand on our github!
Started by Gwenwyfar, July 08, 2018, 10:25:29 AM
Quote from: Illori on October 28, 2019, 05:37:42 AMthis is something the team would have to discuss. since the owner is no longer able to approve the transfer it is a bit complicated to handle.
Quote from: Arantor on October 28, 2019, 05:57:19 AMFor whatever it's worth, I'd support this.Also 2.0.16 should fix the session issue across the board.
Quote from: Skhilled on October 28, 2019, 06:07:37 AMThanks, and yes, I've heard about that but have no idea when it will be available and a few people are still having problems now. However, they can still come to the CZ site as I'll be updating the 2.0 themes that they need for now.
Quote from: Skhilled on October 29, 2019, 09:24:19 AMYes! I did see that and meant to say something about that but was so busy yesterday that I forgot. Did you updated the theme in the downloads here to include the search bar and the session issue?
Quote from: Skhilled on October 29, 2019, 09:24:19 AMThe theme I updated came from the CZ site's files and was never even put in the downloads there! However, that one does already have the search bar on it. So, Jeff may have added it himself but just never added it to the downloads.
Quote from: SychO on February 19, 2020, 04:52:06 PMI added mod support in my own themes as well, however I did not use a user editable setting, because most of the time users can hardly even find their way to the current theme settings (even though in my themes I added a button in the header to directly go to that page), but most importantly if the user enables support for a mod using that setting and the mod is actually not installed, that can lead to him getting locked out of the forum because of an internal server error where the theme calls for a mod function that actually doesn't exist in the code base.If you want to add support for other mods, I would highly suggest you try what I did, for example vbgamer45's Like posts mod has a "LikePosts" php class, so what I did was test if the class exists or not to tell if the mod is installed using the class_exists() php function, the same can be done to mods adding new functions, you can use function_exists() but only if you're certain that if the mod was installed that function/class would be accessible from the page you're testing it from. Also when using this method you should also make sure whatever function/class name you're using to test isn't used by some other mod.It may be a little complicated but at least it's better than having a setting that may mess the forum up if enabled.This is just my opinion, I'm not saying that it is not allowed as I haven't had the chance to hear the other's opinions about it.
Quote from: addlife on May 03, 2020, 06:05:37 PMCorrect me if I'm understanding wrong. The themes that you're referring to will work with the like posts mod without manual edits even if it's installed after the like posts mod?I saw somewhere in the code of Sunrise that it mentions vbgamers mod in a comment. Is that the part of code that you did whatever you posted above?