Advertisement:

Author Topic: support PHP Version 7.2.7  (Read 1925 times)

Offline dimsarostov

  • Newbie
  • *
  • Posts: 2
support PHP Version 7.2.7
« on: August 03, 2018, 02:49:46 AM »
Hi people!
SMF 2.1.x supported the PHP Version 7.2.7 ?

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,452
    • StoryBB/StoryBB on GitHub
Re: support PHP Version 7.2.7
« Reply #1 on: August 03, 2018, 02:53:10 AM »
It should do.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline dimsarostov

  • Newbie
  • *
  • Posts: 2
Re: support PHP Version 7.2.7
« Reply #2 on: August 03, 2018, 03:07:10 AM »

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,452
    • StoryBB/StoryBB on GitHub
Re: support PHP Version 7.2.7
« Reply #3 on: August 03, 2018, 03:19:42 AM »
No, mostly because I'm not really working on SMF 2.1.

The main issues that 7.2 raised that broke a lot of SMF 2.0, however, I *know* those have been fixed.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline d3vcho(void)

  • Sempiterno
  • Lead Localizer
  • SMF Hero
  • *
  • Posts: 2,970
  • Gender: Male
    • frandominguez03 on GitHub
    • @_d3vcho on Twitter
Re: support PHP Version 7.2.7
« Reply #4 on: August 03, 2018, 04:59:14 AM »
Not sure if I tried it with PHP 7.2.6 or 7.2.7 but definitely it works.
"Demons are like obedient dogs; they come when they're called"

d3vcho(void)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,452
    • StoryBB/StoryBB on GitHub
Re: support PHP Version 7.2.7
« Reply #5 on: August 03, 2018, 05:00:43 AM »
And if it doesn't work in some way, that's a bug and should be reported.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Chen Zhen

  • Sophist Member
  • *****
  • Posts: 1,148
  • Gender: Male
  • If you're going through hell, keep going!
    • Underdog-01 on GitHub
    • WebDev.ca
Re: support PHP Version 7.2.7
« Reply #6 on: August 04, 2018, 02:53:26 PM »

I currently use PHP 7.2.8 and have had no issues.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 57,221
  • Gender: Male
    • Kindred-999 on GitHub
Re: support PHP Version 7.2.7
« Reply #7 on: August 04, 2018, 03:46:33 PM »
and you have self-modified the forum to make it work....

And possibly missed something...

Either way - when the official support for 7.2 comes out (if it does) thn you will have to undo all of your self-made changes.

Once again. SMF 2.0.x does not support php 7.2 (and there is no reason that any reasonable host would force you to run 7.2
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,452
    • StoryBB/StoryBB on GitHub
Re: support PHP Version 7.2.7
« Reply #8 on: August 04, 2018, 04:01:10 PM »
This is the 2.1 board... one presumes we were all discussing 2.1 which should be ok on 7.2...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 57,221
  • Gender: Male
    • Kindred-999 on GitHub
Re: support PHP Version 7.2.7
« Reply #9 on: August 04, 2018, 05:07:49 PM »
whoops...  right.

I know that Chen Zen was trying to modify 2.0 to allow php 7.2 as well and got confused
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Chen Zhen

  • Sophist Member
  • *****
  • Posts: 1,148
  • Gender: Male
  • If you're going through hell, keep going!
    • Underdog-01 on GitHub
    • WebDev.ca
Re: support PHP Version 7.2.7
« Reply #10 on: August 04, 2018, 06:01:19 PM »

Yes that was concerning SMF 2.1.

Concerning SMF 2.0 I made a mod that provides all the changes which should only involve uninstalling that modification when/if the SMF 2.0 branch is updated concerning deprecated syntax.
People are not forced to upgrade to PHP 7.2 at this time but they like to have a choice for various reasons.

and you have self-modified the forum to make it work....

And possibly missed something...

Either way - when the official support for 7.2 comes out (if it does) thn you will have to undo all of your self-made changes.

Once again. SMF 2.0.x does not support php 7.2 (and there is no reason that any reasonable host would force you to run 7.2

Perhaps I can respond to that above statement in kind.

I could explain further but if you can not fathom reasons for using it on your own then I see no point.
BTW - I missed nothing but apparently you did.
 



Offline vivien

  • Semi-Newbie
  • *
  • Posts: 22
Re: support PHP Version 7.2.7
« Reply #11 on: November 08, 2018, 09:41:43 AM »
Note: Ubuntu server 18.04 only supports PHP 7.2 and more and more hosts migrate to this version.

Offline albertlast

  • Development Contributor
  • Jr. Member
  • *
  • Posts: 352
Re: support PHP Version 7.2.7
« Reply #12 on: November 08, 2018, 01:10:48 PM »
i already got a php 7.3 RC4 env running and
notice no error in smf 2.1 gh version.

Offline SpacePhoenix

  • Semi-Newbie
  • *
  • Posts: 26
Re: support PHP Version 7.2.7
« Reply #13 on: November 08, 2018, 02:53:54 PM »
Both versions 5.6 and 7.0 of PHP go EOL by the end of the year, once that happens some hosts might move all their servers over to 7.1 or 7.2

Offline live627

  • Developer
  • SMF Hero
  • *
  • Posts: 5,372
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: support PHP Version 7.2.7
« Reply #14 on: November 08, 2018, 03:01:45 PM »
Quote
Concerning SMF 2.0 I made a mod that provides all the changes
It's over 9000!!! :P

That mod seems to me very brittle due to the amount of edits it makes.
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Chen Zhen

  • Sophist Member
  • *****
  • Posts: 1,148
  • Gender: Male
  • If you're going through hell, keep going!
    • Underdog-01 on GitHub
    • WebDev.ca
Re: support PHP Version 7.2.7
« Reply #15 on: November 10, 2018, 08:29:23 PM »
It's over 9000!!! :P

That mod seems to me very brittle due to the amount of edits it makes.

That's highly over exaggerated and Imo very internet troll like in nature.
Perhaps some peer`s bad habits are rubbing off.

Also (unrelated to the above) maybe someone can delete the post from the spam lecher.


Offline Irisado

  • A Light in the Darkness
  • Doc Coordinator
  • SMF Hero
  • *
  • Posts: 9,633
  • Soñando debajo del arco iris
Re: support PHP Version 7.2.7
« Reply #16 on: November 11, 2018, 06:18:46 AM »
The spam post has been removed, but please use the report to moderator button next time to ensure a faster response.
Soñando con una playa donde brilla el sol, un arco iris ilumina el cielo, y el mar espejea iridescentemente

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 69,452
    • StoryBB/StoryBB on GitHub
Re: support PHP Version 7.2.7
« Reply #17 on: November 11, 2018, 06:26:24 AM »
I’m not sure I’d disagree on brittle, because there’s only three ways to do it: do a find/replace on each standard code using package manager (relies on no changes, misses non stock codes), do a find/replace on just the syntax (way more fragile, can still miss some), or write something insanely clever to do the conversion on Subs.php to pick up every code and every mod in the file.

That last one isn’t entirely impossible but it does rely on detecting implicit conditional compilation but some clever calls to get_tokens() to get the syntax as PHP itself sees it would solve that. It also breaks uninstalling any of the mods while it’s at it (though so do the others)

Honestly, while I applaud the effort that’s gone into trying to prolong the life of a 7 year old system, maybe that energy would have been better spent on getting 2.1 out that already has this future proofed.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.