smf 2.1 index css url problem

gecitli · August 15, 2018, 01:58:52 PM

Hello there

I can not add css to the link

Gwenwyfar · August 15, 2018, 02:06:23 PM

What exactly are you trying to do? I'm not sure I understand.

gecitli · August 15, 2018, 02:20:39 PM

link structure does not work like smf 2.0?

smf 2.0

// The ?fin20 part of this link is just here to make sure browsers don't cache it wrongly.
	echo '
	<link rel="stylesheet" type="text/css" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css?fin20" />';

smf 2.1 also gives an error

Code Select

echo '<link rel="stylesheet" type="text/css" href="', $settings['theme_url'], '/css/bootstrap.css" />
	<link rel="stylesheet" type="text/css" href="', $settings['theme_url'], '/css/fontawesome-all.css" />';

SychO · August 15, 2018, 02:23:13 PM

I'm not familiar with how 2.1 works, but what error does it give exactly ?

gecitli · August 15, 2018, 02:32:34 PM

does not see bootstrap.css fontawesome-all.css

I can add one like this

Code Select

loadCSSFile('fontawesome-all.css');

Arantor · August 15, 2018, 03:12:01 PM

Using that function is the correct way to do it in 2.1.

gecitli · August 16, 2018, 01:52:23 AM

The solution to the problem is to add code to index.css ie

Code Select

@import url(https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css);

SychO · August 16, 2018, 04:02:01 AM

Why don't you just use the loadCSSFile function ?

Kindred · August 16, 2018, 09:48:05 AM

Quote from: gecitli on August 16, 2018, 01:52:23 AM
The solution to the problem is to add code to index.css ie

Code Select Expand
@import url(https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css);

that's not the solution. That's an improper hack to the code that ignores the function which was created specifically for the purpose of including additional CSS files.

gecitli · August 16, 2018, 10:52:41 AM

Quote from: Kindred on August 16, 2018, 09:48:05 AM
Quote from: gecitli on August 16, 2018, 01:52:23 AM
The solution to the problem is to add code to index.css ie

Code Select Expand
@import url(https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css);

that's not the solution. That's an improper hack to the code that ignores the function which was created specifically for the purpose of including additional CSS files.

okay but what's the solution

Code Select

loadCSSFile('fontawesome-all.css');
	loadCSSFile('bootstrap.css');

Someone is not working like this

Theme is here
https://github.com/gecitli/ozel

have a look

Demo

http://webtiryaki.com/forum/index.php

SychO · August 16, 2018, 11:15:30 AM

I don't think that's where it goes, put it in the <head> tag after

Code Select

// load in any css from mods or themes so they can overwrite if wanted
	template_css();

gecitli · August 16, 2018, 11:31:50 AM

not to add the problem code, but the recognition is active while the other is passive.

Arantor · August 16, 2018, 11:58:32 AM

Where did you put the loadCSSfile call?

SychO · August 16, 2018, 12:01:54 PM

Quote from: Arantor on August 16, 2018, 11:58:32 AM
Where did you put the loadCSSfile call?

he put it in template_init()

Code Select

function template_init()
{
	global $settings, $txt;

	loadCSSFile('fontawesome-all.css');
	/* $context, $options and $txt may be available for use, but may not be fully populated yet. */

Arantor · August 16, 2018, 12:50:21 PM

Correct place. I wonder if it needs more parameters.

Though honestly I long since forgot how to do this part since my own themes don't use any of this stuff.

Gwenwyfar · August 16, 2018, 02:38:38 PM

Quote from: Arantor on August 16, 2018, 12:50:21 PM
Correct place. I wonder if it needs more parameters.

Though honestly I long since forgot how to do this part since my own themes don't use any of this stuff.

Does it actually make any difference to use there vs above the template_css call?

There are others that were added recently to reorder the css, options to minify and something else I forgot. I believe they're optional though.

Arantor · August 16, 2018, 02:42:54 PM

Potentially, yes, given that you need to do it early enough to actually make it into the template_css() call in the first place.

News:

smf 2.1 index css url problem