News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Bar.gif

Started by Bigguy, August 25, 2018, 03:17:38 PM

Previous topic - Next topic

Bigguy

I updated my site on Aug 22 and a member has found an error. I would like to point you to this thread:
https://www.whatsurbeef.net/index.php?topic=897.msg5219#msg5219

Gwenwyfar

Is he using the git version? I cannot even find any reference to bar.gif in my repo.
"It is impossible to communicate with one that does not wish to communicate"

Bigguy

When I update the site I use the download from github. I did not find the error chen_zhen found it on my site I guess.

Gwenwyfar

That's not a lot of information to go by. I see he's using a custom theme and some mods, maybe he should look in his files.
"It is impossible to communicate with one that does not wish to communicate"

Bigguy

I will link this thread to my forum and he may be able to explain it better.

Chen Zhen


I've since tested this locally with no other mods installed ~ bare bone SMF 2.1 - beta build dated Aug.25 / 2018.

The bar.gif file must be related to some other modification or edit to Bigguy's site as this does not appear while testing locally.

However, the 2 javascript issues are flagged using the Google Chrome console log.
These violation warnings seem to be a performance recommendation.

file from both warnings: jquery.sceditor.bbcode.min.js

document.write (d.write)
ref. https://developers.google.com/web/updates/2016/08/removing-document-write

non-passive event listener to a scroll-blocking 'touchstart' event
https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners




Imo should be able to use a dom node instead of document.write & simply adding passive: true to the event listener.
I may add a PR later this week if someone doesn't do it first.



My SMF Mods & Plug-Ins

WebDev

"Either you repeat the same conventional doctrines everybody is saying, or else you say something true, and it will sound like it's from Neptune." - Noam Chomsky

Advertisement: