Advertisement:

Author Topic: Lunarfall  (Read 12126 times)

Online Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 9,075
  • Gender: Male
  • Black cat rulz!
    • XinYenFon on GitHub
    • merta on LinkedIn
    • @XinYenFon on Twitter
    • wowsnips
Re: Lunarfall
« Reply #40 on: April 06, 2019, 12:34:21 PM »
Antes,

Code: [Select]
Notice: Undefined index: icon in /Themes/Lunarfall_v0.6.4/GenericMenu.template.php on line 211

Got that while testing SimpleDesk and on this page: index.php?action=admin;area=theme;sa=list

I fixed that in local build, thanks for report. I'll wrap up new version soonTM (hopefully).
You can support me via Twitch Prime* or Patreon.

[ Bastion ] # [ Lunarfall ] # [ RDD (HTML5) ]

* Twitch prime is an extra perk of your amazon prime subscription -no extra payment required-.

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Lunarfall
« Reply #41 on: July 02, 2019, 09:05:53 AM »
I have uploaded your theme but Simple Machine said there were errors. I copied some of your code and took it to a code analyzer and it confirmed errors in the code.

This is the error according to the analyzer :  221:                           <a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><i class="fa fa-question-circle fa-lg" title="', $txt['help'], '"></i></a>';
I help those who cannot get help elsewhere with free help!

Offline m4z

  • 98.8% chimp
  • Localizer
  • Sophist Member
  • *
  • Posts: 1,050
  • /mɛs/
Re: Lunarfall
« Reply #42 on: July 02, 2019, 09:11:30 AM »
I have uploaded your theme but Simple Machine said there were errors. I copied some of your code and took it to a code analyzer and it confirmed errors in the code.

What are the exact errors? What you posted is the line supposedly causing the error, but not the error message.

If you have other mods installed, they might interfere.
"Faith is what you have in things that don't exist."
--Homer Simpson

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Lunarfall
« Reply #43 on: July 02, 2019, 12:47:41 PM »
I'm not a coder so my ability is limited. all that I can tell you is Simple Machine repeated the error 11 times so far in the log files.

Does this help:

Error: No space between attributes.

At line 86, column 48

(0);><i class="fa fa-times fa-

Error: Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.

At line 86, column 80

 floatright red"></i></a>↩            

Warning: Attribute red" is not serializable as XML 1.0.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Error: Attribute fa not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute fa-times not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute fa-lg not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute floatright not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute red" not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Stray end tag i.

From line 86, column 82; to line 86, column 85

ight red"></i></a>↩   

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 145, column 96; to line 145, column 102

y at 21:13</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 202, column 97; to line 202, column 103

y at 07:52</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 259, column 96; to line 259, column 102

y at 14:13</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 316, column 94; to line 316, column 100

y at 20:48</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 337, column 295; to line 337, column 301

y at 07:52</time>)<br>↩

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 349, column 83; to line 349, column 89

y at 15:57</time>)<br>↩
I help those who cannot get help elsewhere with free help!

Offline KAMDen

  • Newbie
  • *
  • Posts: 4
Re: Lunarfall
« Reply #44 on: July 16, 2019, 04:10:49 AM »
Dear Antes. Please explain why the theme Lunarfall is missing the button image bb code - YouTube. I attach a screenshot, the problem highlighted in red. Tell me how to fix it without waiting for Your update?
Thanks.

Offline KAMDen

  • Newbie
  • *
  • Posts: 4
Re: Lunarfall
« Reply #45 on: July 19, 2019, 07:45:23 AM »
And silence... Normally so(

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 59,218
  • Gender: Male
    • Kindred-999 on GitHub
Re: Lunarfall
« Reply #46 on: July 19, 2019, 08:18:53 AM »
possible because you never added that icon into the lunarfall images directory or CSS?

Youtube is not a standard icon in the SMF editor. Icons added by mods have to be applied to custom themes as well
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline KAMDen

  • Newbie
  • *
  • Posts: 4
Re: Lunarfall
« Reply #47 on: July 19, 2019, 09:21:53 AM »
How is Youtube not a standard icon? The theme is written specifically for version 2.1 RC2. There this bb-code is present.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 59,218
  • Gender: Male
    • Kindred-999 on GitHub
Re: Lunarfall
« Reply #48 on: July 19, 2019, 10:20:27 AM »
oops...  right.
However, the issue is going to be the same.  Is the YouTube icon present in the sprite?
images/icons/editor_sprite.png
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline KAMDen

  • Newbie
  • *
  • Posts: 4
Re: Lunarfall
« Reply #49 on: July 19, 2019, 07:56:50 PM »
Kindred, on the path: "Themes/Lunarfall_v0.6.4/images/icons" file editor_sprite.png at all not watch.

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Lunar fall
« Reply #50 on: July 22, 2019, 10:04:36 PM »
Can I get some help on how to fix Error


Error
Type of error: Undefined_vars
Error message: 8: Undefined index: mediapro_copyremove
File: /home/djradios/public_html/Sources/AutoEmbedMediaProHooks.php
Line: 48
URL of page causing the error: https://djradiosoundstation.com/index.php?action=admin;area=logs;sa=errorlog;desc
Backtrace information
#0: smf_error_handler()
Called from /home/djradios/public_html/Sources/AutoEmbedMediaProHooks.php on line 48
#1: automedia_admin_areas()
Called from /home/djradios/public_html/Sources/Subs.php on line 4846
#2: call_integration_hook()
Called from /home/djradios/public_html/Sources/Subs-Menu.php on line 75
#3: createMenu()
Called from /home/djradios/public_html/Sources/Admin.php on line 474
#4: AdminMain()
Called from /home/djradios/public_html/index.php on line 151
I help those who cannot get help elsewhere with free help!

Online Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 9,075
  • Gender: Male
  • Black cat rulz!
    • XinYenFon on GitHub
    • merta on LinkedIn
    • @XinYenFon on Twitter
    • wowsnips
Re: Lunarfall
« Reply #51 on: July 23, 2019, 06:26:24 AM »
I`m on strict schedule with my Masters` thesis & PhD pre-research (+other health issues I want to keep private), all those issues are fixed but not yet released. Sorry to say but you have to wait at least 1 more month before I can commit some fixes/changes.

Thank you for your understanding.
You can support me via Twitch Prime* or Patreon.

[ Bastion ] # [ Lunarfall ] # [ RDD (HTML5) ]

* Twitch prime is an extra perk of your amazon prime subscription -no extra payment required-.

Online Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 9,075
  • Gender: Male
  • Black cat rulz!
    • XinYenFon on GitHub
    • merta on LinkedIn
    • @XinYenFon on Twitter
    • wowsnips
Re: Lunarfall
« Reply #52 on: August 12, 2019, 08:11:52 AM »
0.6.5 released : )
Code: [Select]
0.6.5 (12 August 2019)
* Icon changes
* Sync with Curve2
* RC2 ready
* Font-Awesome updated to 5.10.1

@RML
Check: https://github.com/Antes/Lunarfall/wiki/Adding-Custom-Post-Icons (0.6.5 or above required)

@SleePy
Fixed with 0.6.5

@KAMDen
Its known issue even in 0.6.5 release, it will stay that way for some time till I find proper fix. To explain the issue, Font-Awesome does not offer standard sprite icons, its system little bit different and with more icons in pack, they are dividing the certain groups into sub groups, YouTube in this case belongs to FAB sub-group, all other icons are belong to FAS group.

@TigerAnt
I have no idea about the issue, can you reproduce it in default theme? Maybe you can get better answer from author of the mod.
You can support me via Twitch Prime* or Patreon.

[ Bastion ] # [ Lunarfall ] # [ RDD (HTML5) ]

* Twitch prime is an extra perk of your amazon prime subscription -no extra payment required-.

Offline TigerAnt

  • Semi-Newbie
  • *
  • Posts: 56
  • Gender: Male
  • Helping the less fortunate!
Re: Lunarfall
« Reply #53 on: August 12, 2019, 10:39:23 AM »
That is ok, I have decided not to use it.
I help those who cannot get help elsewhere with free help!

Offline m4z

  • 98.8% chimp
  • Localizer
  • Sophist Member
  • *
  • Posts: 1,050
  • /mɛs/
Re: Lunarfall
« Reply #54 on: September 12, 2019, 05:35:20 PM »
Hey, with 0.6.5 I'm seeing the following errors:
Quote
Type of error: Undefined
8: Undefined index: calendar_default_view
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 138)

Type of error: Undefined
8: Undefined index: calendar_viewlist
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 140)

Type of error: Undefined
8: Undefined index: calendar_viewmonth
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 141)

Type of error: Undefined
8: Undefined index: calendar_viewweek
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 142)


The relevant code section:
Code: [Select]
   135: $txt['theme_opt_calendar'],
   136: array(
   137: 'id' => 'calendar_default_view',
==>138: 'label' => $txt['calendar_default_view'],
   139: 'options' => array(
==>140: 'viewlist' => $txt['calendar_viewlist'],
==>141: 'viewmonth' => $txt['calendar_viewmonth'],
==>142: 'viewweek' => $txt['calendar_viewweek']
   143: ),
   144: 'default' => true,
   145: 'enabled' => !empty($modSettings['cal_enabled']),
   146: ),


Also, I guess you forgot to bump the version somewhere, because the theme is displayed as "Lunarfall_v0.6.5 (0.6.4)" to me under "Modify Themes".

I'm seeing more errors, but I'll have to filter those that are related to other mods... will post more info in a few days.
"Faith is what you have in things that don't exist."
--Homer Simpson

Online Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 9,075
  • Gender: Male
  • Black cat rulz!
    • XinYenFon on GitHub
    • merta on LinkedIn
    • @XinYenFon on Twitter
    • wowsnips
Re: Lunarfall
« Reply #55 on: September 14, 2019, 10:05:54 AM »
Try going latest GitHub version and try again. If you are using RC2 (release), stay on 0.6.4.
You can support me via Twitch Prime* or Patreon.

[ Bastion ] # [ Lunarfall ] # [ RDD (HTML5) ]

* Twitch prime is an extra perk of your amazon prime subscription -no extra payment required-.

Offline m4z

  • 98.8% chimp
  • Localizer
  • Sophist Member
  • *
  • Posts: 1,050
  • /mɛs/
Re: Lunarfall
« Reply #56 on: September 14, 2019, 02:19:24 PM »
With 0.6.4 I had much more errors (similar to those reported by others above); couldn't use it in "production", so I'll stick with 0.6.5 for now (my handful of users hardly use the calendar; I'll just inform them about it).

PS: Also seeing the following two errors on 0.6.5 when installing a mod (a modified version of the "GDPR Helper" mod with postgres support):

Error number one:
Quote
Type of error: Undefined
8: Undefined variable: i
 https://(redacted)/index.php?action=admin;area=packages;sa=install;package=1568479393.zip
 /home/alpha-smf/public_html/Themes/Lunarfall_v0.6.5/Packages.template.php (Line 165)

Code: [Select]
   155: $action_num = 1;
   156: $js_operations = array();
   157: foreach ($context['actions'] as $packageaction)
   158: {
   159: // Did we pass or fail?  Need to now for later on.
   160: $js_operations[$action_num] = isset($packageaction['failed']) ? $packageaction['failed'] : 0;
   161:
   162: echo '
   163: <tr class="windowbg">
   164: <td>', isset($packageaction['operations']) ? '<img id="operation_img_' . $action_num . '" src="' . $settings['images_url'] . '/selected_open.png" alt="*" style="display: none;">' : '', '</td>
==>165: <td style="width: 30px;">', $i++, '.</td>
   166: <td style="width: 23%;">', $packageaction['type'], '</td>
   167: <td style="width: 50%;">', $packageaction['action'], '</td>
   168: <td style="width: 20%;">', $packageaction['description'], '</td>
   169: </tr>';


Error number two:
Quote
Type of error: Undefined
8: Undefined variable: operation_num
 https://(redacted)/index.php?action=admin;area=packages;sa=install;package=1568479393.zip
 /home/alpha-smf/public_html/Themes/Lunarfall_v0.6.5/Packages.template.php (Line 192)

Code: [Select]
   179: // Show the operations.
   180: foreach ($packageaction['operations'] as $operation)
   181: {
   182: // Determine the position text.
   183: $operation_text = $operation['position'] == 'replace' ? 'operation_replace' : ($operation['position'] == 'before' ? 'operation_after' : 'operation_before');
   184:
   185: echo '
   186: <tr class="windowbg">
   187: <td class="righttext">
   188: <a href="', $scripturl, '?action=admin;area=packages;sa=showoperations;operation_key=', $operation['operation_key'], !empty($context['install_id']) ? ';install_id=' . $context['install_id'] : '', ';package=', $_REQUEST['package'], ';filename=', $operation['filename'], ($operation['is_boardmod'] ? ';boardmod' : ''), (isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'uninstall' ? ';reverse' : ''), '" onclick="return reqWin(this.href, 600, 400, false);">
   189: <i class="fas fa-scroll"></i>
   190: </a>
   191: </td>
==>192: <td width="30">', $operation_num++, '.</td>
   193: <td width="23%">', $txt[$operation_text], '</td>
   194: <td width="50%">', $operation['action'], '</td>
   195: <td width="20%">', $operation['description'], !empty($operation['ignore_failure']) ? ' (' . $txt['operation_ignore'] . ')' : '', '</td>
   196: </tr>';
   197: }

PPS: When I select Lunarfall 0.6.5 as my user theme (under Look and Layout in my profile), and try to switch back to the default theme, I get a "session verification error" under some circumstances, re-logging-in doesn't change anything. Only when I first preview the default theme can I then successfully change it. (First I thought this doesn't happen when Lunarfall is selected as the default forum theme; but the situation seems to be more complex.)

PPPS:
Quote
Lunafall is a dark gaming inspired by Steam website.



I tested the GH version, and what I see is the following:
  • for my "alpha" forum, running a reasonably current Github version (2019-09-01) of SMF, your fix works fine, both when the calendar is enabled or disabled
  • for my 2.1rc2 "beta" forum, the fix doesn't work; what I see in Curve2 is that there's only one calendar option, and it's higher up on the page; when using Lunarfall, I see the same errors as before (and the same half-broken calender section at the bottom of my Look and Layout page)

I'm not sure whether I did anything to my beta forum before that caused this, I don't think so, though. (For all I care, the fix is fine, I'm planning to update my other forums to a more recent version than 2.1rc2 soon-ish.)

Thanks for your awesome theme (and time)! <3
"Faith is what you have in things that don't exist."
--Homer Simpson

Online Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 9,075
  • Gender: Male
  • Black cat rulz!
    • XinYenFon on GitHub
    • merta on LinkedIn
    • @XinYenFon on Twitter
    • wowsnips
Re: Lunarfall
« Reply #57 on: September 14, 2019, 02:44:44 PM »
I`ll take a look at the soonish. Thank you for the reports.
You can support me via Twitch Prime* or Patreon.

[ Bastion ] # [ Lunarfall ] # [ RDD (HTML5) ]

* Twitch prime is an extra perk of your amazon prime subscription -no extra payment required-.

Offline m4z

  • 98.8% chimp
  • Localizer
  • Sophist Member
  • *
  • Posts: 1,050
  • /mɛs/
Re: Lunarfall
« Reply #58 on: September 14, 2019, 02:49:17 PM »
Also, in 2.1rc2, the Save Draft and Preview buttons during Quickreply or normal Reply disappear when using 0.6.5 or your GH version, and the keyboard shortcuts for draft/preview/post don't work. [edit: also, the buttons for modifying/reporting/etc. of posts are gone]

In the SMF Github version from 2019-09-01, all of the above works normally.
"Faith is what you have in things that don't exist."
--Homer Simpson

Online Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 9,075
  • Gender: Male
  • Black cat rulz!
    • XinYenFon on GitHub
    • merta on LinkedIn
    • @XinYenFon on Twitter
    • wowsnips
Re: Lunarfall
« Reply #59 on: September 14, 2019, 03:30:32 PM »
Also, in 2.1rc2, the Save Draft and Preview buttons during Quickreply or normal Reply disappear when using 0.6.5 or your GH version, and the keyboard shortcuts for draft/preview/post don't work. [edit: also, the buttons for modifying/reporting/etc. of posts are gone]

In the SMF Github version from 2019-09-01, all of the above works normally.

0.6.5 / GH version both designed for Nightly builds of SMF 2.1.

0.6.4 probably the only proper release for SMF 2.1 RC2 (release).
You can support me via Twitch Prime* or Patreon.

[ Bastion ] # [ Lunarfall ] # [ RDD (HTML5) ]

* Twitch prime is an extra perk of your amazon prime subscription -no extra payment required-.