Advertisement:

Author Topic: Member Approval Emails Don`t Get Sent  (Read 1043 times)

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Member Approval Emails Don`t Get Sent
« on: October 09, 2018, 05:46:54 PM »
Every new member has to be approved in my forum to join. I can see pretty much every email gets sent and get in the queue by the system. But the membership approval emails don`t get sent for some reason when I click on approve on their profile.

How can I find out why my membership approval emails don`t get sent, not even listed in the email queue when I click on approve on their profile?


These people don`t get a notification email when I approve their membership so they never come and participate in the forum
Please help

Offline Looking

  • SMF Hero
  • ******
  • Posts: 2,307
  • SMF Customization
    • jeanborde on Facebook
    • SMF Custom Themes & Custom Coding
Re: Member Approval Emails Don`t Get Sent
« Reply #1 on: October 09, 2018, 05:49:46 PM »
Check the email logs of your server.

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 50,411
Re: Member Approval Emails Don`t Get Sent
« Reply #2 on: October 09, 2018, 05:50:29 PM »
if you are approving from their profile, that by default does not send out the email. you need to approve from the admin panel to send the email.

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Re: Member Approval Emails Don`t Get Sent
« Reply #3 on: October 09, 2018, 06:06:56 PM »
if you are approving from their profile, that by default does not send out the email. you need to approve from the admin panel to send the email.

Well in the email notification I get as the admin, it has the persons profile link added so I click on the profile link and then click on the approve button on their profile.
Are they not suppose to get any notification email on their membership approval when you approve it like this?

If not, then how can I fix this issue and make it send a notification email to the person when the membership gets approved no matter how it gets approved?

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Re: Member Approval Emails Don`t Get Sent
« Reply #4 on: October 10, 2018, 06:00:15 AM »
Can anyone please help?

My members don`t get a notification email when I approve their membership. So they don`t know and they never participate in the forum.

Offline a10

  • Charter Member
  • Sr. Member
  • *
  • Posts: 836
Re: Member Approval Emails Don`t Get Sent
« Reply #5 on: October 10, 2018, 06:27:13 AM »
Quote
I click on the profile link and then click on the approve button on their profile.
Are they not suppose to get any notification email on their membership approval when you approve it like this?

No. Use the dropdown menu in admin > members, see attachment.
2.0.15, ssl, php 7.1.25, MySQL 10.1.30-MariaDB-1~xenial
Mods: Contact Page, Like Posts, Responsive Curve, Search Focus Dropdown.

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Re: Member Approval Emails Don`t Get Sent
« Reply #6 on: October 10, 2018, 06:30:50 AM »
Quote
I click on the profile link and then click on the approve button on their profile.
Are they not suppose to get any notification email on their membership approval when you approve it like this?

No. Use the dropdown menu in admin > members, see attachment.

But I have to read what they answered to each question during membership request and then I click on the approve link on their profile. Is there anyway to add this notification email to that approve button in the profile?

Offline a10

  • Charter Member
  • Sr. Member
  • *
  • Posts: 836
Re: Member Approval Emails Don`t Get Sent
« Reply #7 on: October 10, 2018, 07:06:05 AM »
I agree it would be good to be able to finish the complete task in profile.
But as things stand, one has to switch to the admin section for the email. Maybe ask for a mod or some code ?
2.0.15, ssl, php 7.1.25, MySQL 10.1.30-MariaDB-1~xenial
Mods: Contact Page, Like Posts, Responsive Curve, Search Focus Dropdown.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 70,540
    • StoryBB/StoryBB on GitHub
Re: Member Approval Emails Don`t Get Sent
« Reply #8 on: October 10, 2018, 07:07:15 AM »
I’m still confused by this concept of demanding users fill in something that affects whether they get approved or not. It feels unnecessary.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline GigaWatt

  • The Smiley Guy
  • Support Specialist
  • SMF Hero
  • *
  • Posts: 1,669
  • Gender: Male
    • Macedonian electronics forum
Re: Member Approval Emails Don`t Get Sent
« Reply #9 on: October 10, 2018, 10:59:48 AM »
I’m still confused by this concept of demanding users fill in something that affects whether they get approved or not.

I've seen it on many forums and it's actually how you get to find out things about them, for example the level of knowledge the user has on a particular subject (usually, something that the forum is about). Forums that deal with serious/professional things (something that is mostly not for fun, or at least not considered to be fun by most people) usually don't want your average Joe joining, they want contributing members. In return, they get to read what other contributing members have to write ;).
"This is really a generic concept about human thinking - when faced with large tasks we're naturally inclined to try to break them down into a bunch of smaller tasks that together make up the whole."

"A 500 error loosely translates to the webserver saying, "WTF?"..."

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Re: Member Approval Emails Don`t Get Sent
« Reply #10 on: October 10, 2018, 02:58:30 PM »
I’m still confused by this concept of demanding users fill in something that affects whether they get approved or not. It feels unnecessary.

It`s very necessary in some forums. I hand pick my members solely based on their answers to the questions. GigaWatt explained it well too. I want to see their intentions, as well as their level of knowledge and their past. Plus it`s the best spammer filter for your forum :) My forum is highly elite when it comes to its own topic so as GigaWatt says, I don`t really want the average Joe to be there. He can search and find his answers in the forum as well as he can just browse around the forum too. But he just can`t participate. Just like a VIP section of many forums.

I agree it would be good to be able to finish the complete task in profile.
But as things stand, one has to switch to the admin section for the email. Maybe ask for a mod or some code ?

It seems to be a pretty simple code to be just copy pasted into the profile page so it will just add a function to send an email with every approval. Do you think you can help me on this? or do you know someone that can maybe give me code? I really hope it`s not a complex one.


Offline a10

  • Charter Member
  • Sr. Member
  • *
  • Posts: 836
Re: Member Approval Emails Don`t Get Sent
« Reply #11 on: October 10, 2018, 03:34:17 PM »
Quote
Quote from: a10 on Today at 07:06:05 AM

    I agree it would be good to be able to finish the complete task in profile.
    But as things stand, one has to switch to the admin section for the email. Maybe ask for a mod or some code ?


It seems to be a pretty simple code to be just copy pasted into the profile page so it will just add a function to send an email with every approval. Do you think you can help me on this? or do you know someone that can maybe give me code? I really hope it`s not a complex one.

Am just a humble forum admin, no coding. But (unless you got dozens of new members everyday) switching to the admin pages to get the email sent, not a big job ?
2.0.15, ssl, php 7.1.25, MySQL 10.1.30-MariaDB-1~xenial
Mods: Contact Page, Like Posts, Responsive Curve, Search Focus Dropdown.

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Re: Member Approval Emails Don`t Get Sent
« Reply #12 on: October 10, 2018, 03:37:44 PM »
Quote
Quote from: a10 on Today at 07:06:05 AM

    I agree it would be good to be able to finish the complete task in profile.
    But as things stand, one has to switch to the admin section for the email. Maybe ask for a mod or some code ?


It seems to be a pretty simple code to be just copy pasted into the profile page so it will just add a function to send an email with every approval. Do you think you can help me on this? or do you know someone that can maybe give me code? I really hope it`s not a complex one.

Am just a humble forum admin, no coding. But (unless you got dozens of new members everyday) switching to the admin pages to get the email sent, not a big job ?


Literally dozens of new members everyday. I wish I could do it without coding. Anyways thanks for your help.

Offline PLAYBOY

  • SMF Hero
  • ******
  • Posts: 2,065
  • Livephotoshop.com & Lullabyabc.com
    • Lullabies and Us
Re: Member Approval Emails Don`t Get Sent
« Reply #13 on: October 12, 2018, 05:53:19 AM »
Just for future reference to everyone... this was the solution...



In Profile-Actions.php // function activateAccount($memID), find this code:

Code: [Select]
       // Make sure we update the stats too.
        updateStats('member', false);

Add this directly after the above code, but before the } bracket that closes the parent conditional statement

Code: [Select]
        // Send approval email
        global $scripturl;

        // Needed for email template function
        require_once($sourcedir . '/Subs-Post.php');

        $replacements = array(
            'NAME' => $user_profile[$memID]['member_name'],
            'USERNAME' => $user_profile[$memID]['real_name'],
            'PROFILELINK' => $scripturl . '?action=profile;u=' . $memID,
            'FORGOTPASSWORDLINK' => $scripturl . '?action=reminder',
        );
        $emaildata = loadEmailTemplate('admin_approve_accept', $replacements, $member['language']);
        sendmail($user_profile[$memID]['email_address'], $emaildata['subject'], $emaildata['body'], null, null, false, 0);

The code I got the email stuff from was ManageMembers.php, around lines 1130 - 1238.




Reference: https://www.simplemachines.org/community/index.php?topic=562584