SMF 2.1 in maintenance mode - incorrect error log entries...

[@rjen]

On a test forum with a recent install from Github I just noticed this...

When in maintenance mode and users (bots) try to access attached images links directly the error log gets filled with hundreds of errors.

Example link:
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image

While the forum is open this displays the attached image. When I put the forum in maintenance mode any visit to this links results in over 300 errors and a complete distorted Maintenance mode screen... (see attached)

Errors are :

Type of error: General
2: Invalid argument supplied for foreach()
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image
/home/deb77453/domains/fjr-club.nl/public_html/test2/Sources/Subs.php (Line 3720)

Type of error: General
2: array_reverse() expects parameter 1 to be array, null given
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image
/home/deb77453/domains/fjr-club.nl/public_html/test2/Sources/Subs.php (Line 3720)

Type of error: Undefined
8: Undefined index: template_layers
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image
/home/deb77453/domains/fjr-club.nl/public_html/test2/Sources/Subs.php (Line 3720)

Type of error: Undefined
8: Undefined index: session_id
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image
/home/deb77453/domains/fjr-club.nl/public_html/test2/Themes/default/Login.template.php (Line 330)

Type of error: Undefined
8: Undefined index: session_var
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image
/home/deb77453/domains/fjr-club.nl/public_html/test2/Themes/default/Login.template.php (Line 330)

Type of error: Undefined
8: Undefined index: login
https://test2.fjr-club.nl/index.php?action=dlattach;topic=22362.0;attach=12287;image
/home/deb77453/domains/fjr-club.nl/public_html/test2/Themes/default/Login.template.php (Line 326)

etc...

[albertlast]

This should fix the issue: https://github.com/SimpleMachines/SMF2.1/pull/5098
the sonny fix is not needed.

Ps. you version look like it's not very recent,
since the  /home/deb77453/domains/fjr-club.nl/public_html/test2/Sources/Subs.php (Line 3720),
in the actual version in line 3689.

[@rjen]

Ps. you version look like it's not very recent,

It's a few weeks old, mind you I cannot keep reinstalling the forum with every update made.

Thanks for the fix, checking that out now...

[@rjen]

This should fix the issue: https://github.com/SimpleMachines/SMF2.1/pull/5098
the sonny fix is not needed.

Confirmed: that fixes the problem, thanks