Advertisement:

Author Topic: No ip  (Read 2300 times)

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
No ip
« on: December 30, 2018, 09:39:09 AM »
What's up with this guy. Why does he not show an ip.

Offline Aleksi "Lex" Kilpinen

  • A Peculiar Finn
  • Lead Support Specialist
  • SMF Super Hero
  • *
  • Posts: 18,855
  • Gender: Male
  • Don't worry, I'm n00b friendly
    • Aleksi.Kilpinen on Facebook
    • LexArma on GitHub
    • aleksi-kilpinen on LinkedIn
    • There's No Place Like 127.0.0.1
Re: No ip
« Reply #1 on: December 30, 2018, 10:23:40 AM »
For some reason it failed to resolve I'd guess, but why exactly - no idea.
A Finnish Support Specialist
 Happily running multiple SMF 2.0 installations.
  Fooling around with an i7 990X @ 3,47Ghz / 12Gb / Win 10 x64 / 3840x2160


How you can help SMF

"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum.
 Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #2 on: December 30, 2018, 10:41:04 AM »
This bot/person keeps hittin the cron.php file every 5 to 6 minutes.

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 52,475
Re: No ip
« Reply #3 on: December 30, 2018, 12:04:08 PM »
that is normal. otherwise many functions of SMF 2.1 would not work correctly, like the alerts.

they are not directly hitting it but causing it to run in the background due to guest activity.

[edit] check your scheduled tasks etc, seems one may have had this entry and the corresponding email template no longer exists, so you need to remove it.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #4 on: December 30, 2018, 12:23:23 PM »
I don't see anything in scheduled tasks to remove. Nothin jumps out at me anyway.

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 52,475
Re: No ip
« Reply #5 on: December 30, 2018, 12:29:04 PM »
search your database and files for notification_edit and see what is calling it, i dont have it in my files from github that i can see.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #6 on: December 30, 2018, 12:33:27 PM »
That's weird. I know I didn't put it in there. Maybe TP ?? I only have like 3 or 4 mods installed....Gallery, Arcade...Hmm, arcade sends out notifications. I wonder if it could be from that.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 72,655
    • StoryBB/StoryBB on GitHub
Re: No ip
« Reply #7 on: December 30, 2018, 12:34:31 PM »
Unless the arcade knows how to do 2.1 style alerts, it seems unlikely...
Please don’t PM me for paid work, I’m not for hire, and even if I was, I doubt you could afford me.
USD$150 per hour. Typical waiting list 3 months.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #8 on: December 30, 2018, 12:44:20 PM »
These are all the mods I have and the one crossed out is not installed. So I can't see it being a mod at all.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #9 on: December 30, 2018, 12:52:12 PM »
Maybe this would help

Offline Chen Zhen

  • Sophist Member
  • *****
  • Posts: 1,272
  • Gender: Male
  • If you're going through hell, keep going!
    • Underdog-01 on GitHub
    • WebDev.ca
Re: No ip
« Reply #10 on: December 31, 2018, 12:14:40 PM »

Function names concerning email templates for the Arcade have the word "arcade" in them.
The code concerning alerts (email and pm) are located in ../Sources/Subs-Arcade.php using the arcadeEvent() function.
Your reported errors do not appear to be from the Arcade.


My SMF Mods & Plug-Ins

WebDev
Simple Portal Support

Request politely & demand nothing.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #11 on: December 31, 2018, 12:37:45 PM »
Well....I'm at a lose. That error was not there before the upgrade so I am not sure what it is.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #12 on: January 03, 2019, 09:16:19 AM »
I looked in my error log and found this that pertains to the error in SMF I have...I think.
/home/*****/public_html/cron.php(208): CreatePost_Notify_Background->execute()
/home/*****/public_html/cron.php(102): perform_task(Array)


EDIT:
And maybe this one to:

/home/****/public_html/Sources/tasks/CreatePost-Notify.php(188): parse_bbc('Hey it's su...', false)

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #13 on: January 03, 2019, 09:21:43 AM »
This is in there as well:

PHP Fatal error:  Uncaught Error: Call to undefined function allowedTo() in /home/*****/public_html/Sources/Subs-Attachments.php:968

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #14 on: January 03, 2019, 10:56:20 PM »
Well I have searched everything but the database. So I guess that is my next stop.

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,126
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: No ip
« Reply #15 on: January 04, 2019, 01:21:35 PM »
I've looked into this, and it is a legitimate bug. It was hard to track down, but apparently it was introduced long ago in this commit. If you look there, you'll see on line 2081 that a notification is being created with its "type" set to "edit" even though there is otherwise no such thing as an "edit" notification in SMF.

This reason it has taken so long for this bug to manifest is probably that a very specific set of circumstances are required before it will trigger any errors. Specifically, a post containing a mention needs to be modified in a topic that being watched by some other user who has selected the option to be notified by email immediately whenever there is new activity in their watched topics. If that particular scenario occurs, SMF ends up trying to send an email notification using non-existent "notification_edit" email templates.

Unfortunately, merely changing that "type" value from "edit" to something that actually exists, such as "reply", isn't a good solution. That would avoid generating error messages in the log, but it would cause false "new reply" email notifications to be sent out to users watching the topic when what really happened was that an existing post containing a mention was modified. That would be wrong, and avoiding it is probably the reason why a different notification type was introduced here in the first place. The best solution is to follow through on that idea and implement proper handling of the "edit" notification type. So I'm working on a PR for that now.
I promise you nothing.

Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #16 on: January 04, 2019, 01:46:00 PM »
Your...your like a savior. I can stop pulling out my hair now, lmao. Thank god you found it. This error pops up about as much as the 1 Alert post I made in this board. It was drivin me wacko. Thank you sir for finding this. :)

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,126
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: No ip
« Reply #17 on: January 04, 2019, 09:07:01 PM »
Bigguy, please test the changes in https://github.com/SimpleMachines/SMF2.1/pull/5321 to see if that resolves the issue.
I promise you nothing.

Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #18 on: January 04, 2019, 09:36:19 PM »
Testing now.

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,007
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: No ip
« Reply #19 on: January 04, 2019, 09:56:45 PM »
Well, I woulda had errors by now I know I would have. I can post back when I get up tomorrow though to make sure it is workin. It looks good though. Thank you sir. :)