Suggest "Topic Solved" mod for SMF 2.1

[landyvlad]

The Topic Solved mod is a great one and obviously very useful for the SMF support forums !

I'm hoping that someone will take up the baton and develop them mod (or one that does the same thing) for SMF 2.1

Please

[Bigguy]

It would be useful but that's a big mod.

[Arantor]

That's not a big mod, but you'd want to rewrite it for 2.1 to make less file edits.

[Bigguy]

Well, to me when I parsed it it looked big, lol.

[Kindred]

... to make less file edits.

fewer


 
edits are countable.

[Arantor]

If you treat edits as units, sure, but I don't necessarily think of them as atomic units. One edit to add one line is a very different beast to one edit that rewrites a large chunk of stuff...

[Kindred]

hmmm... ok, interesting philosophical choice.

linguistically, though...

you make AN edit, right? That edit might be one line or a chunk...
If you touch multiple parts of the code, those are multiple edits.
You can edit (verb) the file once, to perform one or multiple edits (noun)
by adding an s, you have now defined the noun edit as countable...

(because you can have fewer carS, but would have less traffic...  you can't have fewer traffics (grammatically speaking however, you CAN have less car - but that's a different matter, LOL)


so, less editing...  fewer edits... 

[diegolyanky]

And more functionality will be great.

Like, ...choose image to show in solved topics (as the icon)

...edit the text to show ( like SOLVED /// ANSWERED )

... modify the "SOLVED" vote... ( "UNSOLVED AGAIN" -- "broken again" )



And a little hand that gives me cold beer would be great! 

[gevv]

Up  @[SiNaN]   

[Suki]

Worked on a topic solved mod for 2.1: https://github.com/MissAllSunday/TopicSolved

The base is done but needs to be adjusted to get it to work with current 2.1 code

[gevv]

Thanks @Suki

I tried it and all pages show error after installation

Fatal error: require_once(): Failed opening required 'C:/wamp64/www/smf/Sources/ohara/src/Suki/autoload.php' (include_path='.;C:\php\pear') in C:\wamp64\www\smf\Sources\TopicSolved.php on line 15

[landyvlad]

Thanks Suki keep up the good work....

[FredT]

I posted in Github issues as well. (Sorry, I am a noob in php ) But it seems the Github mod is the only "Topic Solved Mod" I can get to work with fms 2.1.1

Questions:

    I try to find the settings for "Whenever a topic is marked as solved, the topic will also be locked."
    I can not see the settings in the admin menu.

    I try to add a TopicSolved.german.php in my language folder. Any hints how to activate the german language?
    I could provide the translation also.

Thank you

[Kindred]

AFAIK, locking after solved has never been part of tge mod

[FredT]

AFAIK, locking after solved has never been part of tge mod

I was wondering cause the option is in the english language file:

$txt['TopicSolved_lockTopicWhen_sub'] = 'Chose which user can trigger locking a topic when marked as solved, options are:
<br>- '. $txt['TopicSolved_lockTopic_op'] .'. The topic will be locked only if the Original Poster marked the topic as solved
<br>- '. $txt['TopicSolved_lockTopic_staff'] .'. The topic will be locked only if someone marked as staff mark the topic as solved.
.
.
$txt['TopicSolved_lockTopic'] = 'Lock the topic when marked as solved';
and so on

[Suki]

The mod was made during early RC stages or even before, I cannot remember. Chances are it won't work at all with 2.1 codebase or needs to be refactored. Will have to take a look at it but free time has become a scarce luxury these days