Hi vbgamer45!
First of all - great mod! SMF lacks such basic and common functionalities as web push, so this mod is really useful.
I wanted to report some bugs to you. They relate to the @mentions mod. There are a couple of issues - all related to the @mentions mod you provide support to:
1. mod installation file contains an error.
File 'webpush2.xml' contans:
<file name="$languagedir/Mentions.php" error="skip">
should contain:
<file name="$sourcedir/Mentions.php" error="skip">
This mistake basically adds no support for the mentions mod during installation of push notifications
2. There's a bug in the code to be modified inside Mentions.php resulting in a syntax error - HTTP 500 durin execution of the PHP code
File 'webpush2.xml' contans:
$pushurl = $scripturl . '?msg=" . $id_post];
should contain:
$pushurl = $scripturl . '?msg=' . $id_post];
3. and the last bug in the code to be modified inside Mentions.php. There are no title nor message body parameters passed in callup of function webpush_send. The push notification when someone mentions the user is empty
File 'webpush2.xml' contans:
webpush_send($mention['id'], $user_info['id'], $user_info['name'],'tag',$pushurl);
should contain:
webpush_send($mention['id'], $user_info['id'], $user_info['name'],'tag',$pushurl, array('message'=>$subject, 'title'=>''));