Advertisement:

Author Topic: "Announce Topic" Endless Loop  (Read 1213 times)

Offline nhrd

  • Newbie
  • *
  • Posts: 3
"Announce Topic" Endless Loop
« on: February 13, 2019, 08:29:42 AM »
"Announce Topic" results in an endless loop of the continue countdown screen for all users. No announcements are sent.

Version: SMF 2.1 RC1

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,426
    • StoryBB/StoryBB on GitHub
Re: "Announce Topic" Endless Loop
« Reply #1 on: February 13, 2019, 08:44:44 AM »
How many users are you trying to send to?
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline nhrd

  • Newbie
  • *
  • Posts: 3
Re: "Announce Topic" Endless Loop
« Reply #2 on: February 13, 2019, 08:50:03 AM »
About 50

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,426
    • StoryBB/StoryBB on GitHub
Re: "Announce Topic" Endless Loop
« Reply #3 on: February 13, 2019, 08:58:48 AM »
Hm, there’s been various reports of it bugging out with less than 500 users but we’d never been able to consistently reproduce it but I think it will need more investigation.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Massl

  • Jr. Member
  • **
  • Posts: 256

Offline nhrd

  • Newbie
  • *
  • Posts: 3
Re: "Announce Topic" Endless Loop
« Reply #5 on: February 13, 2019, 11:34:25 AM »

Offline Massl

  • Jr. Member
  • **
  • Posts: 256
Re: "Announce Topic" Endless Loop
« Reply #6 on: February 17, 2019, 12:57:01 PM »
I tried now and I have the same error, Sesquipedalian's fix does not solve the endless loop of the countdown.

Online shawnb61

  • Developer
  • Sophist Member
  • *
  • Posts: 1,349
    • sbulen on GitHub
Re: "Announce Topic" Endless Loop
« Reply #7 on: February 17, 2019, 05:06:16 PM »
I think this is a separate, new issue.   I was easily able to replicate this in WAMP & Linux environments. 

Logged https://github.com/SimpleMachines/SMF2.1/issues/5445

Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Offline Massl

  • Jr. Member
  • **
  • Posts: 256

Offline slinke

  • Semi-Newbie
  • *
  • Posts: 25
Re: "Announce Topic" Endless Loop
« Reply #9 on: March 03, 2019, 09:49:04 PM »
"Announce Topic" results in an endless loop of the continue countdown screen for all users. No announcements are sent.

Version: SMF 2.1 RC1

I have this same issue. I have tried to "announce topic" to a 2-member group and a 9-member group. Both times it went into an endless loop with the continue button. I also tried to modify the cron.php file, as suggested elsewhere in this thread, but it did not work for me either. I used the "announce topic" feature when I was running v2.0.15 of SMF, but it has not worked since upgrading to v2.1 RC1.

Offline slinke

  • Semi-Newbie
  • *
  • Posts: 25
Re: "Announce Topic" Endless Loop
« Reply #10 on: April 07, 2019, 02:01:43 AM »
I still have this same error (endless loop when attempting to "announce topic") after the 2.1 RC2 update.

Online shawnb61

  • Developer
  • Sophist Member
  • *
  • Posts: 1,349
    • sbulen on GitHub
Re: "Announce Topic" Endless Loop
« Reply #11 on: April 07, 2019, 07:44:36 PM »
This issue is slated for a fix in RC3.
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Offline live627

  • Development Contributor
  • SMF Hero
  • *
  • Posts: 5,620
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: "Announce Topic" Endless Loop
« Reply #12 on: April 08, 2019, 12:10:49 AM »
I pushed a fix just now that fixes this.

https://github.com/live627/SMF2.1/commit/31e56c545ef540845a8af70d4737d965642b7ec3

I just wish that all  bug fixes were this easy.
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline slinke

  • Semi-Newbie
  • *
  • Posts: 25
Re: "Announce Topic" Endless Loop
« Reply #13 on: April 08, 2019, 01:15:05 PM »
I pushed a fix just now that fixes this.

https://github.com/live627/SMF2.1/commit/31e56c545ef540845a8af70d4737d965642b7ec3

I just wish that all  bug fixes were this easy.

I replaced the Sources/Post.php file with the one on github. However, now I am getting hundreds of "general" errors for "Invalid argument supplied for foreach()", as well as "undefined" errors for "Undefined index: attributes," on Themes/default/Post.template.php Line 1189. I also see a "critical" error for "Invalid value inserted or no type specified.
Function: QuoteFast" on Sources/Post.php Line 2481.

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 51,150
Re: "Announce Topic" Endless Loop
« Reply #14 on: April 08, 2019, 01:18:28 PM »
there have been other commits since RC2 was released. all you needed was the change noted, you may have gotten more changes which is leading to the errors. revert the file back and just change what is necessary.