Odds and sods

[Sir Osis of Liver]

Trying to get myself to like 2.1 RC1 (so far unsuccessfully ), have run into several glitches in IE11, don't know if they've been reported.

- Token failure.  Vaguely remember seeing this in alpha, not sure where it occurred, haven't been able to replicate it.

- User menu fails to open.  Has happened twice, coming out of ACP.  Unable to replicate.  Just happened again, two tabs open, died in both.  Dropping Messages menu, then back to User fixed it.

- Profile option for 'Use full editor toolbar in Quick Reply' does nothing other than add/remove text about manually typing bbc tags, no effect on toolbar.

- This could be written better -

You can add a second level of security to your forum by enabling Two Factor Authentication. 2FA forces your users to add a enter a machine-generated code after the regular login. You need to configure 2FA to yourself before you are able to force it to other users!

[Arantor]

Trying to get myself to like 2.1 RC1 (so far unsuccessfully )

It's nice to know all the hard work is appreciated.

As for the user menu etc. did you take a look in the inspector in case there were any errors logged in there?

[Sir Osis of Liver]

It's nice to know all the hard work is appreciated.

Don't like most of Mozart's music, but wouldn't argue he's not a great composer.

As for the user menu etc. did you take a look in the inspector in case there were any errors logged in there?

Will check if I get it to do it again. 

Server is logging a lot of these -

[21-Feb-2019 17:10:14 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 77

[21-Feb-2019 17:10:14 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 86

[21-Feb-2019 17:10:54 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 77

[21-Feb-2019 17:10:54 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 86

[21-Feb-2019 17:10:58 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 77

[21-Feb-2019 17:10:58 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 86

[21-Feb-2019 17:11:07 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 77

[21-Feb-2019 17:11:07 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 86

[21-Feb-2019 17:11:10 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 77

[21-Feb-2019 17:11:10 America/New_York] PHP Notice:  Use of undefined constant SMF_VERSION - assumed 'SMF_VERSION' in /home/thekrash/public_html/smf21/Sources/Load.php on line 86

[Arantor]

Did you get the patch - https://custom.simplemachines.org/mods/index.php?mod=4208 ?

[Sir Osis of Liver]

Uploading current github package, should include the patch.

Ok, that helped.  Server errors have stopped, full editor option toggles smileys in quick reply, weren't there before.  User menu is behaving so far.

[Sir Osis of Liver]

RC2 - can't remove member approval alert from Admin menu button.  Deleted unapproved member and alert (from Alerts), admin link to member approvals displays no member to approve, still shows one approval alert in button.

Disabling registration removes signup link.  No link, no way for guests to know registration is disabled, very confusing.

[Kindred]

nope...   that last bit is standard SMF logic and I agree with it.

If you can't complete the action, you should not even see the option to select the action.

If registration is disabled, don't show the registration option.  Completely logical and correct behavior, IMO.
not sure how that is confusing.

[Sir Osis of Liver]

We sometimes see posts from people trying unsuccessfully to register on forums.  Anyone with any familiarity with forumware will expect to see a registration link, or something to indicate how to join the forum, or why they cannot.  As far as it being 'standard SMF logic', it hasn't been in the past, afaik all versions thru 2.0.15 display registration links (two in Curve) when reg is disabled, with an error message that explains why you can't register.  It may be logical, but it's no help to new visitors to the forum.

[SychO]

RC2 - can't remove member approval alert from Admin menu button.  Deleted unapproved member and alert (from Alerts), admin link to member approvals displays no member to approve, still shows one approval alert in button.

Did you accept or reject the registration ?

[Sir Osis of Liver]

Went directly to members and deleted it, now there's nothing in approval queue, just the alert in Admin button.

[SychO]

what does "deleted" mean ? did you delete the member's account or did you reject the registration ?

[Sir Osis of Liver]

I didn't reject the registration, I was in Admin -> Members looking at something else, deleted the unapproved registrant, that removed it from Members and from approval queue.  Deleted the alert from Alerts, it's also gone, but the alert in Admin button is still there, no way to remove it.

[SychO]

I didn't reject the registration, I was in Admin -> Members looking at something else, deleted the unapproved registrant, that removed it from Members and from approval queue.  Deleted the alert from Alerts, it's also gone, but the alert in Admin button is still there, no way to remove it.

I see, thanks with this I can try to reproduce the issue

[Sir Osis of Liver]

 

[SychO]

Yup I'm able to reproduce it now, it only happens when you have some accounts that need approval but you have changed the registration mode to something other than approval.

You can fix it by switching back to Admin Approval, and then recounting the stats from the maintenance routine area

logged on github
https://github.com/SimpleMachines/SMF2.1/issues/5697

[Sir Osis of Liver]

You can fix it by switching back to Admin Approval, and then recounting the stats from the maintenance routine area

Yup, it's gone.

Dang, I miss the sidebar menus.

[Sir Osis of Liver]

Caching seems to be different in 2.1, code changes in theme and source files are not applied immediately, if at all.  Caching is disabled in Server Settings.  I can delete blocks of code and nothing changes.  What's causing this?

[Sir Osis of Liver]

2.1 is like a dog.  Don't much like dogs, dogs don't like me.  Nothing wrong with dogs, we just don't get along.

Same with 2.1.

[Antes]

2.1 is like a dog.  Don't much like dogs, dogs don't like me.  Nothing wrong with dogs, we just don't get along.

Same with 2.1.

But its designed by a cat :|

[shawnb61]

Caching seems to be different in 2.1, code changes in theme and source files are not applied immediately, if at all.  Caching is disabled in Server Settings.  I can delete blocks of code and nothing changes.  What's causing this?

I don't see anything like this...   Are you sure you don't have some form of server caching enabled?

[Sesquipedalian]

Caching seems to be different in 2.1, code changes in theme and source files are not applied immediately, if at all.  Caching is disabled in Server Settings.  I can delete blocks of code and nothing changes.  What's causing this?

Toggle the "Minimize CSS and JavaScript" option.

[Sir Osis of Liver]

But its designed by a cat :|

Had a good friend was a cat, died back in the 80's.  I get along quite well with cats.  Cats don't give a ******, and neither do I.

I don't see anything like this...   Are you sure you don't have some form of server caching enabled?

Only happens in 2.1, maybe something to do with the theme.

Toggle the "Minimize CSS and JavaScript" option.

It's checked by default.  Disable it?

[Oldiesmann]

Disable the option, save it, then enable it again.

[Sir Osis of Liver]

Ok, did that.  Will see what happens next time I get around to modding 2.1.

Have to close/open browser to see changes.

[shawnb61]

Or consider leaving the auto-minimize setting disabled.

I think that would be helpful in a dev environment.   

[Sesquipedalian]

Yes, as the help text for the minimization setting says, it is a good idea to turn it off while making changes to your forum's theme files.

[Sir Osis of Liver]

Flipped off/on, it was still balky for while, then it cleared up and I mangled code for a couple hours without a problem.  No idea why.

[Sir Osis of Liver]

Having nothing better to do, Sir Osis is continuing his on again/off again efforts to like 2.1.  Today we're looking at cleaning up ACP (it's a mess ).  Someone had the good idea of making a cpanel style menu, but all the clutter at top of page pushes it down offscreen, so you can't see it.  Didn't know it was there til around beta 2, when someone mentioned it and went looking for it.  You have to scroll down to see it, and if you're using scrollwheel, you get hung up in announcements window (every time ).  It's THE BIG NEW THING, so why hide it?  I think ACP looks/works much better like this -



Files attached, try it.

No need to thank me, doing good is it's own reward.

[landyvlad]

Changes I can see:
1. Removal of verbose guff about Administration Center.
2. Moving support information and 'live from simplemachines' to the bottom of the page ?

My opinions
1. I agree completely - that can be in user guides or whatever. No need for it to be there on the admin page at all.
2. Utterly makes sense to have at the bottom as I look at those very rarely.

Are there any other changes I've missed?

Can we expect ths in RC3 perchance?

[Oldiesmann]

I personally don't care one way or another, but the news and version info is shown at the top because it's important.

[Sir Osis of Liver]

Admin news is like stickies, good idea, but nobody reads them .  The welcome message up top is useful first time you go to ACP, but it's just clutter thereafter.  At minimum, it should be collapsible (Sir Osis was too lazy busy to do that).  The cpanel style menu is a good idea, and should be right there when you go to ACP.

[Sir Osis of Liver]

Can we expect ths in RC3 perchance?

Don't hold your breath.  The basic 2.1 ui has not changed since alpha, it was pretty much set in stone from the getgo.  Suggestions involving any significant changes were very unwelcome.

[landyvlad]

Well I suppose once everything is out in the wash, and 2.1 final is released - you could offer this as a mod - whether officially or just by offering relevant code / files for people to DIY.

Thumbs up from me.

[Sir Osis of Liver]

I'll do that if there's any interest.  Had done same modification in alpha, back in 2015, posted files, no one was interested enough to d/l them even once.  Don't want to do too much until it goes final, they're still chasing bugs, just tinker with it when I have time to kill.

[Sir Osis of Liver]

I've disabled admin security, still have to reenter password.

[Illori]

I've disabled admin security, still have to reenter password.

i have mine disabled and dont have to re-enter the password to enter the admin panel... i dont know what the issue is that you have.

[SychO]

I've disabled admin security, still have to reenter password.

Well, there's moderation center security and then there's admin center security, perhaps you disabled one and not the other and you thought it's not working.

[Aleksi "Lex" Kilpinen]

The usual magical IT-support solutions may also sometimes actually work. Try turning it on and off again.

[Sir Osis of Liver]

Moderation security has nothing to do with admin security (it didn't in 2.0), but I'll try disabling it.

<sigh> Still wants admin password with both disabled.  Same thing on out-of-box and modded installs.

[lurkalot]

Moderation security has nothing to do with admin security (it didn't in 2.0), but I'll try disabling it.

<sigh> Still wants admin password with both disabled.  Same thing on out-of-box and modded installs.

Just out of interest, was your Moderation Security enabled by default?  Reason I ask, is I reported an issue with it ages ago, and fix is going into final, https://github.com/SimpleMachines/SMF2.1/issues/5481

[Arantor]

Moderation security has nothing to do with admin security (it didn't in 2.0), but I'll try disabling it.

<sigh> Still wants admin password with both disabled.  Same thing on out-of-box and modded installs.

Just because it didn't in 2.0 doesn't mean it doesn't in 2.1 - in 2.1, both admin and moderation have separate security protocols (thus, separate putting in the passwords for both), and they both use the same code to do it.

When you say 'out of the box', out of the box *what*? RC1, RC2, a specific GitHub revision?

[Sir Osis of Liver]

RC2 github download from 7 July.

Just out of interest, was your Moderation Security enabled by default?F2.1/issues/5481

Yes it was.

[Arantor]

So there's still two different possible versions it could have been depending on *when* on 7th July you pulled it... when you download from GitHub you get a string of letters and numbers, this can be used to identify very specifically what version of 2.1 you have if you are not using an RC build.

Makes it much quicker for anyone to investigate what's going on...

[Sir Osis of Liver]

Ok, did clean install with today's github package, clean database.  Works like it should.  Where is the github id code?

Settings.php is different, all comments have been removed.  When/why was this done?

Just out of interest, was your Moderation Security enabled by default?F2.1/issues/5481

Default settings are admin security enabled, moderation security disabled.

[Arantor]

Hmm, I thought the filename contained the GitHub hash, because it does if downloading off a master branch (like everything I download off GitHub normally) but if you're on a non-master branch, you're a bit out of luck. However when you download it, you can see the identifier next to the download button - it's usually worth making a note of this. See attachment.

As for Settings.php, the master version - https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/other/Settings.php - has comments, so either they're stripped by the upgrader or they're stripped by whatever you're doing to get the comments. Not sure whether you're copying the version from other/ into the root before installing a fresh install. If you're upgrading, you'll have whatever version you had before - which won't have the comments since 2.0's didn't have lots of comments.

This also assumes you're not using albertlast's nightly build, where things might be different again. (And this is why it's really useful to know exactly what build you're referring to because these things can change)

Default settings are admin security enabled, moderation security disabled.

This makes sense, the moderation security check didn't exist in 2.0.

[Sir Osis of Liver]

I see the last commit code now.  Often don't notice things like that unless I know to look for them (eyes are shot).  The stripped Settings.php was created from scratch by installer in current d/l (e0848c8).  I've always used the download button in your screenshot to get current package.

[Illori]

if you did not copy the Settings.php file over, it is possible the installer would create one for you which would be missing all the comments.

[Sir Osis of Liver]

It's a complete scratch install.  Earlier RC2 install created Settings.php with comments, as per earlier versions, current package creates stripped file.  Don't know if intentions are to stay with stripped file, but that would make things difficult for supporting new users.

[shawnb61]

Yes, if you do not provide the template, the upgrader will save a bare bones settings.php with no comments or logic - settings only.  It will do this on pure vanilla installs.

[albertlast]

You will got a better live when you use the nightly download.

[Sir Osis of Liver]

Where is it?

[albertlast]

https://www.simplemachines.org/community/index.php?topic=558451.0

[Sir Osis of Liver]

Ok, thanks.

[JeanCremers]

hi, i have the member approval count bug. This is suggested as fix:

> You can fix it by switching back to Admin Approval, and then recounting the stats from the maintenance routine area

But i can't find a way to recount stats, where is that please?

[JeanCremers]

never mind, found it, sorry.