Advertisement:

Author Topic: hardcoded 'Themes' path in Sources/Themes.php is wrong! [2.0.15]  (Read 194 times)

Offline piotao

  • Newbie
  • *
  • Posts: 6
Hey, I'd just notice everybody that when you change your default 'Themes' path to something different (which is allowed in Admin), then the forum will never allow you to write to this themes directory again, because of a bug. The 'Themes' path is hardcoded in Themes.php file:

just look for '/Themes' string with grep and you'll find that there should be something different.
So, if I change this by hand to my custom path, it will be overwritten during update, right? Meh!

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,598
    • StoryBB/StoryBB on GitHub
Re: hardcoded 'Themes' path in Sources/Themes.php is wrong! [2.0.15]
« Reply #1 on: April 18, 2019, 01:21:44 PM »
Yes, it's hardcoded. I cannot imagine a single situation you'd *want* to put it anywhere else.

Yes, it will be overwritten if you upgrade to SMF 2.1. It will not be overwritten if you upgrade to SMF 2.0.16 or beyond using the package manager.

Such changes are officially considered unsupported and if you discover other bugs as a result of an unnecessary change, there will not be a lot of help on offer.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.