Advertisement:

Author Topic: jQuery migration  (Read 781 times)

Offline drewactual

  • Full Member
  • ***
  • Posts: 694
    • College Football Fan Site CFB51
jQuery migration
« on: April 30, 2019, 09:34:56 AM »
has anyone here gone through the effort of migrating jQuery to 3.x?  If so, how much of a pain was it? 

currently, with the theme and several mod's, I'm pulling from four different libraries.  the funny thing is, i was playing in the sandbox site and jq3.3 ran it with only a couple warnings and a single error (significant enough error to break functions, though)... this kinda encourages me to go through and do it the right way under the thinking it won't be that painful? 

i'm hoping someone has done this and can offer some insight? 

thanks in advance!

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,648
    • StoryBB/StoryBB on GitHub
Re: jQuery migration
« Reply #1 on: April 30, 2019, 10:02:00 AM »
SMF 2.1 already uses 3.x.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline drewactual

  • Full Member
  • ***
  • Posts: 694
    • College Football Fan Site CFB51
Re: jQuery migration
« Reply #2 on: April 30, 2019, 10:14:03 AM »
i'll ultimately land on 2.1, but the level of effort to carve up a theme required and the mod's my folks use being currently unavailable make the juice not worth the squeeze right now.   my plan is to launch 2.1 in the sandbox and dress it up + thoroughly test it prior to production. 

Offline Suki

  • Kaizoku Jotei
  • Developer
  • SMF Super Hero
  • *
  • Posts: 15,551
  • Oh, wouldn't it be great if I *was* crazy?
    • MissAllSunday on GitHub
    • SMF mods
Re: jQuery migration
« Reply #3 on: April 30, 2019, 10:57:05 AM »
Most mods that uses jquery uses it for cosmetic or otherwise other minor UX stuff, there shouldn't be any issues with upgrading jquery and if they are, must be minor ones relatively easy to fix.

Also: https://jquery.com/upgrade-guide/3.0/
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Look at them. They're just asking for it. Maybe the human race deserves to be wiped out.

Offline drewactual

  • Full Member
  • ***
  • Posts: 694
    • College Football Fan Site CFB51
Re: jQuery migration
« Reply #4 on: April 30, 2019, 01:10:09 PM »
thanks for that, Suki... I've set aside time to attack it soon, and hope it doesn't threat to impact my site (taking it offline, and if so only a short period).