News:

Wondering if this will always be free?  See why free is better.

Main Menu

Javascript error on Firefox

Started by asprin, September 22, 2019, 04:54:05 AM

Previous topic - Next topic

asprin

This is happening in the community forums but I'm not sure if it also happens withing SMF also. But I'll go ahead and report it anyway.

With code blocks, if I click on the "Select" link, it throws an error in Firefox (v 69.0.1). Attaching screenshot for reference.



I don't use Chrome so couldn't test if it's affecting others too.

EDIT: Using the attachment feature since image from imgur doesn't seem to be loading

Arantor

So it happens here on SMF 2.0, does it also happen in 2.1 RC2?

I suppose things have changed in the (quite a few) years since that code was written.

asprin

Quote from: Arantor on September 22, 2019, 04:58:21 AM
So it happens here on SMF 2.0, does it also happen in 2.1 RC2?

I've 2.1 RC2 installed locally. I tested that in Firefox and it works well there. No issues in that version.

shawnb61

Confirmed, & logged on internal 2.0 tracker, #70
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Antechinus

Testing.

<textarea class="editor', $context['locked'] ? ' lockedbg' : '', '" name="', $editor_id, '" id="', $editor_id, '" rows="', $editor_context['rows'], '" cols="600" onselect="storeCaret(this);" onclick="storeCaret(this);" onkeyup="storeCaret(this);" onchange="storeCaret(this);" tabindex="', $context['tabindex']++, '" style="height: ', $editor_context['height'], '; ', isset($context['post_error']['no_message']) || isset($context['post_error']['long_message']) ? 'border: 1px solid red;' : '', '">', $editor_context['value'], '</textarea>
<div id="', $editor_id, '_resizer" class="richedit_resize"></div>

<input type="hidden" name="', $editor_id, '_mode" id="', $editor_id, '_mode" value="0" />
<script type="text/javascript"><!-- // --><![CDATA[';

// Show the smileys.
if ((!empty($context['smileys']['postform']) || !empty($context['smileys']['popup'])) && !$editor_context['disable_smiley_box'] && $smileyContainer !== null)
{
echo '
var oSmileyBox_', $editor_id, ' = new smc_SmileyBox({
sUniqueId: ', JavaScriptEscape('smileyBox_' . $editor_id), ',
sContainerDiv: ', JavaScriptEscape($smileyContainer), ',
sClickHandler: ', JavaScriptEscape('oEditorHandle_' . $editor_id . '.insertSmiley'), ',
oSmileyLocations: {';


ETA: Ok, just FYI: it's fine with Pale Moon 28.7.1, so doesn't affect the Goanna fork of Gecko. :)

shawnb61

Just confirmed this was fixed in 2.0.16.
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

shawnb61

Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Advertisement: