• Welcome to Simple Machines Community Forum. Please login or sign up.
October 25, 2021, 05:52:46 AM

News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord


2.1 - Easy CSS crud reduction, if anyone can be bothered.

Started by Antechinus, September 27, 2019, 09:30:53 PM

Previous topic - Next topic

Antechinus

Quote from: SychO on October 07, 2019, 08:31:25 AM
I don't think it is, since the quickbuttons list items are floated left.

Not in my code they're not. :D I think they are better as inline-block. It saves having to worry about clearing floated content, and it swaps direction for RTL automatically, so no extra float code to worry about for RTL.

IMO this is a better solution for most menu strips. We had to use floats in 2.0.x because IE6 and (I think) IE7 didn't support inline-block, but from IE8 onwards and in any other browser there is full support for inline-block. The only slight catch with inline-block is the roughly 0.25em gap it forces after each element. If you need them sitting tight against each other that's easily dealt with in most cases by margin: 0 -1px. It doesn't matter for the main menu or buttonlist classes because they have gaps between buttons anyway.

The other nifty thing about inline-block is that for narrow screens you can change how they stack (basic code and screenshot here: https://www.simplemachines.org/community/index.php?topic=569433.msg4033649#msg4033649) so it's a bit more versatile than floats in that way too.


QuoteYou might want to just pull the branch where I pushed all changes and take a look, pulling branches is a lot easier than manually applying changes, it helps in the review process.

Bleh. :P GitHub. :P Me hatez GitHub. :P

I was thinking of doing that the other day. Turns out I'd have to go and register Sourcetree (trial period expired ages ago, around the last time I used GitHub). I couldn't be bothered at the time. Might be bothered soon.

SychO

Quote from: Antechinus on October 07, 2019, 02:22:57 PM
Bleh. :P GitHub. :P Me hatez GitHub. :P

Well, Git not GitHub, GitHub is just the platform that uses the version control system "Git"

So you would just have to install git, open your server public folder, open Git Bash there(git command line), and run

$ git clone https://github.com/SychO9/SMF2.1.git
$ git checkout -b antechinus
$ git pull upstream antechinus


Or if you're not comfortable with a command line, you could just install Git then GitHub Desktop.

Just throwing bits of information though, not trying to convince you or anything
Checkout My Themes:
-

Potato  •  Ackerman  •  SunRise  •  NightBreeze

Arantor

The problem is, for many people (including, I think, Antechinus), the problem is the Git part of GitHub, and the blurring between Git and GitHub is mostly irrelevant.
No good deed goes unpunished
All helpful urges should be circumvented

Antechinus

Quote from: SychO on October 07, 2019, 02:43:26 PM
Well, Git not GitHub, GitHub is just the platform that uses the version control system "Git"

So you would just have to install git, open your server public folder, open Git Bash there(git command line), and run

$ git clone https://github.com/SychO9/SMF2.1.git
$ git checkout -b antechinus
$ git pull upstream antechinus


Read this: GitHub for n00bz :D

Also this: If GitHub had built Twitter :P

Antechinus

Quote from: Arantor on October 07, 2019, 02:50:27 PM
The problem is, for many people (including, I think, Antechinus), the problem is the Git part of GitHub, and the blurring between Git and GitHub is mostly irrelevant.

GitHub itself makes a bad thing worse. It's the poo on top of the poo cake.

Arantor

Interesting, what about the -Hub part is bad? (Honestly, there are worse. I should maybe introduce you to Gerrit instances sometime so you can see how poo it can really be.)
No good deed goes unpunished
All helpful urges should be circumvented

Antechinus

Everything about the -Hub part is bad. :D This is why my instructions for n00bz specifically state that any attempt at a GUI that was built by GitHub should be avoided like the plague. This is in relation to downloadable stuff anyway. Obviously you have to use their interface on their actual site. That's not too bad. It's the desktop stuff that is abysmal.

And no, I really do not want to see anything worse.

Gwenwyfar

Yeah, the official desktop GUI is terrible. I don't know how it is today, but when I was using it they were dropping things like showing you when there were differences to sync (oh noes, how dare my interfaceh have a number on it, death to all numbers and to all buttons!) so obviously this meant you never knew if there was anything new. Merge conflicts? Oh just go to the command line to solve them.

Fortunately other programs that are actually decent exist.

Antechinus

I found Sourcetree was excellent for "kevlar vest between me and GitHub". I just have to get enthused about actually registering my copy now, since the trial period has expired.

Arantor

SourceTree used to be good but they keep changing the UI is various ways for no good reason, and it's slower than ever. I recently did some big commits (4000 lines) where the UI became unusable and I had to drop to command line anyway.

At work I don't have any choice, our workflow requires pushing commits in a way that no client understands.
No good deed goes unpunished
All helpful urges should be circumvented

lurkalot

Quote from: Arantor on October 08, 2019, 02:19:16 AM
SourceTree used to be good but they keep changing the UI is various ways for no good reason.


Glad you said that, because I was thinking the same.  In fact when I first used it I had no problem finding my way around, but the later versions seem more complicated to me, logic seems to have gone out the window.  Not only that, when I install the damn thing it disappears from my Windows 10 start menu and can't find it.  I gave up with it.  Been playing with gitkraken recently.

Antechinus

Ok. So maybe I won't bother registering my copy. Is Gitkraken nice and simple? I want to do everything with 3 buttons and no CLI.

lurkalot

Quote from: Antechinus on October 08, 2019, 02:51:27 AM
Ok. So maybe I won't bother registering my copy. Is Gitkraken nice and simple? I want to do everything with 3 buttons and no CLI.

Might be simple for those that know what they're doing, but I find the whole repo stuff generally confusing.  Wish someone would post a actual workflow based on SMF in particular.

There's a load of tuts on youtube, https://www.youtube.com/watch?v=ub9GfRziCtU

Arantor

Quote from: Antechinus on October 08, 2019, 02:51:27 AM
Ok. So maybe I won't bother registering my copy. Is Gitkraken nice and simple? I want to do everything with 3 buttons and no CLI.

I haven't used GitKraken mostly because I don't care enough about SourceTree's revamps of the UI enough to change and most people don't do the kinds of major works that I do, so it's probably fine.

But it doesn't look like it'd be significantly different effort to drive GitKraken; most of the fundamental complexity is Git anyway and a lot of it isn't really avoidable on some level.

Quotebut I find the whole repo stuff generally confusing

That's because it's actually really complicated, far more than it ever appears, mostly because when you have a copy of the code, you now have your own repo with its own history alongside the parent. Great for doing stuff offline and sending online later, not so great for 'simple'.

I'll try and post something for the SMF workflow but ultimately what Ant has in his signature is a workflow that'll work and not require too much mental overhead.
No good deed goes unpunished
All helpful urges should be circumvented

Antechinus

Yep, that's why I came up with it. :D

Looks like Gitkraken won't be any better. I might just go register Sourcetree. If it's too annoying I can always try something else later.

Arantor

See, I just use the repo directly on my machine as the folder inside XAMPP so I don't have a second copy of anything and can commit whenever I like directly from whatever I'm working on, but that has its own issues.
No good deed goes unpunished
All helpful urges should be circumvented

lurkalot

Quote from: Arantor on October 08, 2019, 03:11:30 AM

I'll try and post something for the SMF workflow but ultimately what Ant has in his signature is a workflow that'll work and not require too much mental overhead.

Thanks.  That would be really helpful if you could please.  Actually a new dedicated topic just for this subject would be ideal, and easier to follow.  ;) 

I will try sourcetree again and see how it goes.  I've just got to learn to persevere and stick with one system that works. 

SychO

*scratches head* well I use GitHub Desktop just fine, I mean what it offers is enough, clone repositories,  create branches, push, pull, publish. It's true it used to be somewhat full of bugs and hard to use, but they've fixed a lot and it is much better now.

What more could one ask for ¯\_(ツ)_/¯
Checkout My Themes:
-

Potato  •  Ackerman  •  SunRise  •  NightBreeze

Arantor

I just looked at the newer version of the app (built in Electron), and honestly it looks more confusing to me than someone who deals in SourceTree frequently.

If you're explicitly following the GitHub expected workflows (either you're the main collaborator and can push to your own repo, or you're forking and making a pull request), you're probably fine. Anything more exotic and it doesn't look like it'd handle it.

I also don't expect it to handle anything like a stash, let alone interactive rebasing (which SourceTree can do both)... but I'd be concerned that an app has to reach 2.0 to be 'usable'.
No good deed goes unpunished
All helpful urges should be circumvented

Antechinus

Been reading up about Gitkraken. Apparently you can't use the free version without being logged in to their servers, which is unacceptable anyway.

Advertisement: