Thank you, yes. For my purposes, it has serious issues.
It's easy to cheat, it doesn't allow the post to be edited at all without throwing an error, it consumes the blockquote tag, and it modifies the post text submitted by the user rather than rendering a result without changing the submitted text.
The method I am trying to implement would work something like this:
1. At the time of post submission, parse the post data for roll tags and generate a roll based on that tag.
2. Put the resultant tag and roll result into the database, associated with the post.
3. At the time of viewing a post, fetch the result from the database and display it (like in my previous post, replacing the RESULT_GOES_HERE with a database fetch).
4. At the time of an edit submission, compare all dice bbc codes in the post to the data in the database. If they are identical, no problem. If they are not identical, set a flag on the post that the dice rolls may have been tampered with and show a flag on the post when displayed.
This is a completely different method than that roller uses.
For now, if I can figure out how to make that edit in Subs, as referenced in my last post, I think I have a part of the problem solved, and I suspect I'll be able to solve the rest of it when I start playing with the post-submission code.