2.0.16 Moderation Log Error

[BillLeeDee]

Instead of performing an upgrade on my 2.0.15 install I performed a clean install of 2.0.16 so I could leave the original install as a fallback in case of issues. Well, I came across one that I done see mentioned yet.

When in the Admin Maintenance Logs under "Moderation Log" when attempting to clear log entries that aren't eligible yet due to not being aged wnough I get an error: "Database error, given array of string values is empty. (uneditable)"  and the error log displays the following:

Database error, given array of string values is empty. (uneditable)
Function: ViewModlog
Apply Filter: Only show the errors from this file
File: /home/rootpath/public_html/smfpath/Sources/Modlog.php
Line: 80

When I switch back to the 2.0.15 installation the error doesn't occur. Any ideas? I did a quick search but haven't see it mentioned (or at least find it if somebody has).

Edit: Sorry, just found the discussion under bug reports.

[vbgamer45]

Issue has been logged due to SMF 2.0.16 and we are working on a fix.

[m4z]

I believe that's related to this report about the Admin log.


Edit: Yes it is, and the fix in our internal repo already includes a fix for this.

[Yarik1980]

Edit: Yes it is, and the fix in our internal repo already includes a fix for this.

Put the fix here
The forum is big, it is very necessary
Manually make a change is not a problem

[m4z]

What's the magic word?

I'll ask the devs if that's possible.

[Yarik1980]

What's the magic word?

I'll ask the devs if that's possible.

Not relevant anymore
I rolled back to my stable backup
I will not be updated anymore

[Illori]

you need to keep updated for security. otherwise your forum can get hacked.

[Yarik1980]

you need to keep updated for security. otherwise your forum can get hacked.

thanks
There are a lot of unnecessary things in the update
Security fixes I can make and manually as needed

[Sir Osis of Liver]

Never a good idea to install an upgrade right after release (especially an even-numbered one ), takes a while to work out the bugs.  This was a large, complicated update, I've advised my people to stay with 2.0.15 for a month or two at least, and have not patched my prod forums.  2.0.15 was latest and greatest up until a week ago, it didn't suddenly turn into a pumpkin.

[Kindred]

I would argue that there were NO "unnecessary things" in the 2.0.16/2.0.17 update.  We do not release updates just for the heck of it.

As for "don't use for a while" -- Sir Osis, I've been running the 2.0.16 update on several sites for a month... and 2.0.17 on a dozen more right after it was released - without any trouble.

[Yarik1980]

I would argue that there were NO "unnecessary things" in the 2.0.16/2.0.17 update.  We do not release updates just for the heck of it.

EU's General Data Protection Regulation (GDPR) requirements
I would be glad if it were in the form of a mod
Or could not put during installation
Honestly, I don%u2019t need it at all

[Illori]

then don't enable it, or don't use that feature.

there are many features of SMF I bet you don't use or don't use often. we cant make them all mods.

[Yarik1980]

Anyway, a lot of changes from him
And I use the functions of the forum 100%
+ a lot of other self-written and a lot to order
The update somehow got bad at all of this
Let it be better as it was, on a stable backup
I can fix security myself

P.S. Thanks for the nice forum.

[m4z]

I would argue that there were NO "unnecessary things" in the 2.0.16/2.0.17 update.  We do not release updates just for the heck of it.

EU's General Data Protection Regulation (GDPR) requirements
I would be glad if it were in the form of a mod
Or could not put during installation
Honestly, I don%u2019t need it at all

So you're sure no EU/EEA citizens can access your forum?

[Yarik1980]

While trying to understand why it does not work correctly for me
I ask dear developers to send a fix at least in PM

[shawnb61]

While trying to understand why it does not work correctly for me
I ask dear developers to send a fix at least in PM

My forum has ~30K users.  I've never cleared these logs out.  Ever...  My forum has been around since ~2008.  I keep the logs around so I know what happened.

I'm truly curious... 

Q1:  Do you really need to clear out your admin & mod logs that often?

Q2:  What would happen if you didn't clear them out?  Just reviewed them once in a while for the next few months?

Q3:  Your mod log & admin log are a tiny fraction of your posts, correct?  I.e., it's not a space/storage issue, right?  Or is it?

If I absolutely had to, I'd clear them using SQL. Just trying to understand.

[Yarik1980]

My forum has over 50k users
The forum has a lot of moderators, administrators
A lot of actions are done by them in a day.Logs grow very quickly.Logs are cleaned and analyzed by another administrator...Of course, he does not have access to the database.He says that he began to confuse
I understand that this fix will be included in 2.0.18?

[Yarik1980]

In the morning I got to the laptop, fixed