Advertisement:

Author Topic: Two issues with RC2?  (Read 705 times)

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Two issues with RC2?
« on: January 13, 2020, 07:22:42 AM »
Pretty sure these have been fixed, however, searching on both SMF and GitHub isn't revealing much.

* I'm seeing that posts that contain apostrophes are outputting with slashes. (addslashes/stripslashes issue)

* Clicking "New" to go to the newest reply is putting people at the first post in the thread.

If these two issues have been reported/resolved, I apologize for the clutter.
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 52,147
Re: Two issues with RC2?
« Reply #1 on: January 13, 2020, 07:25:16 AM »
I know the second issue has since been resolved.

the first issue I have not seen myself nor seen reported by anyone.

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Two issues with RC2?
« Reply #2 on: January 13, 2020, 06:15:01 PM »
I just tested issue #1 (attaching screen shot).

Used the standard RC2 package available publicly. Only changes that were made was to rename index.php to forums.php, and to Sources/QueryString.php so that I can run the forums in an iframe.

There's one other change I made to a child theme (index.template.php), however, that doesn't have anything to do with the slashes being added (it's a javascript deal (see my tips and tricks post)).
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Two issues with RC2?
« Reply #3 on: January 20, 2020, 06:13:17 PM »
Has there been any movement on the slashes issue?
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 52,147
Re: Two issues with RC2?
« Reply #4 on: January 20, 2020, 07:40:06 PM »
i dont think so. you could report it in the bugs board or on github, but i dont recall anyone else having that issue so it might be hard to fix.

i tried to duplicate it on my test install and i cant.

Offline Sir Osis of Liver

  • SMF Hero
  • ******
  • Posts: 9,734
Re: Two issues with RC2?
« Reply #5 on: January 20, 2020, 09:17:40 PM »
Doesn't happen to me either with today's github package.

Offline m4z

  • Localizer
  • Sr. Member
  • *
  • Posts: 863
  • /mɛs/
Re: Two issues with RC2?
« Reply #6 on: January 21, 2020, 01:00:44 AM »
I couldn't reproduce either, with an install that was running rc2 for a long time, and is currently running a Github version from mid-December. Never seen the issue; suspecting a mod.
"Faith is what you have in things that don't exist."
--Homer Simpson

Online Massl

  • Jr. Member
  • **
  • Posts: 271
Re: Two issues with RC2?
« Reply #7 on: January 21, 2020, 04:29:49 AM »

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 5,331
  • Gender: Male
    • i30 Owners Club
Re: Two issues with RC2?
« Reply #8 on: January 21, 2020, 05:17:25 AM »
Did you use one of the SMF converters?  When I converted from punBB to SMF I also got those slashes.

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Two issues with RC2?
« Reply #9 on: January 21, 2020, 06:22:40 AM »
Reply #2 outlines exactly how this site is configured. It was upgraded from a 1.0.14 SMF installation.

Thinking out loud here... PHP 7.3 box... if certain Apache/PHP modules are not loaded, is the slashes function a fall-back function?
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 52,147
Re: Two issues with RC2?
« Reply #10 on: January 21, 2020, 07:12:41 AM »
do you recall if the posts with that slashes issue existed before the upgrade? if they did, did they have this issue?

do posts after the upgrade have this issue?

if they are posts from before the upgrade then maybe there is an issue with the upgrade.

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Two issues with RC2?
« Reply #11 on: January 21, 2020, 07:44:36 AM »
The issue did not exist before the upgrade.  The test post I did in reply #2 was done after the upgrade.

Side note: I'm going to do a fresh install of SMF 2.1 on a different server... if the issue doesn't exist there, I'll do a phpinfo() on both boxes to compare the configurations to see if I can spot anything missing.
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Two issues with RC2?
« Reply #12 on: January 21, 2020, 09:33:52 AM »
Okay, so now I'm running this test forum configured exactly the same way as the other site... and cannot reproduce the issue.

Going to re-upload ALL source files from the new site over to the other site and see if that fixes the issue.

Didn't fix the issue... I'm at a loss here...

I did a phpinfo() and compared the two configurations... aside from some minor (but expected) differences, they're identical. They both have the same PHP.ini configs and aside from three Apache modules (which have nothing to do with PHP), Apache is configured the same.

Since I can't give access to the private forum, I'll have to grab whatever info is requested and share it here. Would definitely appreciate any insight people have. :)
« Last Edit: January 21, 2020, 10:18:44 AM by Douglas »
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline SychO

  • On Hiatus
  • SMF Hero
  • *
  • Posts: 1,616
  • Gender: Male
    • SychO9 on GitHub
    • SychO
Re: Two issues with RC2?
« Reply #13 on: January 21, 2020, 11:15:26 AM »
Any mods ?
Take the initiative

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,114
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Two issues with RC2?
« Reply #14 on: January 21, 2020, 04:23:44 PM »
Quote from: Douglas
Used the standard RC2 package available publicly. Only changes that were made was to rename index.php to forums.php, and to Sources/QueryString.php so that I can run the forums in an iframe.

There's one other change I made to a child theme (index.template.php), however, that doesn't have anything to do with the slashes being added (it's a javascript deal (see my tips and tricks post)).

Just to re-confirm, http://test.fearlessfriday.com/ is running the *exact* same configuration as the site I'm having issues with (SMF and customizations). The FF site is not experiencing any issues (I fixed the "new reply" link, thank you!).
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)