Error clusters

Sir Osis of Liver · February 21, 2020, 12:31:30 PM

Working on a forum that's a bit busier than this one, it's been plagued by errors coming from different sources at different times. I've cleaned up a lot of it, upgraded to 2.0.17 running in php 7.2.27. Here's what's in the log since last night -

2 user errors (incorrect pw) Today at 11:29:47 AM - Today at 11:09:49 AM
14 Function create_function() is deprecated - Subs.php Today at 07:19:35 AM - Today at 07:19:35 AM
9 user errors (incorrect pw) Today at 06:13:00 AM - Feb 20, 2020, 09:17:20 PM
50 undefined index (various) - Subs-Post.php Feb 20, 2020, 07:00:31 PM - Feb 20, 2020, 07:00:21 PM
5 user errors (incorrect pw) Feb 20, 2020, 06:34:26 PM - Feb 20, 2020, 03:37:17 PM

Errors occur in bursts, you can see 14 deprecated errors in one second, 50 undefined errors in 10 seconds, then they stop for hours. No server errors. 2.0.17 should not be triggering deprecated code errors in php 7.2. There are less errors overall, but the pattern persists.

Shambles · February 21, 2020, 02:09:11 PM

There are quite a lot of calls to create_function in the 2.0.17 version of Subs.php (mostly bbcode tags)

Are you expecting the errors to be suppressed?

Sir Osis of Liver · February 21, 2020, 10:19:35 PM

Thought 2.0.17 was upgraded to support php 7.2, it shouldn't still have calls to deprecated functions. I'm also not seeing why there are these bursts of errors, then nothing for hours at a time.

SpacePhoenix · February 22, 2020, 01:50:55 AM

What mods are installed?

shawnb61 · February 22, 2020, 03:34:13 AM

I see two things here...

SMF 2.0.17 suppresses the deprecation messages; it does not rewrite those old calls. I have no idea why you can still see those messages. For some reason, the deprecated messages are not suppressed for you as they should be.

I think the undefined index errors are old errors associated with scheduled tasks (they are not new). But due to improvements in error logging, they are more visible.

Sir Osis of Liver · February 22, 2020, 03:54:00 PM

Been having a lot of server problems, we're moving to Crocweb today, that should clear up some this wierd stuff. Will be rebuilding forum from clean install soon as migration is completed.

Sir Osis of Liver · February 23, 2020, 10:38:12 PM

Ok, we're at new host, 2.0.17 running in php 7.2.27. Still getting 'Function create_function() is deprecated' errors in Subs.php, and scheduled task errors in Subs-Post.php. Have seen the latter errors on other forums, not the former. They look like this -

Code Select



https://mlcforum.theherosspouse.com/index.php?topic=34.20;wap2
8192: Function create_function() is deprecated

Can fudge Post-Subs.php to eliminate those errors, they look harmless, but don't know what's causing the Subs.php deprecated errors.

live627 · February 23, 2020, 11:33:20 PM

The code that suppresses the create_function() calls is in Errors.php. Compare yours against a fresh one and report back. Also might wanna check SSI.php. And index.php.

Sir Osis of Liver · February 23, 2020, 11:56:53 PM

This in Errors.php -

Code Select



	// Send these notices introduced by PHP 7.2 to where the sun don't shine!
	if (strpos($error_string, 'create_function()') !== false)
		return true;

Apparently the errors are not being suppressed. Nothing in SSI.php or index.php. Why are the errors being thrown if 2.0.17 supports php 7.2?

From php.net -

Warning This function has been DEPRECATED as of PHP 7.2.0. Relying on this function is highly discouraged.

It's all over Subs.php.

shawnb61 · February 24, 2020, 12:08:56 AM

I saw a report about this once earlier - the fix was:

Code Select

I changed the call to error_reporting() on index.php to error_reporting(E_ALL ^ E_DEPRECATED);.

It's uglier, but makes the work.

I have no idea why this was required, but it was... Let me know if it works for you, too...

live627 · February 24, 2020, 01:07:39 AM

Quote from: Sir Osis of Liver on February 23, 2020, 11:56:53 PM
This in Errors.php -

Code Select Expand
// Send these notices introduced by PHP 7.2 to where the sun don't shine! if (strpos($error_string, 'create_function()') !== false) return true;

Apparently the errors are not being suppressed. Nothing in SSI.php or index.php. Why are the errors being thrown if 2.0.17 supports php 7.2?

it needs to return false

Supporting PHP 7.2 is mainly trying to suppress the errors

Quote from: live627 on January 21, 2020, 08:02:35 PM
The code is littered with tons of calls^[1] to create_function(), which has been deprecated in PHP 7.2. If they were all changed, the patch would cause problems for even more users than it already has because it would be so brittle. Many forums have mods which add code in those affected areas.

So hiding the errors seems to be a good compromise.

This has been properly fixed in SMF 2.1.

[1]: 192 matches
Code Select Expand
grep -nHIirF -- create_function (in directory: C:\wamp64\www\smf20) ./Sources/Display.php:1438: $fixchar = create_function('$n', ' ./Sources/Display.php:1481: $callback = create_function('$buffer', 'return preg_replace(\'~[\r]?\n~\', "\r\n", $buffer);'); ./Sources/Display.php:1483: $callback = create_function('$buffer', 'return preg_replace(\'~[\r]?\n~\', "\r", $buffer);'); ./Sources/Display.php:1485: $callback = create_function('$buffer', 'return preg_replace(\'~[\r]?\n~\', "\n", $buffer);'); ./Sources/Groups.php:197: 'function' => create_function('$group', ' ./Sources/Groups.php:223: 'function' => create_function('$group', ' ./Sources/Load.php:178: 'entity_fix' => create_function('$string', ' ./Sources/Load.php:181: 'htmlspecialchars' => create_function('$string, $quote_style = ENT_COMPAT, $charset = \'ISO-8859-1\'', ' ./Sources/Load.php:184: 'fix_utf8mb4' => create_function('$string', ' ./Sources/Load.php:218: 'htmltrim' => create_function('$string', ' ./Sources/Load.php:221: 'strlen' => create_function('$string', ' ./Sources/Load.php:224: 'strpos' => create_function('$haystack, $needle, $offset = 0', ' ./Sources/Load.php:248: 'substr' => create_function('$string, $start, $length = null', ' ./Sources/Load.php:252: 'strtolower' => $utf8 ? (function_exists('mb_strtolower') ? create_function('$string', ' ./Sources/Load.php:253: return mb_strtolower($string, \'UTF-8\');') : create_function('$string', ' ./Sources/Load.php:257: 'strtoupper' => $utf8 ? (function_exists('mb_strtoupper') ? create_function('$string', ' ./Sources/Load.php:258: return mb_strtoupper($string, \'UTF-8\');') : create_function('$string', ' ./Sources/Load.php:262: 'truncate' => create_function('$string, $length', (empty($modSettings['disableEntityCheck']) ? ' ./Sources/Load.php:270: 'ucfirst' => $utf8 ? create_function('$string', ' ./Sources/Load.php:273: 'ucwords' => $utf8 ? create_function('$string', ' ./Sources/ManageAttachments.php:330: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:372: 'function' => create_function('$rowData',' ./Sources/ManageAttachments.php:389: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:411: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:435: 'function' => create_function('$rowData',' ./Sources/ManageAttachments.php:1676: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:1687: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:243: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:259: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1219: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1241: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1254: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1448: 'function' => create_function('$rowData', ' ./Sources/ManageCalendar.php:114: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:124: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:158: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:179: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:194: 'function' => create_function('$rowData', ' ./Sources/ManageMaintenance.php:782: $entity_replace = create_function('$string', ' ./Sources/ManageMembergroups.php:134: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:165: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:193: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:255: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:272: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:567: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:619: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:913: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:926: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:942: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:240: 'function' => create_function('', ' ./Sources/ManagePaid.php:246: 'function' => create_function('', ' ./Sources/ManagePaid.php:259: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:272: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:312: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:322: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:332: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:675: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:745: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:758: 'function' => create_function('$rowData', ' ./Sources/ManageScheduledTasks.php:460: 'function' => create_function('$rowData', ' ./Sources/ManageSearchEngines.php:219: 'function' => create_function('$rowData', ' ./Sources/ManageSearchEngines.php:235: 'function' => create_function('$rowData', ' ./Sources/ManageSearchEngines.php:689: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:862: 'function' => create_function('', ' ./Sources/ManageServer.php:873: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:885: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:898: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:910: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:922: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:991: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:1002: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:227: 'save_callback' => create_function('$value', ' ./Sources/ManageSettings.php:236: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:264: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:285: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:314: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:347: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:352: 'on_save' => create_function('', ' ./Sources/ManageSettings.php:1337: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1350: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1396: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1414: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1432: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1449: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:374: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:433: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:955: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:977: 'function' => create_function('$rowData', empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir']) ? ' ./Sources/ManageSmileys.php:1616: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:1652: 'function' => create_function('$rowData', ' ./Sources/ModerationCenter.php:1146: 'function' => create_function('$member', ' ./Sources/ModerationCenter.php:1192: 'function' => create_function('$member', ' ./Sources/ModerationCenter.php:1228: 'function' => create_function('$post', ' ./Sources/ModerationCenter.php:1512: 'function' => create_function('$warning', ' ./Sources/ModerationCenter.php:1715: 'function' => create_function('$rowData', ' ./Sources/Modlog.php:263: 'function' => create_function('$entry', ' ./Sources/Profile-Modify.php:183: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:200: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:213: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:236: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:257: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:281: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:314: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:327: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:349: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:371: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:381: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:392: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:410: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:444: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:475: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:496: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:542: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:551: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:569: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:582: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:615: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:639: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:658: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:673: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:682: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:705: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:710: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:743: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:1855: 'function' => create_function('$board', ' ./Sources/Profile-Modify.php:1937: 'function' => create_function('$topic', ' ./Sources/RepairBoards.php:243: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:326: 'process' => create_function('$topics', ' ./Sources/RepairBoards.php:359: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:469: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:492: 'message_function' => create_function('$row', ' ./Sources/RepairBoards.php:527: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:543: 'message_function' => create_function('$row', ' ./Sources/RepairBoards.php:573: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:610: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:652: 'process' => create_function('$cats', ' ./Sources/RepairBoards.php:686: 'process' => create_function('$msgs', ' ./Sources/RepairBoards.php:711: 'process' => create_function('$parents', ' ./Sources/RepairBoards.php:742: 'process' => create_function('$polls', ' ./Sources/RepairBoards.php:773: 'process' => create_function('$events', ' ./Sources/RepairBoards.php:802: 'process' => create_function('$topics', ' ./Sources/RepairBoards.php:831: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:860: 'process' => create_function('$boards', ' ./Sources/RepairBoards.php:889: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:918: 'process' => create_function('$boards', ' ./Sources/RepairBoards.php:947: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:976: 'process' => create_function('$pms', ' ./Sources/RepairBoards.php:1006: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1035: 'process' => create_function('$guestMessages', ' ./Sources/RepairBoards.php:1064: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1091: 'fix_full_processing' => create_function('$result', ' ./Sources/RepairBoards.php:1120: 'message_function' => create_function('$row', ' ./Sources/RepairBoards.php:1147: 'process' => create_function('$deleteTopics', ' ./Sources/RepairBoards.php:1176: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1204: 'process' => create_function('$polls', ' ./Sources/RepairBoards.php:1232: 'process' => create_function('$reports', ' ./Sources/RepairBoards.php:1260: 'process' => create_function('$reports', ' ./Sources/RepairBoards.php:1289: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1318: 'process' => create_function('$groups', ' ./Sources/Subs-Auth.php:539: $fixchar = create_function('$n', ' ./Sources/Subs-Db-sqlite.php:77: sqlite_create_function($connection, 'unix_timestamp', 'smf_udf_unix_timestamp', 0); ./Sources/Subs-Db-sqlite.php:78: sqlite_create_function($connection, 'inet_aton', 'smf_udf_inet_aton', 1); ./Sources/Subs-Db-sqlite.php:79: sqlite_create_function($connection, 'inet_ntoa', 'smf_udf_inet_ntoa', 1); ./Sources/Subs-Db-sqlite.php:80: sqlite_create_function($connection, 'find_in_set', 'smf_udf_find_in_set', 2); ./Sources/Subs-Db-sqlite.php:81: sqlite_create_function($connection, 'year', 'smf_udf_year', 1); ./Sources/Subs-Db-sqlite.php:82: sqlite_create_function($connection, 'month', 'smf_udf_month', 1); ./Sources/Subs-Db-sqlite.php:83: sqlite_create_function($connection, 'dayofmonth', 'smf_udf_dayofmonth', 1); ./Sources/Subs-Db-sqlite.php:84: sqlite_create_function($connection, 'concat', 'smf_udf_concat'); ./Sources/Subs-Db-sqlite.php:85: sqlite_create_function($connection, 'locate', 'smf_udf_locate', 2); ./Sources/Subs-Db-sqlite.php:86: sqlite_create_function($connection, 'regexp', 'smf_udf_regexp', 2); ./Sources/Subs-Members.php:903: $replaceEntities = create_function('$string', ' ./Sources/Subs-Package.php:683: 'function' => create_function('$rowData', ' ./Sources/Subs-Package.php:711: 'function' => create_function('$rowData', ' ./Sources/Subs-Post.php:239: $htmlfunc = create_function('$m', 'return \'[html]\' . strtr(un_htmlspecialchars("$m[1]"), array("\n" => \'\', \' \' => \' \', \'[\' => \'[\', \']\' => \']\')) . \'[/html]\';'); ./Sources/Subs-Post.php:1244: $fixchar = create_function('$n', ' ./Sources/Subs.php:1088: 'validate' => isset($disabled['code']) ? null : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1130: 'validate' => isset($disabled['code']) ? null : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1179: 'validate' => create_function('&$tag, &$data, $disabled', '$data = strtr($data, array(\'<br />\' => \'\'));'), ./Sources/Subs.php:1195: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1214: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1225: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1305: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1316: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1392: 'validate' => isset($disabled['php']) ? null : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1481: 'validate' => $context['browser']['is_ie'] ? create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1491: $data[1] = (int) $data[1];') : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1516: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1553: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1584: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1595: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:2539: return create_function('', " ./Sources/Subs.php:2544: return create_function('',' Search completed with 192 matches. grep -nHIirF -- create_function (in directory: C:\wamp64\www\smf20) ./Sources/Display.php:1438: $fixchar = create_function('$n', ' ./Sources/Display.php:1481: $callback = create_function('$buffer', 'return preg_replace(\'~[\r]?\n~\', "\r\n", $buffer);'); ./Sources/Display.php:1483: $callback = create_function('$buffer', 'return preg_replace(\'~[\r]?\n~\', "\r", $buffer);'); ./Sources/Display.php:1485: $callback = create_function('$buffer', 'return preg_replace(\'~[\r]?\n~\', "\n", $buffer);'); ./Sources/Groups.php:197: 'function' => create_function('$group', ' ./Sources/Groups.php:223: 'function' => create_function('$group', ' ./Sources/Load.php:178: 'entity_fix' => create_function('$string', ' ./Sources/Load.php:181: 'htmlspecialchars' => create_function('$string, $quote_style = ENT_COMPAT, $charset = \'ISO-8859-1\'', ' ./Sources/Load.php:184: 'fix_utf8mb4' => create_function('$string', ' ./Sources/Load.php:218: 'htmltrim' => create_function('$string', ' ./Sources/Load.php:221: 'strlen' => create_function('$string', ' ./Sources/Load.php:224: 'strpos' => create_function('$haystack, $needle, $offset = 0', ' ./Sources/Load.php:248: 'substr' => create_function('$string, $start, $length = null', ' ./Sources/Load.php:252: 'strtolower' => $utf8 ? (function_exists('mb_strtolower') ? create_function('$string', ' ./Sources/Load.php:253: return mb_strtolower($string, \'UTF-8\');') : create_function('$string', ' ./Sources/Load.php:257: 'strtoupper' => $utf8 ? (function_exists('mb_strtoupper') ? create_function('$string', ' ./Sources/Load.php:258: return mb_strtoupper($string, \'UTF-8\');') : create_function('$string', ' ./Sources/Load.php:262: 'truncate' => create_function('$string, $length', (empty($modSettings['disableEntityCheck']) ? ' ./Sources/Load.php:270: 'ucfirst' => $utf8 ? create_function('$string', ' ./Sources/Load.php:273: 'ucwords' => $utf8 ? create_function('$string', ' ./Sources/ManageAttachments.php:330: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:372: 'function' => create_function('$rowData',' ./Sources/ManageAttachments.php:389: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:411: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:435: 'function' => create_function('$rowData',' ./Sources/ManageAttachments.php:1676: 'function' => create_function('$rowData', ' ./Sources/ManageAttachments.php:1687: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:243: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:259: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1219: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1241: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1254: 'function' => create_function('$rowData', ' ./Sources/ManageBans.php:1448: 'function' => create_function('$rowData', ' ./Sources/ManageCalendar.php:114: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:124: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:158: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:179: 'function' => create_function('$rowData', ' ./Sources/ManageMail.php:194: 'function' => create_function('$rowData', ' ./Sources/ManageMaintenance.php:782: $entity_replace = create_function('$string', ' ./Sources/ManageMembergroups.php:134: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:165: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:193: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:255: 'function' => create_function('$rowData', ' ./Sources/ManageMembergroups.php:272: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:567: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:619: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:913: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:926: 'function' => create_function('$rowData', ' ./Sources/ManageMembers.php:942: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:240: 'function' => create_function('', ' ./Sources/ManagePaid.php:246: 'function' => create_function('', ' ./Sources/ManagePaid.php:259: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:272: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:312: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:322: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:332: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:675: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:745: 'function' => create_function('$rowData', ' ./Sources/ManagePaid.php:758: 'function' => create_function('$rowData', ' ./Sources/ManageScheduledTasks.php:460: 'function' => create_function('$rowData', ' ./Sources/ManageSearchEngines.php:219: 'function' => create_function('$rowData', ' ./Sources/ManageSearchEngines.php:235: 'function' => create_function('$rowData', ' ./Sources/ManageSearchEngines.php:689: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:862: 'function' => create_function('', ' ./Sources/ManageServer.php:873: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:885: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:898: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:910: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:922: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:991: 'function' => create_function('$rowData', ' ./Sources/ManageServer.php:1002: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:227: 'save_callback' => create_function('$value', ' ./Sources/ManageSettings.php:236: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:264: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:285: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:314: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:347: 'setting_callback' => create_function('$value', ' ./Sources/ManageSettings.php:352: 'on_save' => create_function('', ' ./Sources/ManageSettings.php:1337: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1350: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1396: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1414: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1432: 'function' => create_function('$rowData', ' ./Sources/ManageSettings.php:1449: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:374: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:433: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:955: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:977: 'function' => create_function('$rowData', empty($modSettings['smileys_dir']) || !is_dir($modSettings['smileys_dir']) ? ' ./Sources/ManageSmileys.php:1616: 'function' => create_function('$rowData', ' ./Sources/ManageSmileys.php:1652: 'function' => create_function('$rowData', ' ./Sources/ModerationCenter.php:1146: 'function' => create_function('$member', ' ./Sources/ModerationCenter.php:1192: 'function' => create_function('$member', ' ./Sources/ModerationCenter.php:1228: 'function' => create_function('$post', ' ./Sources/ModerationCenter.php:1512: 'function' => create_function('$warning', ' ./Sources/ModerationCenter.php:1715: 'function' => create_function('$rowData', ' ./Sources/Modlog.php:263: 'function' => create_function('$entry', ' ./Sources/Profile-Modify.php:183: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:200: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:213: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:236: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:257: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:281: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:314: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:327: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:349: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:371: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:381: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:392: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:410: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:444: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:475: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:496: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:542: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:551: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:569: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:582: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:615: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:639: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:658: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:673: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:682: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:705: 'preload' => create_function('', ' ./Sources/Profile-Modify.php:710: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:743: 'input_validate' => create_function('&$value', ' ./Sources/Profile-Modify.php:1855: 'function' => create_function('$board', ' ./Sources/Profile-Modify.php:1937: 'function' => create_function('$topic', ' ./Sources/RepairBoards.php:243: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:326: 'process' => create_function('$topics', ' ./Sources/RepairBoards.php:359: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:469: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:492: 'message_function' => create_function('$row', ' ./Sources/RepairBoards.php:527: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:543: 'message_function' => create_function('$row', ' ./Sources/RepairBoards.php:573: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:610: 'fix_processing' => create_function('$row', ' ./Sources/RepairBoards.php:652: 'process' => create_function('$cats', ' ./Sources/RepairBoards.php:686: 'process' => create_function('$msgs', ' ./Sources/RepairBoards.php:711: 'process' => create_function('$parents', ' ./Sources/RepairBoards.php:742: 'process' => create_function('$polls', ' ./Sources/RepairBoards.php:773: 'process' => create_function('$events', ' ./Sources/RepairBoards.php:802: 'process' => create_function('$topics', ' ./Sources/RepairBoards.php:831: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:860: 'process' => create_function('$boards', ' ./Sources/RepairBoards.php:889: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:918: 'process' => create_function('$boards', ' ./Sources/RepairBoards.php:947: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:976: 'process' => create_function('$pms', ' ./Sources/RepairBoards.php:1006: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1035: 'process' => create_function('$guestMessages', ' ./Sources/RepairBoards.php:1064: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1091: 'fix_full_processing' => create_function('$result', ' ./Sources/RepairBoards.php:1120: 'message_function' => create_function('$row', ' ./Sources/RepairBoards.php:1147: 'process' => create_function('$deleteTopics', ' ./Sources/RepairBoards.php:1176: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1204: 'process' => create_function('$polls', ' ./Sources/RepairBoards.php:1232: 'process' => create_function('$reports', ' ./Sources/RepairBoards.php:1260: 'process' => create_function('$reports', ' ./Sources/RepairBoards.php:1289: 'process' => create_function('$members', ' ./Sources/RepairBoards.php:1318: 'process' => create_function('$groups', ' ./Sources/Subs-Auth.php:539: $fixchar = create_function('$n', ' ./Sources/Subs-Db-sqlite.php:77: sqlite_create_function($connection, 'unix_timestamp', 'smf_udf_unix_timestamp', 0); ./Sources/Subs-Db-sqlite.php:78: sqlite_create_function($connection, 'inet_aton', 'smf_udf_inet_aton', 1); ./Sources/Subs-Db-sqlite.php:79: sqlite_create_function($connection, 'inet_ntoa', 'smf_udf_inet_ntoa', 1); ./Sources/Subs-Db-sqlite.php:80: sqlite_create_function($connection, 'find_in_set', 'smf_udf_find_in_set', 2); ./Sources/Subs-Db-sqlite.php:81: sqlite_create_function($connection, 'year', 'smf_udf_year', 1); ./Sources/Subs-Db-sqlite.php:82: sqlite_create_function($connection, 'month', 'smf_udf_month', 1); ./Sources/Subs-Db-sqlite.php:83: sqlite_create_function($connection, 'dayofmonth', 'smf_udf_dayofmonth', 1); ./Sources/Subs-Db-sqlite.php:84: sqlite_create_function($connection, 'concat', 'smf_udf_concat'); ./Sources/Subs-Db-sqlite.php:85: sqlite_create_function($connection, 'locate', 'smf_udf_locate', 2); ./Sources/Subs-Db-sqlite.php:86: sqlite_create_function($connection, 'regexp', 'smf_udf_regexp', 2); ./Sources/Subs-Members.php:903: $replaceEntities = create_function('$string', ' ./Sources/Subs-Package.php:683: 'function' => create_function('$rowData', ' ./Sources/Subs-Package.php:711: 'function' => create_function('$rowData', ' ./Sources/Subs-Post.php:239: $htmlfunc = create_function('$m', 'return \'[html]\' . strtr(un_htmlspecialchars("$m[1]"), array("\n" => \'\', \' \' => \' \', \'[\' => \'[\', \']\' => \']\')) . \'[/html]\';'); ./Sources/Subs-Post.php:1244: $fixchar = create_function('$n', ' ./Sources/Subs.php:1088: 'validate' => isset($disabled['code']) ? null : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1130: 'validate' => isset($disabled['code']) ? null : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1179: 'validate' => create_function('&$tag, &$data, $disabled', '$data = strtr($data, array(\'<br />\' => \'\'));'), ./Sources/Subs.php:1195: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1214: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1225: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1305: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1316: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1392: 'validate' => isset($disabled['php']) ? null : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1481: 'validate' => $context['browser']['is_ie'] ? create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1491: $data[1] = (int) $data[1];') : create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1516: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1553: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1584: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:1595: 'validate' => create_function('&$tag, &$data, $disabled', ' ./Sources/Subs.php:2539: return create_function('', " ./Sources/Subs.php:2544: return create_function('',' Search completed with 192 matches.

Sir Osis of Liver · February 24, 2020, 11:46:58 AM

So basically, 2.0.17 is not fully compatible with php 7.2, but we're hiding the errors.

Sounds like something I would do.

Speaking of which, good news is I've fudged away the Subs-Post.php errors, just 4 incorrect pw errors since last night. No Subs.php errors, still don't know what triggers them, but will try return false.

live627 · February 24, 2020, 09:45:46 PM

Quote
Speaking of which, good news is I've fudged away the Subs-Post.php errors,

Err, were they caused by custom code like a mod? Inquiring minds need to know!

Sir Osis of Liver · February 24, 2020, 09:52:11 PM

No, they're apparently caused in core code by scheduled tasks, different errors for different tasks. I'd fixed a couple previously, so only two errors were being thrown. Just fixed those and log is clean. Look for triple slash /// in attached.

Sir Osis of Liver · February 24, 2020, 10:44:03 PM

Still getting a few of these -

/index.php?topic=7209.55;wap2
8192: Function create_function() is deprecated
/forum/Sources/Subs.php
Line: 1584

live627 · February 25, 2020, 06:36:11 AM

ok then do

Quote from: shawnb61 on February 24, 2020, 12:08:56 AM
I saw a report about this once earlier - the fix was:
Code Select Expand
I changed the call to error_reporting() on index.php to error_reporting(E_ALL ^ E_DEPRECATED);. It's uglier, but makes the work.

I have no idea why this was required, but it was... Let me know if it works for you, too...

Sir Osis of Liver · February 25, 2020, 04:39:38 PM

I confused myself (again) added the 'return false' fix to wrong install (have several clones running on different servers). Clean so far today.

Sir Osis of Liver · February 26, 2020, 10:03:12 PM

Server has logged just over 180 mb of 'Function create_function() is deprecated' errors from 25-Feb-2020 18:09:21 to 26-Feb-2020 21:36:25. Forum is no longer logging them.

live627 · February 26, 2020, 11:07:26 PM

what deos the call to error_reporting() on index.php look like?

Sir Osis of Liver · February 26, 2020, 11:12:32 PM

Code Select



// Get everything started up...
define('SMF', 1);
if (function_exists('set_magic_quotes_runtime'))
	@set_magic_quotes_runtime(0);
error_reporting(defined('E_STRICT') ? E_ALL | E_STRICT : E_ALL);
$time_start = microtime();

We've dropped back to php 7.1, seems to have stopped server errors.

News:

Error clusters