News:

SMF 2.1.1 has been released! Take it for a spin! Read more.

Main Menu

Ant's Mutant Curve

Started by Antechinus, February 26, 2020, 11:02:14 PM

Previous topic - Next topic

rcane

Quote from: Kindred on December 10, 2021, 03:44:15 PMDid you fix all of the cases that were broken?

Forgot to answer.  Yes


Still no word from Ant

Sir Osis of Liver

2.0.19 upgrade is balking at this in index.template.php:

Find -


// If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.


Replace -


// If we're in a board, or a topic for that matter, the index will be the board's index.


What's there is this -


    // If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['links']['next']))
        echo '
    <link rel="next" href="', $context['links']['next'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';
    if (!empty($context['links']['prev']))
        echo '
    <link rel="prev" href="', $context['links']['prev'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.


Just delete the first comment and following links?

"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

rcane

Quote from: Sir Osis of Liver on January 04, 2022, 05:28:54 PM2.0.19 upgrade is balking at this in index.template.php:

Find -


// If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.


Replace -


// If we're in a board, or a topic for that matter, the index will be the board's index.


What's there is this -


    // If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['links']['next']))
        echo '
    <link rel="next" href="', $context['links']['next'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';
    if (!empty($context['links']['prev']))
        echo '
    <link rel="prev" href="', $context['links']['prev'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.


Just delete the first comment and following links?



is this index.template in Ant's theme directory?  I presume so, but always safer to ask.

Diego Andrés


SMF Tricks - Free & Premium Responsive Themes for SMF.

rcane

Quote from: Diego Andrés on January 04, 2022, 05:42:48 PMYes, index.template.php

This is what's already in mine.

// If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['links']['next']))
        echo '
    <link rel="next" href="', $context['links']['next'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';
    if (!empty($context['links']['prev']))
        echo '
    <link rel="prev" href="', $context['links']['prev'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.
    if (!empty($context['current_board']))
        echo '
    <link rel="index" href="', $scripturl, '?board=', $context['current_board'], '.0" />';

rcane

I should say, the example to find/replace was in the core>index.template.php file.

The index.template in Ant's directory seemed already to have been corrected.

Sir Osis of Liver

Quote from: Sir Osis of Liver on January 04, 2022, 05:28:54 PM2.0.19 upgrade is balking at this in index.template.php:

Find -


// If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.


Replace -


// If we're in a board, or a topic for that matter, the index will be the board's index.


What's there is this -


    // If we're viewing a topic, these should be the previous and next topics, respectively.
    if (!empty($context['links']['next']))
        echo '
    <link rel="next" href="', $context['links']['next'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';
    if (!empty($context['links']['prev']))
        echo '
    <link rel="prev" href="', $context['links']['prev'], '" />';
    else if (!empty($context['current_topic']))
        echo '
    <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />';

    // If we're in a board, or a topic for that matter, the index will be the board's index.


Just delete the first comment and following links?



Ant?
"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

Antechinus

Quote from: Sir Osis of Liver on January 04, 2022, 05:28:54 PM2.0.19 upgrade is balking at this in index.template.php...
<snip>
Just delete the first comment and following links?
I haven't looked at 2.0.19 yet. I don't think it was released the last time I was here (not sure). It will be something trivial. I'll take a look over the weekend.
Sources code: making easy front end changes difficult since 1873 :P

Mods & Themes | Revamped theme for this site | Dark theme for this site | GitHub for n00bz

Antechinus

#208
Quote from: Kindred on December 13, 2021, 02:06:06 PM@Antechinus

--there does appear to be an issue with your second level sub-menus

Go to a site running this theme with a mobile device
tap the hamburger menu
(main menu is displayed)
tap an item with a second-level sub menu    (in the case of my test site, the help menu item has 3 sub-menu items)
---- problem
the second-level submenu OPENS, for a brief instant before the main menu item link is triggered, thus loading the new page and closing the entire hamburger menu.
I know. That's standard behaviour for pure CSS drop menus (which 2.0.x has) on iOS or Android. This theme does not include jQuery, which is what you would need to get the same behaviour as the 2.1 drops.

IOW, known "feature". Not going to be "fixed".

ETA: As mentioned earlier, the long press workaround is the way to go if you specifically want drop menu content.

I noticed that on GithUb SMF 2.1 is now listed as having no outstanding issues. I supect that means this theme will be of limited use very shortly. ;)
Sources code: making easy front end changes difficult since 1873 :P

Mods & Themes | Revamped theme for this site | Dark theme for this site | GitHub for n00bz

Antechinus

Quote from: rcane on December 10, 2021, 09:00:09 AMGood morning,

Using the Mutant Curve (nice theme btw).

Could you provide some guidance on importing an image to replace the gradient at the header?  Just the header area; it's fine from the menu buttons downward.
Do you still need help with this? It's just basic CSS edits.
Sources code: making easy front end changes difficult since 1873 :P

Mods & Themes | Revamped theme for this site | Dark theme for this site | GitHub for n00bz

Antechinus

Quote from: dbovine on November 21, 2021, 09:47:40 AMHi, I had messaged you about trying to add a Like button but before install it says failed when it comes to your theme files
Here is a link to the mod I was trying to use
Like Post
Sorry. Went AWOL for a while. Will take a look if you still need it.
Sources code: making easy front end changes difficult since 1873 :P

Mods & Themes | Revamped theme for this site | Dark theme for this site | GitHub for n00bz

rcane

Could you take a look at post #198?

Submenu pop-out (or drop down depending on how you look at it) has issue on mobile. 

I'm building two more sister sites and would really like to keep the theme since I've gotten used to things.

Kindred

Ant already responded about that.

It's FAD.
Unfortunately,  without Javascript,  that's how the drop downs behave on mobile
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Antechinus

It woudn't be hard to add jQuery and Superclick to the theme, if anyone really wants to. The drawback is that some 2.0.x mods also shoehorn in their own (probably outdated) copy of jQuery, without checking for other copies, which then leads to issues if the theme already has it.

I don't want that bunfight landing on my doorstep, but if anyone wants to do it for their own use (without blaming me if mods then break it) the code edits required would be pretty trivial.
Sources code: making easy front end changes difficult since 1873 :P

Mods & Themes | Revamped theme for this site | Dark theme for this site | GitHub for n00bz

rcane

Quote from: Antechinus on January 28, 2022, 07:24:26 AMIt woudn't be hard to add jQuery and Superclick to the theme, if anyone really wants to. The drawback is that some 2.0.x mods also shoehorn in their own (probably outdated) copy of jQuery, without checking for other copies, which then leads to issues if the theme already has it.

I don't want that bunfight landing on my doorstep, but if anyone wants to do it for their own use (without blaming me if mods then break it) the code edits required would be pretty trivial.

I'd be willing to break my test forum and try it.
I'd also have to check the mods (only a few) I use to see if they have a problem.


dan4ever

Quote from: Antechinus on January 27, 2022, 07:38:02 PM
Quote from: Kindred on December 13, 2021, 02:06:06 PM@Antechinus

--there does appear to be an issue with your second level sub-menus

Go to a site running this theme with a mobile device
tap the hamburger menu
(main menu is displayed)
tap an item with a second-level sub menu    (in the case of my test site, the help menu item has 3 sub-menu items)
---- problem
the second-level submenu OPENS, for a brief instant before the main menu item link is triggered, thus loading the new page and closing the entire hamburger menu.
I know. That's standard behaviour for pure CSS drop menus (which 2.0.x has) on iOS or Android. This theme does not include jQuery, which is what you would need to get the same behaviour as the 2.1 drops.

IOW, known "feature". Not going to be "fixed".

ETA: As mentioned earlier, the long press workaround is the way to go if you specifically want drop menu content.

I noticed that on GithUb SMF 2.1 is now listed as having no outstanding issues. I supect that means this theme will be of limited use very shortly. ;)
I reported about submenu, not showing up on mobil phone, long time ago (juli 09, 2021, 12:49:33 PM).
We can't use picture from a mobile phone beaqcuse of this.
We are till waiting for a work around!!!!
Here is my first report 
https://www.simplemachines.org/community/index.php?topic=572053.msg4091454#msg4091454
Very slow support!!!

/Dan
/Dan Olsson, Webmaster at https://www.guldforum.se

Kindred

not very slow support --  the author of the theme very specifically has indicated that he never intended to use Javascript -- so the behavior is FAD.

Also, your report is incorrect.
The submenus ARE available on mobile, through a LONG PRESS... This is how CSS dropdown menus work.
The drop down menus work just fine on PC browsers.
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

rcane

Quote from: Kindred on January 31, 2022, 02:06:46 PMThe submenus ARE available on mobile, through a LONG PRESS... This is how CSS dropdown menus work.
The drop down menus work just fine on PC browsers.


Not entirely how they actually appear.

They "work" after a long press but ( in the case of iOS at least) you have to then clear the "new tab" window that proposes to open in the browser, and THEN you will see the drop downs waiting underneath for use.

So while they work I wouldn't call it functional per se' because I've experienced far too many users not creative enough to do a long press / clear window / tap again.

They do though function just fine on a desktop browser.

Kindred

yes.... and as Ant said, this is FAD for the CSS menus.
To have them act otherwise would require javascript which he did not (currently) plan to add.
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

rcane

Quote from: Kindred on January 31, 2022, 02:22:47 PMyes.... and as Ant said, this is FAD for the CSS menus.
To have them act otherwise would require javascript which he did not (currently) plan to add.

Oh I wasn't challenging that. 
I was commenting on your use of the word "work".   Yes, they "work", but in the mind of a user who expects things to be simplistic, it's not practically functional--longpress/clear/tap.  Hence the button I made.  I like the theme more than having to go find a wondrous drop-down.

Advertisement: