2.1 Insert attachments

[ozp]

I found some peculiar behavior in latest from git, but same behavior is on rc2

After inserting an image attachment to the post it looks like this.

The thumbnail is shown. If you click on the thumbnail under the post, the image in the post it toggled to full size.

If turning of the setting "Display image attachments as pictures under post" it looks like this.

Just a link to the image.

I did not imaging that this setting should block images in the post to not show up.
Maybe we should insert an [img tag instead of an [attach for images?

Then I found another thing
If a user with post moderation active for attachments it looks like this if the attachment is inserted into the post.
First with the [attach tag and then with the [img tag.


For another user that do not have moderation premissing it looks like this.


The [attach tag is blocked, but not the [img tag